TL;DR: +1 for document rules / guidance of review trailers in commit
message, and +1 for continuing using the signed-off-by message for
"reviewed by" and/or "co-authored-by" semantic (committers only), adding
explicit preamble in the "Git best practice" chapter in our hbase book [1].
I did some
[
https://issues.apache.org/jira/browse/HBASE-25113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang resolved HBASE-25113.
Resolution: Fixed
Merged. Thanks [~Ddupg] for contributing.
> [testing] HBaseCluster
[
https://issues.apache.org/jira/browse/HBASE-25213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang resolved HBASE-25213.
Fix Version/s: 2.4.0
3.0.0-alpha-1
Resolution: Fixed
Merged.
I expressly would like to see non-commiters given credit for reviews and
have made a point of including them in prior commits for signed-off-by to
do that.
I'm fine with the idea of us using some other means to indicate this, but
I'd like us to make sure there's not some already widely used bit
