Re: [DISCUSS] Merge HBASE-26067 branch into master, and backport it to base 2 branches

2021-12-15 Thread Duo Zhang
I suggest we start a formal vote thread after we finish all the works :) And #3861 is not a blocker, I think we still have some concerns on how to collect the metrics at region server side to master side. We could do it after merging back the feature branch. Thanks. Josh Elser 于2021年12月15日周三

Re: [DISCUSS] Merge HBASE-26067 branch into master, and backport it to base 2 branches

2021-12-14 Thread Josh Elser
Thanks for your input, Andrew and Nick! Big thank you to Duo for your hands-on-keyboard commitment as well for this whole feature. I am also happy to target 2.x (and not 2.5.x) for the backport. In the interest of getting rid of this feature branch (and the inevitable rebase pains the

Re: [DISCUSS] Merge HBASE-26067 branch into master, and backport it to base 2 branches

2021-12-08 Thread Andrew Purtell
+1 for merging to branch-2 (2.6) > On Dec 8, 2021, at 6:04 PM, 张铎 wrote: > > I think here we just want this to be backported to 2.x, not 2.5.x. > > So thanks Andrew for the quick action. > > +1 on merging HBASE-26067 to master and backporting to branch-2(2.6.0). > > Thanks. > > Andrew

Re: [DISCUSS] Merge HBASE-26067 branch into master, and backport it to base 2 branches

2021-12-08 Thread Duo Zhang
I think here we just want this to be backported to 2.x, not 2.5.x. So thanks Andrew for the quick action. +1 on merging HBASE-26067 to master and backporting to branch-2(2.6.0). Thanks. Andrew Purtell 于2021年12月9日周四 08:45写道: > I concur with Nick, but let me help here by branching 2.5 today.

Re: [DISCUSS] Merge HBASE-26067 branch into master, and backport it to base 2 branches

2021-12-08 Thread Andrew Purtell
I concur with Nick, but let me help here by branching 2.5 today. It was always going to be somewhat arbitrary a point. On Wed, Dec 8, 2021 at 3:09 PM Nick Dimiduk wrote: > Based solely on the comments made to this thread, I would recommend against > a merge to branch-2, given that we are very

Re: [DISCUSS] Merge HBASE-26067 branch into master, and backport it to base 2 branches

2021-12-08 Thread Nick Dimiduk
Based solely on the comments made to this thread, I would recommend against a merge to branch-2, given that we are very close to 2.5. The points about existing gaps seem like things we're not ready to publish in the impending minor release. Once we have a branch-2.5, this particular concern of

Re: [DISCUSS] Merge HBASE-26067 branch into master, and backport it to base 2 branches

2021-12-08 Thread Josh Elser
I was going to wait for some other folks to chime in, but I guess I can be the next one :) Duo, Wellington, and Szabolcs have been doing some excellent work on the storefile tracking (SFT) to a degree that I never expected to see. I remember some of the original "Filesystem re-do" issues on

[DISCUSS] Merge HBASE-26067 branch into master, and backport it to base 2 branches

2021-12-07 Thread Wellington Chevreuil
Hello everyone, We have been making progress on the alternative way of tracking store files originally proposed by Duo in HBASE-26067. To briefly summarize it for those not following it, this feature introduces an abstraction layer to track store files still used/needed by store engines,