Re: DISCUSS: Remove hbase-backup from master?

2021-05-13 Thread Mallikarjun
Sure. I have assigned it to myself. Will look into it. Last time I checked, I did not find any failed tests and it was not hadoop3 --- Mallikarjun On Fri, May 14, 2021 at 2:34 AM Nick Dimiduk wrote: > Hi Mallikarjun, > > I just saw a bunch of backup tests fail on an unrelated PR build. I

Re: DISCUSS: Remove hbase-backup from master?

2021-05-13 Thread Nick Dimiduk
Hi Mallikarjun, I just saw a bunch of backup tests fail on an unrelated PR build. I filed HBASE-25888 and uploaded some logs. I have the full test-logs.zip file, but it's too big to upload to jira. I linked it from the Jira, but the archive will disappear when the PR is eventually closed. I would

Re: DISCUSS: Remove hbase-backup from master?

2020-12-23 Thread Mallikarjun
Yea. I have noticed that. I have some patches ready and have to add unit tests. Will start raising in a couple of weeks time. --- Mallikarjun On Thu, Dec 24, 2020 at 7:48 AM 张铎(Duo Zhang) wrote: > The UTs in the backup module are easy to fail with NPE, I've seen this in > several pre commit

Re: DISCUSS: Remove hbase-backup from master?

2020-12-23 Thread Duo Zhang
The UTs in the backup module are easy to fail with NPE, I've seen this in several pre commit results. Any progress here? mallik.v.ar...@gmail.com 于2020年12月3日周四 上午9:58写道: > On Tue, Dec 1, 2020 at 11:26 PM Stack wrote: > > > On Tue, Dec 1, 2020 at 6:38 AM mallik.v.ar...@gmail.com < > >

Re: DISCUSS: Remove hbase-backup from master?

2020-12-02 Thread mallik.v.ar...@gmail.com
On Tue, Dec 1, 2020 at 11:26 PM Stack wrote: > On Tue, Dec 1, 2020 at 6:38 AM mallik.v.ar...@gmail.com < > mallik.v.ar...@gmail.com> wrote: > > > On Tue, Dec 1, 2020 at 7:34 PM Sean Busbey wrote: > > > > > One reason for moving it out of core is that at some point we will have > > > hbase 3

Re: DISCUSS: Remove hbase-backup from master?

2020-12-01 Thread Stack
On Tue, Dec 1, 2020 at 6:38 AM mallik.v.ar...@gmail.com < mallik.v.ar...@gmail.com> wrote: > On Tue, Dec 1, 2020 at 7:34 PM Sean Busbey wrote: > > > One reason for moving it out of core is that at some point we will have > > hbase 3 releases. Right now hbase 3 targeted things are in the master >

Re: DISCUSS: Remove hbase-backup from master?

2020-12-01 Thread mallik.v.ar...@gmail.com
On Tue, Dec 1, 2020 at 7:34 PM Sean Busbey wrote: > One reason for moving it out of core is that at some point we will have > hbase 3 releases. Right now hbase 3 targeted things are in the master > branch. If the feature is not sufficiently ready to be in a release then > when the time for HBase

Re: DISCUSS: Remove hbase-backup from master?

2020-12-01 Thread Sean Busbey
One reason for moving it out of core is that at some point we will have hbase 3 releases. Right now hbase 3 targeted things are in the master branch. If the feature is not sufficiently ready to be in a release then when the time for HBase 3 releases comes we'll have to do work to pull it out of

Re: DISCUSS: Remove hbase-backup from master?

2020-12-01 Thread mallik.v.ar...@gmail.com
On Tue, Dec 1, 2020 at 12:14 PM Stack wrote: > On Mon, Nov 30, 2020 at 9:30 PM mallik.v.ar...@gmail.com < > mallik.v.ar...@gmail.com> wrote: > > > Inline > > > > On Tue, Dec 1, 2020, 10:10 AM Andrew Purtell > > wrote: > > > > > We are allowed to debate if this should be in the tree or not.

Re: DISCUSS: Remove hbase-backup from master?

2020-11-30 Thread Stack
On Mon, Nov 30, 2020 at 9:30 PM mallik.v.ar...@gmail.com < mallik.v.ar...@gmail.com> wrote: > Inline > > On Tue, Dec 1, 2020, 10:10 AM Andrew Purtell > wrote: > > > We are allowed to debate if this should be in the tree or not. Given the > > lack of interest, as evidenced by incomplete state,

Re: DISCUSS: Remove hbase-backup from master?

2020-11-30 Thread mallik.v.ar...@gmail.com
Inline On Tue, Dec 1, 2020, 10:10 AM Andrew Purtell wrote: > We are allowed to debate if this should be in the tree or not. Given the > lack of interest, as evidenced by incomplete state, lack of release, and > lack of contribution, it is more than fair to discuss removal. > > Here is my take:

Re: DISCUSS: Remove hbase-backup from master?

2020-11-30 Thread mallik.v.ar...@gmail.com
Inline On Mon, Nov 30, 2020, 9:56 PM Andrew Purtell wrote: > If we have unmaintained and unreleased, and unreleasable, code sitting in > the tree it should be moved out or deleted. > > > We could use replication to backup the WALs, and use Snapshot and > ExportSnapshot to backup the HFiles. > >

Re: DISCUSS: Remove hbase-backup from master?

2020-11-30 Thread Andrew Purtell
We are allowed to debate if this should be in the tree or not. Given the lack of interest, as evidenced by incomplete state, lack of release, and lack of contribution, it is more than fair to discuss removal. Here is my take: First of all, it is not released. There is no implied roadmap or

Re: DISCUSS: Remove hbase-backup from master?

2020-11-30 Thread mallik.v.ar...@gmail.com
On Mon, Nov 30, 2020 at 9:59 PM Stack wrote: > On Mon, Nov 30, 2020 at 5:55 AM mallik.v.ar...@gmail.com < > mallik.v.ar...@gmail.com> wrote: > > > Inline. > > > > On Sun, Nov 29, 2020, 9:18 AM 张铎(Duo Zhang) > wrote: > > > > > I'm afraid it is not easy to be moved to hbase-operator-tools. > > >

Re: DISCUSS: Remove hbase-backup from master?

2020-11-30 Thread Stack
On Mon, Nov 30, 2020 at 5:55 AM mallik.v.ar...@gmail.com < mallik.v.ar...@gmail.com> wrote: > Inline. > > On Sun, Nov 29, 2020, 9:18 AM 张铎(Duo Zhang) wrote: > > > I'm afraid it is not easy to be moved to hbase-operator-tools. > > > > You can see the code under the

Re: DISCUSS: Remove hbase-backup from master?

2020-11-30 Thread Andrew Purtell
If we have unmaintained and unreleased, and unreleasable, code sitting in the tree it should be moved out or deleted. > We could use replication to backup the WALs, and use Snapshot and > ExportSnapshot to backup the HFiles. This is essentially how we have implemented backup at the $dayjob.

Re: DISCUSS: Remove hbase-backup from master?

2020-11-30 Thread Duo Zhang
mallik.v.ar...@gmail.com 于2020年11月30日周一 下午9:55写道: > Inline. > > On Sun, Nov 29, 2020, 9:18 AM 张铎(Duo Zhang) wrote: > > > I'm afraid it is not easy to be moved to hbase-operator-tools. > > > > You can see the code under the org.apache.hadoop.hbase.backup.master > > package, we need to set up log

Re: DISCUSS: Remove hbase-backup from master?

2020-11-30 Thread mallik.v.ar...@gmail.com
Inline. On Sun, Nov 29, 2020, 9:18 AM 张铎(Duo Zhang) wrote: > I'm afraid it is not easy to be moved to hbase-operator-tools. > > You can see the code under the org.apache.hadoop.hbase.backup.master > package, we need to set up log cleaner at master side, and also, > the

Re: DISCUSS: Remove hbase-backup from master?

2020-11-28 Thread Duo Zhang
I'm afraid it is not easy to be moved to hbase-operator-tools. You can see the code under the org.apache.hadoop.hbase.backup.master package, we need to set up log cleaner at master side, and also, the LogRollMasterProcedureManager class needs MasterServices(not MasterRpcServices), which means it

DISCUSS: Remove hbase-backup from master?

2020-11-19 Thread Stack
It strikes me as work that has been abandoned with no supporting developer. It has had no improvement and few commits other than adjustment because a backing dependency has changed since original contribution. It has not been included in a release so has no users as yet. Does anyone use it or want