Re: Possible bookkeeping error in BaseLoadBalancer

2017-02-16 Thread Timothy Brown
Ok I created HBASE-17658 to track this. I've also found a test that I can modify to prove the issue. On Wed, Feb 15, 2017 at 4:45 PM, Ted Yu wrote: > Looks like the current code has the assignment reverted. > > Can you log a JIRA ? > > If you c

Re: Possible bookkeeping error in BaseLoadBalancer

2017-02-15 Thread Ted Yu
Looks like the current code has the assignment reverted. Can you log a JIRA ? If you can show the defect through modified unit test, that would be nice. On Wed, Feb 15, 2017 at 4:20 PM, Timothy Brown wrote: > Sorry I pasted code that I had modified. I am looking at the master branch > though.

Re: Possible bookkeeping error in BaseLoadBalancer

2017-02-15 Thread Timothy Brown
Sorry I pasted code that I had modified. I am looking at the master branch though. Why would the numRegionsPerServerPerTable[newServer][tableIndex] be set to the existing numMaxRegionsPerTable[tableIndex]? it seems like this should be switched to what I pasted. On Wed, Feb 15, 2017 at 2:58 PM, Ted

Re: Possible bookkeeping error in BaseLoadBalancer

2017-02-15 Thread Ted Yu
In master branch, I see this: if (numRegionsPerServerPerTable[newServer][tableIndex] > numMaxRegionsPerTable[tableIndex]) { numRegionsPerServerPerTable[newServer][tableIndex] = numMaxRegionsPerTable[tableIndex]; which branch are you looking at ? Thanks On Wed, Feb 15, 2017 at 2:4

Possible bookkeeping error in BaseLoadBalancer

2017-02-15 Thread Timothy Brown
Hi, I was wondering if someone could confirm or deny my suspicion that the "numMaxRegionsPerTable" is not being updated properly at line 670 of BaseLoadBalancer.java