Re: [NOTICE] PreCommit now running against Hadoop3 artifacts successfully

2017-10-01 Thread Ted Yu
It would be nice if the link is included in QA report when compilation against hadoop 3 fails: https://issues.apache.org/jira/browse/HBASE-17441?focusedCommentId=16186839=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16186839 Thanks On Sun, Oct 1, 2017 at 4:28 PM,

Re: [NOTICE] PreCommit now running against Hadoop3 artifacts successfully

2017-10-01 Thread Sean Busbey
The output of each hadoop-specific build are available in the build's artifacts. They show up in the 'patchprocess' directory with the name 'patch-javac-%hadoop_version%.txt'. So the hadoop-3 build is here:

Re: [NOTICE] PreCommit now running against Hadoop3 artifacts successfully

2017-10-01 Thread Ted Yu
I was looking under https://builds.apache.org/job/PreCommit-HBASE-Build/8875 but didn't seem to find the output which shows the compilation error against hadoop-3. Do you know if the output can be retrieved from Jenkins or, does developer have to perform build against hadoop-3 locally ? Thanks,

[NOTICE] PreCommit now running against Hadoop3 artifacts successfully

2017-10-01 Thread Josh Elser
tl;dr You may start seeing some new "failures" WRT Hadoop3 compatibility with PreCommit builds. They are (very likely) true negatives. Sean, Appy, and myself think we got to the bottom of why our PreCommit had let (at least two) patches that broke Hadoop3 compatibility on HBASE-17441. From

Re: [DISCUSS] update our imports layout

2017-10-01 Thread Josh Elser
Playing devil's advocate: Do we want to maintain our own "special" way of doing imports instead of relying on something such as the Google Java style guide? [1] +1 to the idea of cleaning things up, but just curious if people feel like our special import ordering is important (and not just

Re: Welcome Chia-Ping Tsai to the HBase PMC

2017-10-01 Thread Josh Elser
Congrats! On 9/29/17 6:19 PM, Misty Stanley-Jones wrote: The HBase PMC is delighted to announce that Chia-Ping Tsai has agreed to join the HBase PMC, and help to make the project run smoothly. Chia-Ping became an HBase committer over 6 months ago, based on long-running participate in the HBase

[HBASE-14850]How compile simple-client with CMake?

2017-10-01 Thread Andrzej
How is best way to write CMakeLists.txt of simple client with all dependencies? There ale many modules, files compilated by protoc, etc.

Re: [DISCUSS] update our imports layout

2017-10-01 Thread Ted Yu
+1 on not using wildcard import . On Sun, Oct 1, 2017 at 10:24 AM, Peter Somogyi wrote: > I like the layout you suggested Chia-Ping and also to check this in the > precommit run. > Shall we also add "not to use * imports" to the verification? > > On Sun, Oct 1, 2017 at

Re: [DISCUSS] update our imports layout

2017-10-01 Thread Peter Somogyi
I like the layout you suggested Chia-Ping and also to check this in the precommit run. Shall we also add "not to use * imports" to the verification? On Sun, Oct 1, 2017 at 9:09 AM, Chia-Ping Tsai wrote: > bq. I guess you meant attention. > You are right. sorry for the

Re: [DISCUSS] Move Type out of KeyValue

2017-10-01 Thread Andrew Purtell
Ok, thanks. I understand now. +1 > On Sep 30, 2017, at 9:28 PM, Chia-Ping Tsai wrote: > > The "custom cell type" never exists in the story. (Sorry for misleading you) > > Here is the story. i add some custom cells (for saving memory) to Put via > Put#add(Cell). The

Re: [DISCUSS] update our imports layout

2017-10-01 Thread Chia-Ping Tsai
bq. I guess you meant attention. You are right. sorry for the misspelling. ☹ On 2017-10-01 23:33, Ted Yu wrote: > bq. hold our attraction > > I guess you meant attention. > > The suggestions under Q1 are good. > > > > On Sun, Oct 1, 2017 at 8:27 AM, Chia-Ping Tsai

Re: [DISCUSS] update our imports layout

2017-10-01 Thread Ted Yu
bq. hold our attraction I guess you meant attention. The suggestions under Q1 are good. On Sun, Oct 1, 2017 at 8:27 AM, Chia-Ping Tsai wrote: > hi folks, > > I noticed the code conflict occurs on the imports frequently. To resolve > the conflict is a complete waste of

Re: [HBASE-14850]Will shared object client as task in near future?

2017-10-01 Thread Ted Yu
Design and implementation of HBASE-14850 project follows C++ (11/14) standard. Please design your client application accordingly. Cheers On Sun, Oct 1, 2017 at 6:25 AM, Andrzej wrote: > W dniu 30.09.2017 o 14:51, Ted Yu pisze: > >> bq. smart pointers, which hinders

Re: [HBASE-14850]Will shared object client as task in near future?

2017-10-01 Thread Andrzej
W dniu 30.09.2017 o 14:51, Ted Yu pisze: bq. smart pointers, which hinders simple pointers values as arguments and return values I don't quite get what you meant. Can you elaborate ? My trial exported function: Table *soGetTable(Client *client, char *name) { //name ==> tn return

Re: [DISCUSS] Becoming a Committer

2017-10-01 Thread Chia-Ping Tsai
The is a great discussion. And i love misty's list. Don't let this die. What about putting the summary in our docs? -- Chia-Ping On 2017-09-30 02:34, Andrew Purtell wrote: > This conversation is in a good place. I apologize for the tone of my > earlier allergic reaction