[
https://issues.apache.org/jira/browse/HBASE-23045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani reopened HBASE-23045:
--
Not yet committed to any branch. Reopening.
> currentPath may be stitched in a loop in
... and if you do commit a "cleanup" but don't backport it all the way to
branch-1, then you are doing other committers a disservice, in my opinion.
On Fri, Jan 10, 2020 at 5:15 PM Andrew Purtell wrote:
> I will go so far to claim "cleanup" issues can easily be a net negative
> given how
I will go so far to claim "cleanup" issues can easily be a net negative
given how burdensome the divergence between branches becomes as a result of
them. With my PMC hat on, and one who frequently does backports, and
intends to do more of them, I would like every committer to consider the
value of
I'm talking about "cleanups", not introduction of new warnings. New
warnings should be caught in commit and fixed before commit.
It's pretty simple -- per the original post and the points I've called out
-- there is a cost benefit tradeoff and not every "cleanup" issue takes
that into account.
On Fri, Jan 10, 2020 at 16:53 Andrew Purtell wrote:
>
> "Please don't run code analysis tools and then open many JIRAs that
> document those findings. That activity does not put any thought into this
> cost-benefit analysis."
>
> On this latter point, it also includes trivial checkstyle nits and
For me the two most important points are
"Before opening any JIRA, please always consider whether or not the added
usability will outweigh the added pain you are causing other developers. *If
you believe the benefits outweigh the costs, please backport the changes
yourself to all active lines.* "
+1
* Signature: ok
* Checksum : ok
* Rat check (1.8.0_232): ok
- mvn clean apache-rat:check
* Built from source (1.8.0_232): ok
- mvn clean install -DskipTests
* Unit tests pass (1.8.0_232): one consistent failure (hang) -
TestRegionReplicas - and several flakes (see below)
- mvn package
Thanks for being this up Andrew.
I am also +1 for code cleanup. I agree that such efforts must hit the fork
branches of each release line, thus: master, branch-2, branch1.
I’m -0 on taking such commits to release branches. These code lines are
should be relatively static, only receiving bug
Michael Stack created HBASE-23680:
-
Summary: RegionProcedureStore missing cleaning of hfile archive
Key: HBASE-23680
URL: https://issues.apache.org/jira/browse/HBASE-23680
Project: HBase
[
https://issues.apache.org/jira/browse/HBASE-23628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey resolved HBASE-23628.
-
Fix Version/s: 2.3.0
Resolution: Fixed
> Remove Apache Commons Digest Base64
>
[
https://issues.apache.org/jira/browse/HBASE-23628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey reopened HBASE-23628:
-
reopening for backport(s)
> Remove Apache Commons Digest Base64
>
[
https://issues.apache.org/jira/browse/HBASE-23664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk resolved HBASE-23664.
--
Resolution: Fixed
> Upgrade JUnit to 4.13
> -
>
> Key:
the link didn't work for me. here's another:
https://s.apache.org/5yvfi
Generally, I like this as an approach. I really value the clean up work,
but cleanup / bug fixes that don't make it into earlier release lines then
make my job as an RM who does backports more difficult especially when they
this hit some other folks too:
https://issues.apache.org/jira/browse/INFRA-19696
and infra has been fighting with LDAP today, so I'd guess it's a transient
infra issue.
On Fri, Jan 10, 2020 at 2:53 AM Jan Hentschel <
jan.hentsc...@ultratendency.com> wrote:
> I use the gitbox repo for the
Josh Elser created HBASE-23679:
--
Summary: FileSystem instance leaks due to bulk loads with Kerberos
enabled
Key: HBASE-23679
URL: https://issues.apache.org/jira/browse/HBASE-23679
Project: HBase
Andrew Kyle Purtell created HBASE-23678:
---
Summary: Literate builder API for version management in schema
Key: HBASE-23678
URL: https://issues.apache.org/jira/browse/HBASE-23678
Project: HBase
[
https://issues.apache.org/jira/browse/HBASE-23668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-23668.
---
Hadoop Flags: Reviewed
Assignee: Michael Stack
Resolution: Fixed
Merged to
Nick Dimiduk created HBASE-23677:
Summary: region.jsp returns 500/NPE when provided encoded region
name is not online
Key: HBASE-23677
URL: https://issues.apache.org/jira/browse/HBASE-23677
Project:
Michael Stack created HBASE-23676:
-
Summary: Address feedback on HBASE-23055 Alter hbase:meta.
Key: HBASE-23676
URL: https://issues.apache.org/jira/browse/HBASE-23676
Project: HBase
Issue
Peter Somogyi created HBASE-23675:
-
Summary: Move to Apache parent POM version 22
Key: HBASE-23675
URL: https://issues.apache.org/jira/browse/HBASE-23675
Project: HBase
Issue Type:
Please vote on this release candidate (RC) for Apache HBase 2.2.3.
The VOTE will remain open for at least 72 hours.
[ ] +1 Release this package as Apache HBase 2.2.3
[ ] -1 Do not release this package because ...
The tag to be voted on is 2.2.3RC1. The release files, including
signatures,
dingbaosheng created HBASE-23674:
Summary: Too many rit page Numbers show confusion
Key: HBASE-23674
URL: https://issues.apache.org/jira/browse/HBASE-23674
Project: HBase
Issue Type: Bug
[
https://issues.apache.org/jira/browse/HBASE-23658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang resolved HBASE-23658.
Resolution: Fixed
> Fix flaky TestSnapshotFromMaster
>
>
[
https://issues.apache.org/jira/browse/HBASE-23659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang resolved HBASE-23659.
Resolution: Fixed
> BaseLoadBalancer#wouldLowerAvailability should consider region
[
https://issues.apache.org/jira/browse/HBASE-23655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang resolved HBASE-23655.
Resolution: Fixed
> Fix flaky TestRSGroupsKillRS: should wait the SCP to finish
>
I use the gitbox repo for the backports and didn’t had any problems yesterday
pushing to all branch-2.x.
From: Guanghao Zhang
Reply-To: "dev@hbase.apache.org"
Date: Friday, January 10, 2020 at 9:08 AM
To: HBase Dev List
Subject: Failed to push commit to gitbox repo
To
To https://gitbox.apache.org/repos/asf/hbase.git
! [remote rejected] branch-2.2 -> branch-2.2 (pre-receive hook
declined)
I searched this error. The reason may be that the branch was protected. And
branch-2 has same problem. But there are no error when push to github repo.
Any other
27 matches
Mail list logo
