I think Google's style is good enough. But for us, I'm +1 on moving the
imports of hbase-thirdparty, i.e., the shaded ones, to a new block.
2017-10-03 0:30 GMT+08:00 Andrew Purtell :
> I think whatever offers lower overall effort for committers would be the
> better choice.
I think whatever offers lower overall effort for committers would be the
better choice. I don't have any particular concern about ordering.
For what it's worth, I am not a fan of wildcard imports and undo them
wherever I see them. This is just a personal preference though. If we
officially are
Both of google style or own special way are fine to me. :-)
Another issue is how to make people feel the special import ordering is
important? I prefer adding the order check to precommit run.
On 2017-10-02 03:37, Josh Elser wrote:
> Playing devil's advocate:
>
> Do we
Playing devil's advocate:
Do we want to maintain our own "special" way of doing imports instead of
relying on something such as the Google Java style guide? [1]
+1 to the idea of cleaning things up, but just curious if people feel
like our special import ordering is important (and not just
+1 on not using wildcard import .
On Sun, Oct 1, 2017 at 10:24 AM, Peter Somogyi
wrote:
> I like the layout you suggested Chia-Ping and also to check this in the
> precommit run.
> Shall we also add "not to use * imports" to the verification?
>
> On Sun, Oct 1, 2017 at
I like the layout you suggested Chia-Ping and also to check this in the
precommit run.
Shall we also add "not to use * imports" to the verification?
On Sun, Oct 1, 2017 at 9:09 AM, Chia-Ping Tsai wrote:
> bq. I guess you meant attention.
> You are right. sorry for the
bq. I guess you meant attention.
You are right. sorry for the misspelling. â¹
On 2017-10-01 23:33, Ted Yu wrote:
> bq. hold our attraction
>
> I guess you meant attention.
>
> The suggestions under Q1 are good.
>
>
>
> On Sun, Oct 1, 2017 at 8:27 AM, Chia-Ping Tsai
bq. hold our attraction
I guess you meant attention.
The suggestions under Q1 are good.
On Sun, Oct 1, 2017 at 8:27 AM, Chia-Ping Tsai wrote:
> hi folks,
>
> I noticed the code conflict occurs on the imports frequently. To resolve
> the conflict is a complete waste of