[RESULT][VOTE] hbase-thirdparty project, first release candidate 1.0.1RC0

2017-08-28 Thread Stack
Vote passes. 5+1s and zero against. Thanks to all who voted. Let me push this out. St.Ack On Wed, Aug 23, 2017 at 3:46 PM, Stack wrote: > This is a minor update to hbase-thirdparty, our little side project of > relocated popular includes such as guava, protobuf, and netty

Re: [VOTE] hbase-thirdparty project, first release candidate 1.0.1RC0

2017-08-28 Thread Stack
On Mon, Aug 28, 2017 at 4:05 AM, Yu Li wrote: > +1 > > Checked sums and signatures: OK > Build from source: OK, checked both "mvn clean install" and "mvn clean > assembly:single", everything looks perfect > > Minor: > 1. Also noticed the google directory after > decompressing

Re: [VOTE] hbase-thirdparty project, first release candidate 1.0.1RC0

2017-08-28 Thread Stack
Thanks for voting Duo. Filed HBASE-18709 for errant protos. Thanks. St.Ack On Sat, Aug 26, 2017 at 11:43 PM, 张铎(Duo Zhang) wrote: > +1 (binding) > > Checked sums and signatures: OK > 'mvn clean install': OK, the size of the generated jar files and sources > jar files are

Re: [VOTE] hbase-thirdparty project, first release candidate 1.0.1RC0

2017-08-28 Thread Yu Li
+1 Checked sums and signatures: OK Build from source: OK, checked both "mvn clean install" and "mvn clean assembly:single", everything looks perfect Minor: 1. Also noticed the google directory after decompressing hbase-shaded-protobuf jar ball 2. Noticed patches-applied.txt in

Re: [VOTE] hbase-thirdparty project, first release candidate 1.0.1RC0

2017-08-27 Thread Duo Zhang
+1 (binding) Checked sums and signatures: OK 'mvn clean install': OK, the size of the generated jar files and sources jar files are both reasonable Unzip the generated jar files and sources jar files: OK, all classes/sources are relocated under org/apache/hadoop/hbase/shaded. There are some

Re: [VOTE] hbase-thirdparty project, first release candidate 1.0.1RC0

2017-08-26 Thread Stack
Need a few pmc votes here please. Just takes a minute. Thanks in advance. S On Aug 25, 2017 10:37, "Stack" wrote: > On Fri, Aug 25, 2017 at 10:06 AM, Mike Drob wrote: > >> +1 (non-binding) >> >> Signatures and checksums good. >> >> LICENSE question... do

Re: [VOTE] hbase-thirdparty project, first release candidate 1.0.1RC0

2017-08-25 Thread Stack
On Fri, Aug 25, 2017 at 10:06 AM, Mike Drob wrote: > +1 (non-binding) > > Signatures and checksums good. > > LICENSE question... do we actually bundle jquery, asciidoctor, and the orca > logo here? I didn't see them anywhere. > CHANGES is mostly blank... If we don't use it, get

Re: [VOTE] hbase-thirdparty project, first release candidate 1.0.1RC0

2017-08-25 Thread Peter Somogyi
+1 (non-binding) Checksum, signature good. Built hbase pointing to staging repo. I agree with Mike's LICENSE and CHANGES suggestions. Peter On Thu, Aug 24, 2017 at 12:46 AM, Stack wrote: > This is a minor update to hbase-thirdparty, our little side project of > relocated

Re: [VOTE] hbase-thirdparty project, first release candidate 1.0.1RC0

2017-08-25 Thread Mike Drob
+1 (non-binding) Signatures and checksums good. LICENSE question... do we actually bundle jquery, asciidoctor, and the orca logo here? I didn't see them anywhere. CHANGES is mostly blank... If we don't use it, get rid of it in the next version. Verified an hbase compile against this version,

Re: [VOTE] hbase-thirdparty project, first release candidate 1.0.1RC0

2017-08-24 Thread Stack
+1 from me. On Wed, Aug 23, 2017 at 3:46 PM, Stack wrote: > This is a minor update to hbase-thirdparty, our little side project of > relocated popular includes such as guava, protobuf, and netty (See [1] for > more on what hbase-thirdparty is). > > hbase-thirdparty 1.0.1RC0 is

[VOTE] hbase-thirdparty project, first release candidate 1.0.1RC0

2017-08-23 Thread Stack
This is a minor update to hbase-thirdparty, our little side project of relocated popular includes such as guava, protobuf, and netty (See [1] for more on what hbase-thirdparty is). hbase-thirdparty 1.0.1RC0 is available at: https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdparty/1.0.1RC0/