Re: Are we ready to accept PR commit from github?

2019-03-27 Thread Peter Somogyi
Filed INFRA-18121 for the GitHub notifications. On Wed, Mar 27, 2019 at 5:27 PM Nick Dimiduk wrote: > Can we have the gitbox message-per-github-action pipped to commits@ > instead > of dev@ ? > > On Tue, Mar 26, 2019 at 6:15 AM Josh Elser wrote: > > > Yep, the trigger to call Jenkins from

Re: Are we ready to accept PR commit from github?

2019-03-27 Thread Nick Dimiduk
Can we have the gitbox message-per-github-action pipped to commits@ instead of dev@ ? On Tue, Mar 26, 2019 at 6:15 AM Josh Elser wrote: > Yep, the trigger to call Jenkins from Github PR's is something Infra > controls. All I know is that I sent an email to us...@infra.apache.org > explaining

Re: Are we ready to accept PR commit from github?

2019-03-26 Thread Josh Elser
Yep, the trigger to call Jenkins from Github PR's is something Infra controls. All I know is that I sent an email to us...@infra.apache.org explaining what I was trying to do, and an Infra team member said they "enabled two options" for me and then everything worked. Hopefully, if you just

Re: Are we ready to accept PR commit from github?

2019-03-25 Thread OpenInx
I see the guide in https://cwiki.apache.org/confluence/display/INFRA/GitHub+Pull+Request+Builder, I think we need create some webhook in our apache/hbase github repository. Oh, maybe I can have a try in my own forked github repo, if work, then I can put it in apache/hbase repo. On Tue, Mar 26,

Re: Are we ready to accept PR commit from github?

2019-03-25 Thread Sean Busbey
Access to Jenkins is granted by the PMC chair. When I'm back at a laptop tomorrow I can post the guide for access. You shouldn't need access to the setting of the GitHub repos to do this; I'm not even sure what gitbox integration gives us. I'll confirm by checking how the two projects I know to

Re: Are we ready to accept PR commit from github?

2019-03-25 Thread OpenInx
@stack boss, Can you see the settings also the jenkins config ? If so, mind you grant those permissions? On Tue, Mar 26, 2019 at 10:17 AM 张铎(Duo Zhang) wrote: > I can not see the settings tab on github either... > > OpenInx 于2019年3月26日周二 上午10:11写道: > >> So the current problem is: github PR

Re: Are we ready to accept PR commit from github?

2019-03-25 Thread Duo Zhang
I can not see the settings tab on github either... OpenInx 于2019年3月26日周二 上午10:11写道: > So the current problem is: github PR can not trigger hadoop QA ? I will > take some time to let this work, but > seems I've no setting permissions in github repo, also no permission to > view the jenkins

Re: Are we ready to accept PR commit from github?

2019-03-25 Thread OpenInx
So the current problem is: github PR can not trigger hadoop QA ? I will take some time to let this work, but seems I've no setting permissions in github repo, also no permission to view the jenkins config. @Sean Busby, @Josh Elser @张铎(Duo Zhang) Could you help to grant those permission to me

Re: Are we ready to accept PR commit from github?

2019-03-15 Thread Sean Busbey
I suspect this blog post on getting Yetus checks against GitHub PRs working will be more directly applicable: https://effectivemachines.com/2019/01/24/using-apache-yetus-with-jenkins-and-github-part-1/ Of course, the examples Peter has gotten working on hbase-connectors and hbase-operator-tools

Re: Are we ready to accept PR commit from github?

2019-03-15 Thread Josh Elser
Of course, found them right after I sent this :) https://lists.apache.org/thread.html/c441a64c28547ca405b65ad97a7dc78601d33149eb8fcc64aee88eeb@%3Cbuilds.apache.org%3E https://lists.apache.org/thread.html/a21448239fe5dab8a486df72f032d84aade7425d1dac625b0410b63c@%3Cbuilds.apache.org%3E ChrisT

Re: Are we ready to accept PR commit from github?

2019-03-15 Thread Josh Elser
I went through this exercise recently, trying to get it set up for Ratis: The result is at https://builds.apache.org/job/PreCommit-RATIS-github-pull-requests/ Infra has docs up at https://cwiki.apache.org/confluence/display/INFRA/GitHub+Pull+Request+Builder. I remember them not being 100%

Re: Are we ready to accept PR commit from github?

2019-03-14 Thread Yu Li
I'm afraid not for driving this but yes to offer a hand (smile). Is there already some planned steps ongoing? Infra setup is something I'm not familiar but required for pre-commit and daily check on Travis, other than that just count me in and let me know what I could do to help. Best Regards,

Re: Are we ready to accept PR commit from github?

2019-03-14 Thread Duo Zhang
I think PR will be good. Do you have any cycle to drive this Yu Li? Thanks. Yu Li 于2019年3月14日周四 下午8:53写道: > I see, thanks for the quick response Peter. > > Best Regards, > Yu > > > On Thu, 14 Mar 2019 at 17:38, Peter Somogyi wrote: > > > For hbase repository we do not yet have the integration

Re: Are we ready to accept PR commit from github?

2019-03-14 Thread Yu Li
I see, thanks for the quick response Peter. Best Regards, Yu On Thu, 14 Mar 2019 at 17:38, Peter Somogyi wrote: > For hbase repository we do not yet have the integration to accept pull > requests but hbase-connectors and hbase-operator-tools repositories moved > to GitHub PR workflow instead

Re: Are we ready to accept PR commit from github?

2019-03-14 Thread Peter Somogyi
For hbase repository we do not yet have the integration to accept pull requests but hbase-connectors and hbase-operator-tools repositories moved to GitHub PR workflow instead of accepting patch files. Peter On Thu, Mar 14, 2019 at 9:42 AM Yu Li wrote: > Hi All, > > Please forgive me if this is

Are we ready to accept PR commit from github?

2019-03-14 Thread Yu Li
Hi All, Please forgive me if this is already clearly clarified in other mail threads, but last time when I saw discussion about this we were still lacking some INFRA support to accept PR from github, so I'd like to double check here. Many thanks. Best Regards, Yu