[jira] [Commented] (HTTPCLIENT-293) Provide support for non-ASCII charsets in the multipart disposition-content header

2017-09-28 Thread Ioannis Sermetziadis (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184919#comment-16184919 ] Ioannis Sermetziadis commented on HTTPCLIENT-293: - I submitted a PR that includes an

[jira] [Commented] (HTTPCLIENT-293) Provide support for non-ASCII charsets in the multipart disposition-content header

2017-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184912#comment-16184912 ] ASF GitHub Bot commented on HTTPCLIENT-293: --- GitHub user sermojohn opened a pull request:

[GitHub] httpcomponents-client pull request #85: HTTPCLIENT-293 Fix proposal based on...

2017-09-28 Thread sermojohn
GitHub user sermojohn opened a pull request: https://github.com/apache/httpcomponents-client/pull/85 HTTPCLIENT-293 Fix proposal based on RFC 7578 I implemented the fix in two commits, because I believe that some refactoring was required in order to handle the part header field

Re: Releasing HttpCore 4.4.8

2017-09-28 Thread Oleg Kalnichevski
On Thu, 2017-09-28 at 15:20 -0600, Gary Gregory wrote: > ... > > Which gave me: > > Unexpected version: 4.4.8-SNAPSHOT > > How do I clean up this "4.4.7-RC1-15-g774d9b1" ? > 1. Please pull the latest code. I made 3 commits out of previous 8. 2. Remove you local RC tag git tag -d

Re: Releasing HttpCore 4.4.8

2017-09-28 Thread Gary Gregory
On Thu, Sep 28, 2017 at 3:20 PM, Gary Gregory wrote: > > > On Thu, Sep 28, 2017 at 3:19 PM, Gary Gregory > wrote: > >> >> >> On Thu, Sep 28, 2017 at 3:18 PM, Oleg Kalnichevski >> wrote: >> >>> On Thu, 2017-09-28 at 15:16 -0600,

Re: Releasing HttpCore 4.4.8

2017-09-28 Thread Gary Gregory
On Thu, Sep 28, 2017 at 3:19 PM, Gary Gregory wrote: > > > On Thu, Sep 28, 2017 at 3:18 PM, Oleg Kalnichevski > wrote: > >> On Thu, 2017-09-28 at 15:16 -0600, Gary Gregory wrote: >> > On Thu, Sep 28, 2017 at 3:14 PM, Oleg Kalnichevski

Re: Releasing HttpCore 4.4.8

2017-09-28 Thread Gary Gregory
On Thu, Sep 28, 2017 at 3:18 PM, Oleg Kalnichevski wrote: > On Thu, 2017-09-28 at 15:16 -0600, Gary Gregory wrote: > > On Thu, Sep 28, 2017 at 3:14 PM, Oleg Kalnichevski > > wrote: > > > > > On Thu, 2017-09-28 at 15:07 -0600, Gary Gregory wrote: > > > > On

Re: Releasing HttpCore 4.4.8

2017-09-28 Thread Oleg Kalnichevski
On Thu, 2017-09-28 at 15:16 -0600, Gary Gregory wrote: > On Thu, Sep 28, 2017 at 3:14 PM, Oleg Kalnichevski > wrote: > > > On Thu, 2017-09-28 at 15:07 -0600, Gary Gregory wrote: > > > On Thu, Sep 28, 2017 at 3:05 PM, Oleg Kalnichevski > > org> > > > wrote: > >

Re: Releasing HttpCore 4.4.8

2017-09-28 Thread Gary Gregory
On Thu, Sep 28, 2017 at 3:14 PM, Oleg Kalnichevski wrote: > On Thu, 2017-09-28 at 15:07 -0600, Gary Gregory wrote: > > On Thu, Sep 28, 2017 at 3:05 PM, Oleg Kalnichevski > > wrote: > > > > > On Thu, 2017-09-28 at 14:54 -0600, Gary Gregory wrote: > > > > I

Re: Releasing HttpCore 4.4.8

2017-09-28 Thread Oleg Kalnichevski
On Thu, 2017-09-28 at 15:07 -0600, Gary Gregory wrote: > On Thu, Sep 28, 2017 at 3:05 PM, Oleg Kalnichevski > wrote: > > > On Thu, 2017-09-28 at 14:54 -0600, Gary Gregory wrote: > > > I just ran: > > > > > > gradlew -q -b release.gradle releaseDetails > > > > > > and got: > >

Re: Releasing HttpCore 4.4.8

2017-09-28 Thread Gary Gregory
On Thu, Sep 28, 2017 at 3:05 PM, Oleg Kalnichevski wrote: > On Thu, 2017-09-28 at 14:54 -0600, Gary Gregory wrote: > > I just ran: > > > > gradlew -q -b release.gradle releaseDetails > > > > and got: > > > > Project directory C:\vcs\git\apache\httpcomponents\httpcomponents- > >

Re: Releasing HttpCore 4.4.8

2017-09-28 Thread Oleg Kalnichevski
On Thu, 2017-09-28 at 14:54 -0600, Gary Gregory wrote: > I just ran: > > gradlew -q -b release.gradle releaseDetails > > and got: > > Project directory C:\vcs\git\apache\httpcomponents\httpcomponents- > core-4.4.x > Git branch 4.4.x > Release tag *4.4.7-RC1*-15-g774d9b1 > > Apache

Re: Build failed in Jenkins: httpcomponents-core-4.4.x #211

2017-09-28 Thread Gary Gregory
On Thu, Sep 28, 2017 at 2:55 PM, Oleg Kalnichevski wrote: > On Thu, 2017-09-28 at 20:48 +, Apache Jenkins Server wrote: > > > > ... > > > > [INFO] -- > > -- > > [INFO] Building Apache HttpCore NIO

Re: Build failed in Jenkins: httpcomponents-core-4.4.x #211

2017-09-28 Thread Oleg Kalnichevski
On Thu, 2017-09-28 at 20:48 +, Apache Jenkins Server wrote: > ... > [INFO] -- > -- > [INFO] Building Apache HttpCore NIO 4.4.8-SNAPSHOT > [INFO] -- > -- >

Re: Releasing HttpCore 4.4.8

2017-09-28 Thread Gary Gregory
I just ran: gradlew -q -b release.gradle releaseDetails and got: Project directory C:\vcs\git\apache\httpcomponents\httpcomponents-core-4.4.x Git branch 4.4.x Release tag *4.4.7-RC1*-15-g774d9b1 Apache HttpComponents Core 4.4.8-SNAPSHOT - module httpcore - module httpcore-nio - module

Re: Releasing HttpCore 4.4.8

2017-09-28 Thread Oleg Kalnichevski
On Thu, 2017-09-28 at 22:19 +0200, Philippe Mouawad wrote: > Hi Gary, > As you're doing the job, I have nothing to say. > But IMHO, this is maybe too early. > There is no harm in releasing often as long as we have a release manager willing to do the job. Cheers Oleg > Regards > Philippe > >

Re: Releasing HttpCore 4.4.8

2017-09-28 Thread Gary Gregory
On Thu, Sep 28, 2017 at 2:19 PM, Philippe Mouawad < philippe.moua...@gmail.com> wrote: > Hi Gary, > As you're doing the job, I have nothing to say. > But IMHO, this is maybe too early. > Hi, By what metric? I'd rather ship a product with a release than a SNAPSHOT. If I can get git and gpg to

Re: Releasing HttpCore 4.4.8

2017-09-28 Thread Philippe Mouawad
Hi Gary, As you're doing the job, I have nothing to say. But IMHO, this is maybe too early. Regards Philippe On Thu, Sep 28, 2017 at 10:08 PM, Gary Gregory wrote: > On Thu, Sep 28, 2017 at 2:03 PM, Philippe Mouawad < > philippe.moua...@gmail.com> wrote: > > > Hello

Re: Releasing HttpCore 4.4.8

2017-09-28 Thread Gary Gregory
On Thu, Sep 28, 2017 at 2:03 PM, Philippe Mouawad < philippe.moua...@gmail.com> wrote: > Hello Gary, > Isn't it too early to release a 4.4.8 ? > > What are the new features compared to 4.4.7 ? > This is the current change log: Changelog --- * HTTPCORE-492: Make

Re: Releasing HttpCore 4.4.8

2017-09-28 Thread Philippe Mouawad
Hello Gary, Isn't it too early to release a 4.4.8 ? What are the new features compared to 4.4.7 ? Thanks On Thu, Sep 28, 2017 at 10:00 PM, Gary Gregory wrote: > Hi All: > > I'd like to try my hand at releasing HttpCore 4.4.8 to pick up changes I > need at work. > >

Releasing HttpCore 4.4.8

2017-09-28 Thread Gary Gregory
Hi All: I'd like to try my hand at releasing HttpCore 4.4.8 to pick up changes I need at work. I'll follow https://github.com/ok2c/httpcomponents-release-tools/wiki and see what happens... Unless someone objects of course... Gary

[jira] [Commented] (HTTPCORE-490) concurrent bug when invoke future.cancel

2017-09-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184685#comment-16184685 ] ASF subversion and git services commented on HTTPCORE-490: -- Commit

[jira] [Commented] (HTTPCORE-491) BasicAsyncResponseConsumer can easily be tricked into triggering an OOME

2017-09-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184684#comment-16184684 ] ASF subversion and git services commented on HTTPCORE-491: -- Commit

[jira] [Commented] (HTTPCORE-493) Make org.apache.http.nio.protocol.HttpAsyncService.responseFactory available to subclasses

2017-09-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184680#comment-16184680 ] ASF subversion and git services commented on HTTPCORE-493: -- Commit

[jira] [Commented] (HTTPCORE-492) Make org.apache.http.nio.protocol.ErrorResponseProducer public

2017-09-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184679#comment-16184679 ] ASF subversion and git services commented on HTTPCORE-492: -- Commit

[jira] [Closed] (HTTPCORE-493) Make org.apache.http.nio.protocol.HttpAsyncService.responseFactory available to subclasses

2017-09-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed HTTPCORE-493. - Resolution: Fixed In the git branch for 4.4.x. > Make

[jira] [Created] (HTTPCORE-493) Make org.apache.http.nio.protocol.HttpAsyncService.responseFactory available to subclasses

2017-09-28 Thread Gary Gregory (JIRA)
Gary Gregory created HTTPCORE-493: - Summary: Make org.apache.http.nio.protocol.HttpAsyncService.responseFactory available to subclasses Key: HTTPCORE-493 URL: https://issues.apache.org/jira/browse/HTTPCORE-493

[jira] [Closed] (HTTPCORE-492) Make org.apache.http.nio.protocol.ErrorResponseProducer public

2017-09-28 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed HTTPCORE-492. - Resolution: Fixed In the git branch for 4.4.x. > Make

[jira] [Created] (HTTPCORE-492) Make org.apache.http.nio.protocol.ErrorResponseProducer public

2017-09-28 Thread Gary Gregory (JIRA)
Gary Gregory created HTTPCORE-492: - Summary: Make org.apache.http.nio.protocol.ErrorResponseProducer public Key: HTTPCORE-492 URL: https://issues.apache.org/jira/browse/HTTPCORE-492 Project:

Re: Make org.apache.http.nio.protocol.ErrorResponseProducer public?

2017-09-28 Thread Gary Gregory
Done. Gary. On Thu, Sep 28, 2017 at 4:15 AM, Oleg Kalnichevski wrote: > On Wed, 2017-09-27 at 15:09 -0600, Gary Gregory wrote: > > Hi All, > > > > I've needed org.apache.http.nio.protocol.ErrorResponseProducer a few > > times > > for my custom reverse proxy, so I ended up

Re: Make org.apache.http.nio.protocol.ErrorResponseProducer public?

2017-09-28 Thread Oleg Kalnichevski
On Wed, 2017-09-27 at 15:09 -0600, Gary Gregory wrote: > Hi All, > > I've needed org.apache.http.nio.protocol.ErrorResponseProducer a few > times > for my custom reverse proxy, so I ended up cloning it in my code > base. > > Any objection to making it public? > > Gayr Works for me. Oleg

[jira] [Commented] (HTTPCLIENT-1872) Add HttpOnly boolean to Cookie, ClientCookie etc.

2017-09-28 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183956#comment-16183956 ] Oleg Kalnichevski commented on HTTPCLIENT-1872: --- bq. Is there a timeline of when 5.0