[jira] [Commented] (HTTPCORE-499) Make interface Header extend NameValuePair

2017-12-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288573#comment-16288573 ] ASF subversion and git services commented on HTTPCORE-499: -- Commit

[jira] [Commented] (HTTPCORE-499) Make interface Header extend NameValuePair

2017-12-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288490#comment-16288490 ] ASF subversion and git services commented on HTTPCORE-499: -- Commit

Return values org.apache.http.client.utils.URLEncodedUtils.parse(URI, Charset)

2017-12-12 Thread Gary Gregory
Hi All: org.apache.http.client.utils.URLEncodedUtils.parse(URI, Charset) returns an immutable list if there are no params and a mutable list if there are params. This is trouble since all I want to do is add some params for a URI with the same code. How about making this API return a NEW

[jira] [Updated] (HTTPCORE-499) Make interface Header extend NameValuePair

2017-12-12 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated HTTPCORE-499: -- Description: Make the interface {{org.apache.hc.core5.http.Header}} extend

[jira] [Created] (HTTPCORE-499) Make interface Header extend NameValuePair

2017-12-12 Thread Gary Gregory (JIRA)
Gary Gregory created HTTPCORE-499: - Summary: Make interface Header extend NameValuePair Key: HTTPCORE-499 URL: https://issues.apache.org/jira/browse/HTTPCORE-499 Project: HttpComponents HttpCore

Re: BasicRequestLine with hashCode() and equals()

2017-12-12 Thread Oleg Kalnichevski
On Tue, 2017-12-12 at 06:54 -0700, Gary Gregory wrote: > My use case is not a map but rewriting a request in a proxy where > anything > can be tweaked by users. If the request line I built is different at > all > from the original, then there are a few extra things I need to do. > Using > equals

Re: BasicRequestLine with hashCode() and equals()

2017-12-12 Thread Gary Gregory
My use case is not a map but rewriting a request in a proxy where anything can be tweaked by users. If the request line I built is different at all from the original, then there are a few extra things I need to do. Using equals instead of testing all parts is simpler. Gary On Dec 12, 2017 02:01,

Re: BasicRequestLine with hashCode() and equals()

2017-12-12 Thread Oleg Kalnichevski
On Tue, 2017-12-12 at 00:01 -0700, Gary Gregory wrote: > Hi All: > > I'd like to have BasicRequestLine implement equals() (and > hashCode()). > > Anyone against that? > > Gary What would be the criteria of equality? Why would one ever want to stick BasicRequestLine instances into a map? Oleg

Re: Header vs. NameValuePair

2017-12-12 Thread Oleg Kalnichevski
On Mon, 2017-12-11 at 15:03 -0700, Gary Gregory wrote: > Hi All: > > I am looking to process HTTP headers and query parameters uniformly > but I > cannot ATM since our interfaces Header and NameValuePair are > unrelated even > though they both provide access to a name and a value. > > How about