[jira] [Commented] (HTTPCLIENT-1244) convert unit tests for cache module to use Mockito

2021-06-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366008#comment-17366008 ] ASF subversion and git services commented on HTTPCLIENT-1244: - Commit

Re: New race condition confirmed

2021-06-19 Thread Oleg Kalnichevski
I will look into it and come up with a fix. Oleg On 6/19/2021 7:33 PM, Ryan Schmitt wrote: I'm not sure what the proper fix would be, since I don't currently understand the CancellableDependency logic. I did find that deleting the `throw` statement at InternalExecRuntime.java:109 allows the

Re: New race condition confirmed

2021-06-19 Thread Ryan Schmitt
I'm not sure what the proper fix would be, since I don't currently understand the CancellableDependency logic. I did find that deleting the `throw` statement at InternalExecRuntime.java:109 allows the pool entry to be cleaned up if it is already allocated, without any other apparent regressions or

[jira] [Commented] (HTTPCLIENT-1244) convert unit tests for cache module to use Mockito

2021-06-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365925#comment-17365925 ] ASF subversion and git services commented on HTTPCLIENT-1244: - Commit

[jira] [Commented] (HTTPCLIENT-1244) convert unit tests for cache module to use Mockito

2021-06-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365922#comment-17365922 ] ASF subversion and git services commented on HTTPCLIENT-1244: - Commit

Re: New race condition confirmed

2021-06-19 Thread Oleg Kalnichevski
Hi Ryan Do you want to look into it or do you have a fix in mind? Olegg On 6/19/2021 12:49 AM, Ryan Schmitt wrote: I've finally found the race condition I've been looking for. Here's the reproducer: https://github.com/rschmitt/httpclient-benchmark/commit/master

[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #293: Fix data race in StrictConnPool

2021-06-19 Thread GitBox
ok2c commented on a change in pull request #293: URL: https://github.com/apache/httpcomponents-core/pull/293#discussion_r654782487 ## File path: httpcore5/src/main/java/org/apache/hc/core5/pool/StrictConnPool.java ## @@ -699,14 +699,18 @@ public boolean isDone() { }