Re: JUnit 5 upgrade rant (contains obscene language)

2022-10-23 Thread Ryan Schmitt
If you'd like, I could run `git-bisect` to figure out where the tests broke; I'll just need to know which tests broke and how to run them. On Sat, Oct 22, 2022 at 8:14 AM Oleg Kalnichevski wrote: > The JUnit 5 upgrade was a cluster. > > The original contributor ported some of the easy test

Re: JUnit 5 upgrade rant (contains obscene language)

2022-10-23 Thread Ryan Schmitt
assertThrows is available in JUnit 4.13. On Sun, Oct 23, 2022 at 4:11 AM Gary Gregory wrote: > Version 5 has some drawbacks but on the positive side, APIs like > assertThrows are very useful. > > Gary > > On Sun, Oct 23, 2022, 04:31 Michael Osipov wrote: > > > Am 2022-10-22 um 17:14 schrieb

[jira] [Commented] (HTTPCLIENT-2241) HttpResponseInterceptor is never called on errors

2022-10-23 Thread Patrick Barry (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622875#comment-17622875 ] Patrick Barry commented on HTTPCLIENT-2241: --- Upon further research, I found hitting a

[jira] [Resolved] (HTTPCLIENT-2240) ProxyClient always throws ProtocolException

2022-10-23 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-2240. --- Fix Version/s: 5.1.4 5.2-beta2 Resolution:

[jira] [Commented] (HTTPCLIENT-2240) ProxyClient always throws ProtocolException

2022-10-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622853#comment-17622853 ] ASF subversion and git services commented on HTTPCLIENT-2240: - Commit

[jira] [Commented] (HTTPCLIENT-2240) ProxyClient always throws ProtocolException

2022-10-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622851#comment-17622851 ] ASF subversion and git services commented on HTTPCLIENT-2240: - Commit

Re: JUnit 5 upgrade rant (contains obscene language)

2022-10-23 Thread Gary Gregory
Version 5 has some drawbacks but on the positive side, APIs like assertThrows are very useful. Gary On Sun, Oct 23, 2022, 04:31 Michael Osipov wrote: > Am 2022-10-22 um 17:14 schrieb Oleg Kalnichevski: > > The JUnit 5 upgrade was a cluster. > > > > The original contributor ported some of the

[jira] [Commented] (HTTPCLIENT-2241) HttpResponseInterceptor is never called on errors

2022-10-23 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622778#comment-17622778 ] Oleg Kalnichevski commented on HTTPCLIENT-2241: --- [~patrickjamesbarry] I am not sure I

Re: JUnit 5 upgrade rant (contains obscene language)

2022-10-23 Thread Michael Osipov
Am 2022-10-22 um 17:14 schrieb Oleg Kalnichevski: The JUnit 5 upgrade was a cluster. The original contributor ported some of the easy test cases that did not have a complex resource setup and left most complex and most important protocol and integration tests still partially using JUnit 4