[jira] [Resolved] (HTTPCLIENT-2255) NoHttpResponseException when using BasicHttpClientConnectionManager

2023-01-04 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-2255. --- Resolution: Information Provided > NoHttpResponseException when using Ba

[jira] [Commented] (HTTPCLIENT-2255) NoHttpResponseException when using BasicHttpClientConnectionManager

2023-01-04 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654502#comment-17654502 ] Oleg Kalnichevski commented on HTTPCLIENT-2255: --- [~andreyz] I ran the

[GitHub] [httpcomponents-client] ok2c merged pull request #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method

2023-01-04 Thread GitBox
ok2c merged PR #404: URL: https://github.com/apache/httpcomponents-client/pull/404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

[GitHub] [httpcomponents-client] ok2c commented on pull request #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method

2023-01-04 Thread GitBox
ok2c commented on PR #404: URL: https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370987346 @alturkovic Please add `@SuppressWarnings("deprecation")` annotation to the new method. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [httpcomponents-client] alturkovic commented on pull request #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method

2023-01-04 Thread GitBox
alturkovic commented on PR #404: URL: https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370980479 Sorry, I do not know what you mean by that, I took a look how other methods are deprecated (i.e.: `org.apache.hc.client5.http.ssl.ClientTlsStrategyBuilder#setTlsDetailsFac

[GitHub] [httpcomponents-client] ok2c commented on pull request #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method

2023-01-04 Thread GitBox
ok2c commented on PR #404: URL: https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370975027 @alturkovic Great. But please do it nicely and suppress deprecation warnings in the new method. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [httpcomponents-client] ok2c commented on pull request #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method

2023-01-04 Thread GitBox
ok2c commented on PR #404: URL: https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370961882 @alturkovic Please deprecate the old method in favor of the new one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [httpcomponents-client] alturkovic commented on pull request #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method

2023-01-04 Thread GitBox
alturkovic commented on PR #404: URL: https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370959011 @ok2c Oops, added the method back. I understand, I just thought that having `HttpContext` available by default made sense. -- This is an automated message from the Apach

[GitHub] [httpcomponents-client] ok2c commented on pull request #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method

2023-01-04 Thread GitBox
ok2c commented on PR #404: URL: https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370957675 @alturkovic The change-set breaks backward compatibility with 5.0 APIs. By the way, one may be better off writing a custom `SSLConnectionSocketFactory` instead of trying

[GitHub] [httpcomponents-client] alturkovic opened a new pull request, #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method

2023-01-04 Thread GitBox
alturkovic opened a new pull request, #404: URL: https://github.com/apache/httpcomponents-client/pull/404 Some implementations might depend on a variable present in the `HttpContext` which is available in most other methods. -- This is an automated message from the Apache Git Service. To