[GitHub] [httpcomponents-core] arturobernalg commented on a diff in pull request #424: HTTPCORE-756 - Implement RFC9110 Content-Type Validation for OPTIONS Requests

arturobernalg commented on code in PR #424: URL: https://github.com/apache/httpcomponents-core/pull/424#discussion_r1312058180 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java: ## @@ -127,4 +133,32 @@ public void process(final HttpRequest

[GitHub] [httpcomponents-core] arturobernalg closed pull request #425: HTTPCORE-756 - Enhance HTTP header handling and deprecate legacy features

arturobernalg closed pull request #425: HTTPCORE-756 - Enhance HTTP header handling and deprecate legacy features URL: https://github.com/apache/httpcomponents-core/pull/425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [httpcomponents-core] arturobernalg commented on pull request #425: HTTPCORE-756 - Enhance HTTP header handling and deprecate legacy features

arturobernalg commented on PR #425: URL: https://github.com/apache/httpcomponents-core/pull/425#issuecomment-1701556124 OK. I din´t see that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [httpcomponents-core] arturobernalg commented on a diff in pull request #423: HTTPCORE-756 - Enforced the requirement that "https" URIs must not have an empty host identifier

arturobernalg commented on code in PR #423: URL: https://github.com/apache/httpcomponents-core/pull/423#discussion_r1311941788 ## httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java: ## @@ -313,11 +314,14 @@ public URI build() throws URISyntaxException {

[jira] [Commented] (HTTPCORE-756) HttpCore HTTP Semantics conformance to RFC 9110

[ https://issues.apache.org/jira/browse/HTTPCORE-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761042#comment-17761042 ] ASF subversion and git services commented on HTTPCORE-756: -- Commit

[GitHub] [httpcomponents-core] arturobernalg merged pull request #418: HTTPCORE-756 - Deprecation of userInfo in Compliance with RFC 9110

arturobernalg merged PR #418: URL: https://github.com/apache/httpcomponents-core/pull/418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [httpcomponents-core] arturobernalg commented on a diff in pull request #424: HTTPCORE-756 - Implement RFC9110 Content-Type Validation for OPTIONS Requests

arturobernalg commented on code in PR #424: URL: https://github.com/apache/httpcomponents-core/pull/424#discussion_r1311925115 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java: ## @@ -127,4 +133,32 @@ public void process(final HttpRequest

[jira] [Commented] (HTTPCLIENT-2292) SOCKS proxy configuration is not working

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760991#comment-17760991 ] Oleg Kalnichevski commented on HTTPCLIENT-2292: --- [~vkuzel] Please review / test the

[jira] [Commented] (HTTPCLIENT-2292) SOCKS proxy configuration is not working

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760990#comment-17760990 ] ASF subversion and git services commented on HTTPCLIENT-2292: - Commit

[jira] [Commented] (HTTPCLIENT-2291) RetryStrategy: AsyncExecChainHandler and ExecChainHandler behavior should be identical

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760988#comment-17760988 ] ASF subversion and git services commented on HTTPCLIENT-2291: - Commit

[jira] [Commented] (HTTPCLIENT-2284) BasicHttpCacheStorage leaking variant keys in root response's variantMap

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760987#comment-17760987 ] ASF subversion and git services commented on HTTPCLIENT-2284: - Commit

[jira] [Commented] (HTTPCLIENT-2292) SOCKS proxy configuration is not working

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760986#comment-17760986 ] ASF subversion and git services commented on HTTPCLIENT-2292: - Commit

[GitHub] [httpcomponents-client] ok2c merged pull request #480: Document exec chain behaviour when automatic retries are enabled.

ok2c merged PR #480: URL: https://github.com/apache/httpcomponents-client/pull/480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [httpcomponents-client] ok2c commented on pull request #480: Document exec chain behaviour when automatic retries are enabled.

ok2c commented on PR #480: URL: https://github.com/apache/httpcomponents-client/pull/480#issuecomment-1701102844 > I think I would at least document the name (ChainElement#RETRY) in order to place the interceptors relative to it. WDYT? Makes perfect sense. -- This is an automated

[GitHub] [httpcomponents-client] cachescrubber commented on pull request #480: Document exec chain behaviour when automatic retries are enabled.

cachescrubber commented on PR #480: URL: https://github.com/apache/httpcomponents-client/pull/480#issuecomment-1701081868 @ok2c I removed the snippets. Having implemented a handler myself I remember having to dig in the source of clientBuilder in order to find the name of the retry

[GitHub] [httpcomponents-client] ok2c commented on pull request #480: Document exec chain behaviour when automatic retries are enabled.

ok2c commented on PR #480: URL: https://github.com/apache/httpcomponents-client/pull/480#issuecomment-1701014744 @cachescrubber Awesome! One thing, though. Do you mind dropping code snippets out of Javadocs, as code examples often tend to get out of sync with the actual API usage. --

[GitHub] [httpcomponents-client] cachescrubber opened a new pull request, #480: Document exec chain behaviour when automatic retries are enabled.

cachescrubber opened a new pull request, #480: URL: https://github.com/apache/httpcomponents-client/pull/480 Document classic and async exec chain behaviour when automatic retries are enabled. https://issues.apache.org/jira/browse/HTTPCLIENT-2291 -- This is an automated message

[jira] [Resolved] (HTTPCLIENT-2295) Link HttpComponents Core javadoc from Client javadoc

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-2295. --- Fix Version/s: 5.2.2 5.3-alpha2 Resolution:

[jira] [Commented] (HTTPCLIENT-2295) Link HttpComponents Core javadoc from Client javadoc

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760861#comment-17760861 ] ASF subversion and git services commented on HTTPCLIENT-2295: - Commit

[jira] [Commented] (HTTPCLIENT-2295) Link HttpComponents Core javadoc from Client javadoc

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760860#comment-17760860 ] ASF subversion and git services commented on HTTPCLIENT-2295: - Commit

[GitHub] [httpcomponents-client] kwin commented on a diff in pull request #479: HTTPCLIENT-2295 Fix links to Core Javadoc

kwin commented on code in PR #479: URL: https://github.com/apache/httpcomponents-client/pull/479#discussion_r1311450127 ## pom.xml: ## @@ -227,8 +227,8 @@ maven-javadoc-plugin -

[GitHub] [httpcomponents-client] ok2c merged pull request #479: HTTPCLIENT-2295 Fix links to Core Javadoc

ok2c merged PR #479: URL: https://github.com/apache/httpcomponents-client/pull/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #479: HTTPCLIENT-2295 Fix links to Core Javadoc

ok2c commented on code in PR #479: URL: https://github.com/apache/httpcomponents-client/pull/479#discussion_r1311449084 ## pom.xml: ## @@ -227,8 +227,8 @@ maven-javadoc-plugin -

[jira] [Updated] (HTTPCLIENT-2296) Provide GitHub source links per component

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated HTTPCLIENT-2296: Description: Currently in https://hc.apache.org/get-involved.html only two

[jira] [Created] (HTTPCLIENT-2296) Provide GitHub source links per component

Konrad Windszus created HTTPCLIENT-2296: --- Summary: Provide GitHub source links per component Key: HTTPCLIENT-2296 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2296 Project:

[GitHub] [httpcomponents-client] kwin commented on a diff in pull request #479: HTTPCLIENT-2295 Fix links to Core Javadoc

kwin commented on code in PR #479: URL: https://github.com/apache/httpcomponents-client/pull/479#discussion_r1311425123 ## pom.xml: ## @@ -227,8 +227,8 @@ maven-javadoc-plugin -

[GitHub] [httpcomponents-client] kwin opened a new pull request, #479: HTTPCLIENT-2295 Fix links to Core Javadoc

kwin opened a new pull request, #479: URL: https://github.com/apache/httpcomponents-client/pull/479 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (HTTPCLIENT-2295) Link HttpComponents Core javadoc from Client javadoc

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760838#comment-17760838 ] Konrad Windszus commented on HTTPCLIENT-2295: - Seems that the links maintained in

[jira] [Created] (HTTPCLIENT-2295) Link HttpComponents Core javadoc from Client javadoc

Konrad Windszus created HTTPCLIENT-2295: --- Summary: Link HttpComponents Core javadoc from Client javadoc Key: HTTPCLIENT-2295 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2295 Project:

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #425: HTTPCORE-756 - Enhance HTTP header handling and deprecate legacy features

ok2c commented on code in PR #425: URL: https://github.com/apache/httpcomponents-core/pull/425#discussion_r1311380711 ## httpcore5/src/main/java/org/apache/hc/core5/http/message/MessageSupport.java: ## @@ -151,6 +152,11 @@ public static void addContentEncodingHeader(final

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #425: HTTPCORE-756 - Enhance HTTP header handling and deprecate legacy features

ok2c commented on code in PR #425: URL: https://github.com/apache/httpcomponents-core/pull/425#discussion_r1311380711 ## httpcore5/src/main/java/org/apache/hc/core5/http/message/MessageSupport.java: ## @@ -151,6 +152,11 @@ public static void addContentEncodingHeader(final

[jira] [Comment Edited] (HTTPCLIENT-2291) RetryStrategy: AsyncExecChainHandler and ExecChainHandler behavior should be identical

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760819#comment-17760819 ] Oleg Kalnichevski edited comment on HTTPCLIENT-2291 at 8/31/23 9:30 AM:

[jira] [Commented] (HTTPCLIENT-2291) RetryStrategy: AsyncExecChainHandler and ExecChainHandler behavior should be identical

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760819#comment-17760819 ] Oleg Kalnichevski commented on HTTPCLIENT-2291: --- [~cachescrubber] We are not working a

[jira] [Commented] (HTTPCLIENT-2291) RetryStrategy: AsyncExecChainHandler and ExecChainHandler behavior should be identical

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760818#comment-17760818 ] Lars Uffmann commented on HTTPCLIENT-2291: -- Yes, I could file a PR. Do I need to create a

[GitHub] [httpcomponents-core] reschke commented on a diff in pull request #424: HTTPCORE-756 - Implement RFC9110 Content-Type Validation for OPTIONS Requests

reschke commented on code in PR #424: URL: https://github.com/apache/httpcomponents-core/pull/424#discussion_r1311309977 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java: ## @@ -127,4 +133,32 @@ public void process(final HttpRequest request,

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #424: HTTPCORE-756 - Implement RFC9110 Content-Type Validation for OPTIONS Requests

ok2c commented on code in PR #424: URL: https://github.com/apache/httpcomponents-core/pull/424#discussion_r1311302155 ## httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java: ## @@ -127,4 +133,32 @@ public void process(final HttpRequest request, final

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #423: HTTPCORE-756 - Enforced the requirement that "https" URIs must not have an empty host identifier

ok2c commented on code in PR #423: URL: https://github.com/apache/httpcomponents-core/pull/423#discussion_r1311292928 ## httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java: ## @@ -313,11 +314,14 @@ public URI build() throws URISyntaxException { return new

[jira] [Created] (HTTPCLIENT-2294) Link to "Multiplexed HTTP/2 exchanges" broken in HttpClient Examples (Async)

Konrad Windszus created HTTPCLIENT-2294: --- Summary: Link to "Multiplexed HTTP/2 exchanges" broken in HttpClient Examples (Async) Key: HTTPCLIENT-2294 URL:

[jira] [Commented] (HTTPCLIENT-2291) RetryStrategy: AsyncExecChainHandler and ExecChainHandler behavior should be identical

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760765#comment-17760765 ] Oleg Kalnichevski commented on HTTPCLIENT-2291: --- > I think it would be helpful to

[jira] [Resolved] (HTTPCLIENT-2291) RetryStrategy: AsyncExecChainHandler and ExecChainHandler behavior should be identical

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-2291. --- Resolution: Fixed Fixed in master (5.3) Oleg > RetryStrategy:

[jira] [Commented] (HTTPCLIENT-2291) RetryStrategy: AsyncExecChainHandler and ExecChainHandler behavior should be identical

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760763#comment-17760763 ] ASF subversion and git services commented on HTTPCLIENT-2291: - Commit

[jira] [Commented] (HTTPCLIENT-2291) RetryStrategy: AsyncExecChainHandler and ExecChainHandler behavior should be identical

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760741#comment-17760741 ] Lars Uffmann commented on HTTPCLIENT-2291: -- [~olegk] I think it would be helpful to

[jira] [Commented] (HTTPCLIENT-2291) RetryStrategy: AsyncExecChainHandler and ExecChainHandler behavior should be identical

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760735#comment-17760735 ] Lars Uffmann commented on HTTPCLIENT-2291: -- The proposed fix does work as expected. I could