Re: [PR] Use MessageDigest.isEquals method when comparing signatures in NTLMEn… [httpcomponents-client]

oscerd commented on PR #541: URL: https://github.com/apache/httpcomponents-client/pull/541#issuecomment-1910200090 Thanks for the fast feedback and thanks for all you and the PMC do every day. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Use MessageDigest.isEquals method when comparing signatures in NTLMEn… [httpcomponents-client]

ok2c commented on PR #541: URL: https://github.com/apache/httpcomponents-client/pull/541#issuecomment-1910198001 @oscerd Cherry-picked to `5.3.x` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Use MessageDigest.isEquals method when comparing signatures in NTLMEn… [httpcomponents-client]

ok2c merged PR #541: URL: https://github.com/apache/httpcomponents-client/pull/541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

[PR] Use MessageDigest.isEquals method when comparing signatures in NTLMEn… [httpcomponents-client]

oscerd opened a new pull request, #541: URL: https://github.com/apache/httpcomponents-client/pull/541 …gineImpl Just a minor finding. It's true that timing attack is not applicable here, but it's a best practice to use MessageDigest.isEqual for this cases. -- This is an automated m

Re: [PR] Mention HttpStatus and StatusCode in JavaDoc in more places [httpcomponents-core]

ok2c commented on PR #454: URL: https://github.com/apache/httpcomponents-core/pull/454#issuecomment-1909809506 @unkarjedy Cherry-picked to `5.2.x` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Mention HttpStatus and StatusCode in JavaDoc in more places [httpcomponents-core]

ok2c merged PR #454: URL: https://github.com/apache/httpcomponents-core/pull/454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

[PR] Mention HttpStatus and StatusCode in JavaDoc in more places [httpcomponents-core]

unkarjedy opened a new pull request, #454: URL: https://github.com/apache/httpcomponents-core/pull/454 I was originally searching for a way to test that `HttpStatus` code was "successful". I didn't want to create a utility in my code base which checks `200 <= code && code < 300`, because

Re: [PR] FileResourceFactory improvement [httpcomponents-client]

ok2c commented on PR #537: URL: https://github.com/apache/httpcomponents-client/pull/537#issuecomment-1909745873 If I hear no objections I will merge this PR in the coming days -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[ANNOUNCEMENT] HttpComponents Client 5.3.1 GA Released

The Apache HttpComponents project is pleased to announce 5.3.1 GA release of HttpComponents HttpClient. This is a maintenance release that fixes several minor defects and a regression in the Fluent module causing the response body truncation discovered since release 5.3. Download -