[GitHub] [httpcomponents-client] ok2c commented on issue #210: re-add validateAfterInactivity to pool manager

2020-02-17 Thread GitBox
ok2c commented on issue #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210#issuecomment-586875937 > @ok2c ok after looking at the code it is still not clear for me why you said it is inefficient. @h0nIg Because in

[GitHub] [httpcomponents-client] ok2c commented on issue #210: re-add validateAfterInactivity to pool manager

2020-02-13 Thread GitBox
ok2c commented on issue #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210#issuecomment-585759167 @h0nIg The stale check is ineffective because the connection can go stale immediately after having passed the check. It can

[GitHub] [httpcomponents-client] ok2c commented on issue #210: re-add validateAfterInactivity to pool manager

2020-02-13 Thread GitBox
ok2c commented on issue #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210#issuecomment-585732292 @h0nIg The stale connection check is both ineffective and inefficient. A major release is the point when its application can be

[GitHub] [httpcomponents-client] ok2c commented on issue #210: re-add validateAfterInactivity to pool manager

2020-02-13 Thread GitBox
ok2c commented on issue #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210#issuecomment-585611409 @h0nIg The check _will_ get triggered if configured correctly.

[GitHub] [httpcomponents-client] ok2c commented on issue #210: re-add validateAfterInactivity to pool manager

2020-02-13 Thread GitBox
ok2c commented on issue #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210#issuecomment-585601313 > @ok2c to restore the original 4.x behaviour as outlined in my comment. Please take a look at the links how it looked before

[GitHub] [httpcomponents-client] ok2c commented on issue #210: re-add validateAfterInactivity to pool manager

2020-02-12 Thread GitBox
ok2c commented on issue #210: re-add validateAfterInactivity to pool manager URL: https://github.com/apache/httpcomponents-client/pull/210#issuecomment-585219463 @h0nIg Why? What is exactly the benefit of calling that method in the constructor?