[GitHub] [httpcomponents-core] yndu13 commented on pull request #427: Support SOCKS5 proxy with username/password authentication

yndu13 commented on PR #427: URL: https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705190444 > Hi @yndu13 Thank you for your PR. Without a matching test, this change in behavior can be undone in the future without anyone noticing. I agree with this opinion, but

[GitHub] [httpcomponents-core] yndu13 commented on pull request #427: Support SOCKS5 proxy with username/password authentication

yndu13 commented on PR #427: URL: https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705165517 > @yndu13 Looks correct to me. I am still trying to test the fix locally. Thanks, you can use this [socks server](https://github.com/serjs/socks5-server) to verify this

[GitHub] [httpcomponents-core] yndu13 commented on pull request #427: Support SOCKS5 proxy with username/password authentication

yndu13 commented on PR #427: URL: https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1704592623 @ok2c Can someone give a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to