[GitHub] httpcomponents-client issue #100: Information responses (1xx) processing imp...

2018-03-12 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/httpcomponents-client/pull/100 @ok2c : Oops, I did not realize we were talking about 5.0, sorry. So yeah, changing the current interface makes sense. --- --

[GitHub] httpcomponents-client issue #100: Information responses (1xx) processing imp...

2018-03-12 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcomponents-client/pull/100 @kirill-usov HC 5.0 is still BETA. Some API changes are still to be expected. We are still many months away from the API freeze. I suggest that we do the right thing and fix what needs fi

[GitHub] httpcomponents-client issue #100: Information responses (1xx) processing imp...

2018-03-12 Thread kirill-usov
Github user kirill-usov commented on the issue: https://github.com/apache/httpcomponents-client/pull/100 AsyncResponseConsumer interface is a part of core. I did not want to change core, because it can be a reason of regression on products using it. And I tried to keep all existing in

[GitHub] httpcomponents-client issue #100: Information responses (1xx) processing imp...

2018-03-12 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcomponents-client/pull/100 @garydgregory I see no problem with making small profile API changes to 5.0 while we are still in BETA --- - To unsub

[GitHub] httpcomponents-client issue #100: Information responses (1xx) processing imp...

2018-03-12 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/httpcomponents-client/pull/100 Wouldn't adding a method to an existing interface break BC? Are we OK with that or would we/should we introduce a subinterface? --- -

[GitHub] httpcomponents-client issue #100: Information responses (1xx) processing imp...

2018-03-12 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcomponents-client/pull/100 What I do not like about your patch is that it introduces another callback interface (`HttpClientAsyncExecutionCallback`). I believe it would be cleaner to add `#informationResponse` to t

[GitHub] httpcomponents-client issue #100: Information responses (1xx) processing imp...

2018-03-12 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcomponents-client/pull/100 @kirill-usov It most definitely works with minimal HttpAsyncClient ``` final IOReactorConfig ioReactorConfig = IOReactorConfig.custom() .setSoTimeout(Timeout.ofSeconds(5

[GitHub] httpcomponents-client issue #100: Information responses (1xx) processing imp...

2018-03-12 Thread kirill-usov
Github user kirill-usov commented on the issue: https://github.com/apache/httpcomponents-client/pull/100 Hello. I need to handle 103 Early Hints response from the server (RFC 8297). But I did not found any way handle it in async client when I am creating default, minimal or build

[GitHub] httpcomponents-client issue #100: Information responses (1xx) processing imp...

2018-03-07 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcomponents-client/pull/100 @kirill-usov Kirill, could you please briefly describe what you are trying to accomplish with these changes? I think HttpClient 5.0 already supports 1xx message processing through `AsyncC