[GitHub] michael-o commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent to be disabled

2018-12-23 Thread GitBox
michael-o commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent to be disabled URL: https://github.com/apache/httpcomponents-client/pull/128#issuecomment-449667069 Will do in a Moment and prepare 4.5.x PR. This

[GitHub] michael-o commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent to be disabled

2018-12-23 Thread GitBox
michael-o commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent to be disabled URL: https://github.com/apache/httpcomponents-client/pull/128#issuecomment-449666799 @ok2c That is true, but that would require if clauses around `execChainDefinition.addFirst` and `b.addAll(..,

[GitHub] michael-o commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent to be disabled

2018-12-23 Thread GitBox
michael-o commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent to be disabled URL: https://github.com/apache/httpcomponents-client/pull/128#issuecomment-449662138 One would also need to change the `@since` if we backport this to 4.5.x. --

[GitHub] michael-o commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent to be disabled

2018-12-23 Thread GitBox
michael-o commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent to be disabled URL: https://github.com/apache/httpcomponents-client/pull/128#issuecomment-449662106 @thc202 Thanks, missed that in the interactive add. ---