kkewwei commented on PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#issuecomment-1851258694
@ok2c I don't have access to Win11. let me try to find the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ok2c commented on PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#issuecomment-1823071011
@kkewwei I just discovered that the test case you have submitted was failing
on Win11 with JRE 11.0.20.
I removed your commit from `master`. If you have access to Win11
ok2c merged PR #442:
URL: https://github.com/apache/httpcomponents-core/pull/442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kkewwei commented on code in PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#discussion_r1382699123
##
httpcore5/src/main/java/org/apache/hc/core5/reactor/SingleCoreIOReactor.java:
##
@@ -27,10 +27,22 @@
package org.apache.hc.core5.reactor;
+import
ok2c commented on code in PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#discussion_r1382621660
##
httpcore5/src/main/java/org/apache/hc/core5/reactor/SingleCoreIOReactor.java:
##
@@ -27,10 +27,22 @@
package org.apache.hc.core5.reactor;
+import
ok2c commented on PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#issuecomment-1793766886
@kkewwei Also there are test failures with Java 1.8
```
Error: Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.008 s <<< FAILURE! - in
ok2c commented on code in PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#discussion_r1382594611
##
httpcore5/src/main/java/org/apache/hc/core5/net/ExtendedSocketOptions.java:
##
@@ -0,0 +1,49 @@
+/*
+ *
kkewwei opened a new pull request, #442:
URL: https://github.com/apache/httpcomponents-core/pull/442
Support setting TCP_KEEPIDLE, TCP_KEEPINTERVAL, TCP_KEEPCOUNT in Socket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
