ok2c commented on PR #484:
URL:
https://github.com/apache/httpcomponents-core/pull/484#issuecomment-2370807268
@garydgregory I do not think breakage of compile compatibility is warranted
here. Once `hc-parent` is upgraded a newer version of `japicmp` will no longer
let the build to pass in
garydgregory commented on PR #484:
URL:
https://github.com/apache/httpcomponents-core/pull/484#issuecomment-2370800473
Hi @ok2c
I am ok with breaking source compatibility but obviously not binary
compatibility. If you feel source compatibility is important in this case,
then, yeah, som
ok2c commented on PR #484:
URL:
https://github.com/apache/httpcomponents-core/pull/484#issuecomment-2370743858
@garydgregory I already have a fix for the problem. I can adjust the
change-set if it is fine with you.
--
This is an automated message from the Apache Git Service.
To respond t
ok2c commented on PR #484:
URL:
https://github.com/apache/httpcomponents-core/pull/484#issuecomment-2370726252
@garydgregory According to the latest `japicmp` this change-set broke
backward (compile) compatibility.
```
[ERROR] Failed to execute goal
com.github.siom79.japicmp:japi
garydgregory merged PR #484:
URL: https://github.com/apache/httpcomponents-core/pull/484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
ok2c commented on PR #484:
URL:
https://github.com/apache/httpcomponents-core/pull/484#issuecomment-2368918076
@garydgregory Looks good. Please re-apply with the latest style checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
garydgregory opened a new pull request, #484:
URL: https://github.com/apache/httpcomponents-core/pull/484
- Reduces boilerplate when the same pattern is used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
