Re: File based HTTP cache implementation is feature complete

2010-08-16 Thread Campbell, Joseph
2010 Subject: RE: File based HTTP cache implementation is feature complete Just an update here. I've done some scratch refactoring, and see how to do this now. I'm not quite done but am perhaps halfway there. The main issue here is that there is a "hidden class" inside Cachi

RE: File based HTTP cache implementation is feature complete

2010-08-16 Thread Oleg Kalnichevski
On Mon, 2010-08-16 at 16:36 -0400, Moore, Jonathan wrote: > Just an update here. I've done some scratch refactoring, and see how to > do this now. I'm not quite done but am perhaps halfway there. > > The main issue here is that there is a "hidden class" inside > CachingHttpClient that handles reso

RE: File based HTTP cache implementation is feature complete

2010-08-16 Thread Moore, Jonathan
implify CachingHttpClient and nicely encapsulate resource management and CacheEntry storage together behind the HttpCache interface. Jon -Original Message- From: Oleg Kalnichevski [mailto:[email protected]] Sent: Friday, August 13, 2010 3:39 PM To: HttpComponents Project Subject:

RE: File based HTTP cache implementation is feature complete

2010-08-13 Thread Oleg Kalnichevski
On Fri, 2010-08-13 at 11:28 -0400, Moore, Jonathan wrote: > Hi Oleg, > > I took a quick look, and see where you are going with this. My only > suggestion here is that I'm not sure that an HttpCache and a > ResourceFactory should both be constructors to the CachingHttpClient; > this feels to me lik

RE: File based HTTP cache implementation is feature complete

2010-08-13 Thread Moore, Jonathan
oject Cc: Moore, Jonathan Subject: File based HTTP cache implementation is feature complete Jon et al I am pretty much done vandalizing your code. In particular I have made some major changes to the SizeLimitedResponseReader class, which can now be used to generate cache entries backed by a

File based HTTP cache implementation is feature complete

2010-08-12 Thread Oleg Kalnichevski
Jon et al I am pretty much done vandalizing your code. In particular I have made some major changes to the SizeLimitedResponseReader class, which can now be used to generate cache entries backed by a file without intermediate content buffering in memory. I think the new API is flexible enough to a