Re: HttpAsyncExpectationVerifier question

2017-05-20 Thread Gary Gregory
On May 20, 2017 11:17 AM, "Oleg Kalnichevski" wrote: On Sat, 2017-05-20 at 11:10 -0700, Gary Gregory wrote: > On May 20, 2017 11:02 AM, "Oleg Kalnichevski" ... > > What do you think about providing a similar hook for general purpose > validation of incoming requests? > > Gary > I imagine this

Re: HttpAsyncExpectationVerifier question

2017-05-20 Thread Oleg Kalnichevski
On Sat, 2017-05-20 at 11:10 -0700, Gary Gregory wrote: > On May 20, 2017 11:02 AM, "Oleg Kalnichevski" ... > > What do you think about providing a similar hook for general purpose > validation of incoming requests? > > Gary > I imagine this could be done with request interceptors. That is w

Re: HttpAsyncExpectationVerifier question

2017-05-20 Thread Gary Gregory
On May 20, 2017 11:02 AM, "Oleg Kalnichevski" wrote: On Sat, 2017-05-20 at 10:52 -0700, Gary Gregory wrote: > On Sat, May 20, 2017 at 10:12 AM, Oleg Kalnichevski > > wrote: > > > On Sat, 2017-05-20 at 09:52 -0700, Gary Gregory wrote: > > > OK, cool, my next issue (in the same method) is that the

Re: HttpAsyncExpectationVerifier question

2017-05-20 Thread Oleg Kalnichevski
On Sat, 2017-05-20 at 10:52 -0700, Gary Gregory wrote: > On Sat, May 20, 2017 at 10:12 AM, Oleg Kalnichevski > > wrote: > > > On Sat, 2017-05-20 at 09:52 -0700, Gary Gregory wrote: > > > OK, cool, my next issue (in the same method) is that the verifier > > > is > > > NOT > > > called for all requ

Re: HttpAsyncExpectationVerifier question

2017-05-20 Thread Gary Gregory
On Sat, May 20, 2017 at 10:12 AM, Oleg Kalnichevski wrote: > On Sat, 2017-05-20 at 09:52 -0700, Gary Gregory wrote: > > OK, cool, my next issue (in the same method) is that the verifier is > > NOT > > called for all requests, which is a bug for my use case. I can see > > that it > > is only calle

Re: HttpAsyncExpectationVerifier question

2017-05-20 Thread Oleg Kalnichevski
On Sat, 2017-05-20 at 09:52 -0700, Gary Gregory wrote: > OK, cool, my next issue (in the same method) is that the verifier is > NOT > called for all requests, which is a bug for my use case. I can see > that it > is only called for HttpEntityEnclosingRequest so I cannot verify all > requests coming

Re: HttpAsyncExpectationVerifier question

2017-05-20 Thread Gary Gregory
OK, cool, my next issue (in the same method) is that the verifier is NOT called for all requests, which is a bug for my use case. I can see that it is only called for HttpEntityEnclosingRequest so I cannot verify all requests coming in! if (request instanceof HttpEntityEnclosingRequest) {

Re: HttpAsyncExpectationVerifier question

2017-05-20 Thread Oleg Kalnichevski
On Fri, 2017-05-19 at 16:30 -0700, Gary Gregory wrote: > Hi All, > > I'm trying to understand the implications of using > a HttpAsyncExpectationVerifier. > > I see only one call site and no tests: > There are quite a few tests https://github.com/apache/httpcomponents-core/blob/4.4.x/httpcore-n

HttpAsyncExpectationVerifier question

2017-05-19 Thread Gary Gregory
Hi All, I'm trying to understand the implications of using a HttpAsyncExpectationVerifier. I see only one call site and no tests: org.apache.http.nio.protocol.HttpAsyncService.requestReceived(NHttpServerConnection): ... if (this.expectationVerifier != null) {