Re: httpcore regression?

2008-03-07 Thread Oleg Kalnichevski
On Fri, 2008-03-07 at 00:56 +0200, Andreas Andreou wrote: Hi list! We've been using httpcore httpcore-nio 4.0-beta2-20080229.095821-3 but since the new 4.0-beta2-20080303.182830-4 we've been getting (on attempts to request any url) Exception in thread IO Reactor Execution Thread

Re: httpcore regression?

2008-03-07 Thread Andreas Andreou
on the other hand - adding a null check at that exact line (AsyncNHttpClientHandler.java:222) appears to just work! On Fri, Mar 7, 2008 at 11:08 PM, Andreas Andreou [EMAIL PROTECTED] wrote: hmmm - no luck... I now get Exception in thread IO Reactor Execution Thread

Re: httpcore regression?

2008-03-07 Thread Andreas Andreou
i'm totally clueless on the internals but this suggestion sounds like the null-object pattern and indeed makes sense here (instead of keep finding probable null checking situations) On Fri, Mar 7, 2008 at 11:12 PM, Sam Berlin [EMAIL PROTECTED] wrote: I think the change should be to set an empty

Re: httpcore regression?

2008-03-07 Thread Oleg Kalnichevski
On Fri, 2008-03-07 at 23:34 +0100, Oleg Kalnichevski wrote: On Fri, 2008-03-07 at 16:18 -0500, Sam Berlin wrote: Ya, that's basically the reason for the suggestion -- to prevent adding a bunch of if!=null checks all over. Good to know that the Async client handler is being used (if only

Re: httpcore regression?

2008-03-07 Thread Andreas Andreou
thx Sam, Oleg - trunk works ok for me now :) On Sat, Mar 8, 2008 at 1:06 AM, Sam Berlin [EMAIL PROTECTED] wrote: Noticed this am modifying DefaultNHttpClientConnection.submitRequest -- it checks for request being an instanceof HttpEntityEnclosingRequest, not also for if the enclosed entity

Re: httpcore regression?

2008-03-06 Thread Oleg Kalnichevski
On Fri, 2008-03-07 at 00:56 +0200, Andreas Andreou wrote: Hi list! We've been using httpcore httpcore-nio 4.0-beta2-20080229.095821-3 but since the new 4.0-beta2-20080303.182830-4 we've been getting (on attempts to request any url) Exception in thread IO Reactor Execution Thread