michael-o edited a comment on issue #126: replace empty
HttpResponseException.message with statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#issuecomment-448722303
So the message says 500? What ist that supposed to mean? No context. A
status code isn't a message.
panchenko commented on issue #126: replace empty HttpResponseException.message
with statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#issuecomment-448724569
"500" is slightly better than an empty string, that's all.
Surely it can be made more verbose.
panchenko commented on issue #126: replace empty HttpResponseException.message
with statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#issuecomment-448726260
... and the meaning of 500 comes from the HttpResponseException exception
class.
The message alone is not
michael-o commented on issue #126: replace empty HttpResponseException.message
with statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#issuecomment-448722303
So the message says 500? What ist that supposed t mean? No context. A status
code isn't a message. It
michael-o commented on issue #126: replace empty HttpResponseException.message
with statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#issuecomment-448770010
@ok2c Why not provide a reasonable message like `status code: %s, reason
phrase: %s`. If reason phase is
michael-o edited a comment on issue #126: replace empty
HttpResponseException.message with statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#issuecomment-448770010
@ok2c Why not provide a reasonable message like `status code: %s, reason
phrase: %s`? If reason phase
panchenko commented on issue #126: replace empty HttpResponseException.message
with statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#issuecomment-448749749
to HttpResponseException, which extends IOException
panchenko edited a comment on issue #126: replace empty
HttpResponseException.message with statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#issuecomment-448751399
The point is having it logged like this
```
org.apache.http.client.HttpResponseException: 404
ok2c commented on issue #126: replace empty HttpResponseException.message with
statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#issuecomment-448753350
@michael-o Having a status code as an error message is a **massive**
improvement over having no error message at
panchenko commented on issue #126: replace empty HttpResponseException.message
with statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#issuecomment-448687098
@michael-o The idea is having a bit more information in logs when logging an
instance of IOException caught.
panchenko edited a comment on issue #126: replace empty
HttpResponseException.message with statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#issuecomment-448687098
@michael-o The idea is having a bit more information in logs when logging an
instance of IOException
michael-o commented on issue #126: replace empty HttpResponseException.message
with statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#issuecomment-448744370
But since you pass "500" to IOException, this gives no benefit at all. There
has to be a better approach.
panchenko opened a new pull request #126: replace empty
HttpResponseException.message with statusCode
URL: https://github.com/apache/httpcomponents-client/pull/126
Tomcat 8.5 omits reason phrase.
So in order to have more informative logs I would suggest using statusCode
instead.
It
ok2c commented on a change in pull request #126: replace empty
HttpResponseException.message with statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#discussion_r242850662
##
File path:
ok2c closed pull request #126: replace empty HttpResponseException.message with
statusCode
URL: https://github.com/apache/httpcomponents-client/pull/126
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
panchenko opened a new pull request #127: replace empty
HttpResponseException.message with statusCode
URL: https://github.com/apache/httpcomponents-client/pull/127
(cherry picked from commit 20dfff12c4dc3f73fe5d19b690c2eee033ed4125)
ok2c commented on issue #126: replace empty HttpResponseException.message with
statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#issuecomment-448628461
@panchenko By the way, would you mind porting this change to `master`?
panchenko commented on a change in pull request #126: replace empty
HttpResponseException.message with statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#discussion_r242946793
##
File path:
ok2c closed pull request #127: replace empty HttpResponseException.message with
statusCode
URL: https://github.com/apache/httpcomponents-client/pull/127
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
ok2c commented on issue #127: replace empty HttpResponseException.message with
statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/127#issuecomment-448635118
@panchenko The test case still needs porting.
michael-o commented on issue #126: replace empty HttpResponseException.message
with statusCode
URL:
https://github.com/apache/httpcomponents-client/pull/126#issuecomment-448683230
I request to revert this. This is redundant information. This PR just
pointless. Tomcat omits the phrase on
21 matches
Mail list logo
