[
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated HTTPCLIENT-1952:
---
Fix Version/s: 5.0 Beta4
4.5.7
> Allow default User Agent to
michael-o opened a new pull request #129: Improve
HttpResponseException#getMessage()
URL: https://github.com/apache/httpcomponents-client/pull/129
The #getMessage() now properly consists of the status code as such and the
optional reason phrase. Moreover, the pure reason phrase can be
ok2c closed pull request #129: Improve HttpResponseException#getMessage()
URL: https://github.com/apache/httpcomponents-client/pull/129
This is an automated message from the Apache Git Service.
To respond to the message,
ok2c commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent to be
disabled
URL:
https://github.com/apache/httpcomponents-client/pull/128#issuecomment-449666855
@michael-o Feel free to merge the PR.
This is an
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728067#comment-16728067
]
ASF subversion and git services commented on HTTPCLIENT-1952:
-
Commit
asfgit closed pull request #128: [HTTPCLIENT-1952] Allow default User Agent to
be disabled
URL: https://github.com/apache/httpcomponents-client/pull/128
This is an automated message from the Apache Git Service.
To respond
michael-o opened a new pull request #131: [HTTPCLIENT-1952] Allow default User
Agent to be disabled
URL: https://github.com/apache/httpcomponents-client/pull/131
This is an automated message from the Apache Git Service.
To
thc202 commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent to
be disabled
URL:
https://github.com/apache/httpcomponents-client/pull/128#issuecomment-449661812
It seems you didn't commit all changes (`defaultUserAgentDisabled` is not
used).
michael-o commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent
to be disabled
URL:
https://github.com/apache/httpcomponents-client/pull/128#issuecomment-449666799
@ok2c That is true, but that would require if clauses around
`execChainDefinition.addFirst` and `b.addAll(..,
ok2c commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent to be
disabled
URL:
https://github.com/apache/httpcomponents-client/pull/128#issuecomment-449666847
@michael-o Agreed.
This is an automated message
Am 2018-12-24 um 01:05 schrieb Michael Osipov:
Am 2018-12-23 um 23:21 schrieb Oleg Kalnichevski:
On Sun, 2018-12-23 at 22:07 +0100, Michael Osipov wrote:
Folks,
why does a minimal client:
HttpClientBuilder bulder =
HttpClientBuilder.create().disableContentCompression();
CloseableHttpClient
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728044#comment-16728044
]
Michael Osipov commented on HTTPCLIENT-1952:
I have now opened a PR for 5.0. No tests
On Sun, 2018-12-23 at 22:07 +0100, Michael Osipov wrote:
> Folks,
>
> why does a minimal client:
> > HttpClientBuilder bulder =
> > HttpClientBuilder.create().disableContentCompression();
> > CloseableHttpClient client = bulder.build();
> > CloseableHttpResponse resp = client.execute(new
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728064#comment-16728064
]
ASF subversion and git services commented on HTTPCLIENT-1952:
-
Commit
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728065#comment-16728065
]
ASF subversion and git services commented on HTTPCLIENT-1952:
-
Commit
michael-o opened a new pull request #128: [HTTPCLIENT-1952] Allow default User
Agent to be disabled
URL: https://github.com/apache/httpcomponents-client/pull/128
Naive Approach works for me. I am not certain whether the `@see` is
necessary. I think not.
michael-o commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent
to be disabled
URL:
https://github.com/apache/httpcomponents-client/pull/128#issuecomment-449662138
One would also need to change the `@since` if we backport this to 4.5.x.
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728053#comment-16728053
]
ASF subversion and git services commented on HTTPCLIENT-1952:
-
Commit
michael-o commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent
to be disabled
URL:
https://github.com/apache/httpcomponents-client/pull/128#issuecomment-449662106
@thc202 Thanks, missed that in the interactive add.
michael-o commented on issue #129: Improve HttpResponseException#getMessage()
URL:
https://github.com/apache/httpcomponents-client/pull/129#issuecomment-449666384
@ok2c shall I backport to 4.5.x?
This is an automated
ok2c commented on issue #129: Improve HttpResponseException#getMessage()
URL:
https://github.com/apache/httpcomponents-client/pull/129#issuecomment-449666435
@michael-o Up to you. I do not feel very strongly about this change.
michael-o closed pull request #130: Improve HttpResponseException#getMessage()
URL: https://github.com/apache/httpcomponents-client/pull/130
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728071#comment-16728071
]
ASF subversion and git services commented on HTTPCLIENT-1952:
-
Commit
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728073#comment-16728073
]
Michael Osipov commented on HTTPCLIENT-1952:
Implemented in master and 4.5.x.
> Allow
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed HTTPCLIENT-1952.
--
Resolution: Fixed
> Allow default User Agent to be disabled
>
Am 2018-12-23 um 23:21 schrieb Oleg Kalnichevski:
On Sun, 2018-12-23 at 22:07 +0100, Michael Osipov wrote:
Folks,
why does a minimal client:
HttpClientBuilder bulder =
HttpClientBuilder.create().disableContentCompression();
CloseableHttpClient client = bulder.build();
CloseableHttpResponse
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728043#comment-16728043
]
ASF subversion and git services commented on HTTPCLIENT-1952:
-
Commit
Folks,
why does a minimal client:
HttpClientBuilder bulder =
HttpClientBuilder.create().disableContentCompression();
CloseableHttpClient client = bulder.build();
CloseableHttpResponse resp = client.execute(new HttpGet("https://google.de;));
EntityUtils.consumeQuietly(resp.getEntity());
still
michael-o opened a new pull request #130: Improve
HttpResponseException#getMessage()
URL: https://github.com/apache/httpcomponents-client/pull/130
The #getMessage() now properly consists of the status code as such and the
optional reason phrase. Moreover, the pure reason phrase can be
asfgit closed pull request #131: [HTTPCLIENT-1952] Allow default User Agent to
be disabled
URL: https://github.com/apache/httpcomponents-client/pull/131
This is an automated message from the Apache Git Service.
To respond
ok2c commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent to be
disabled
URL:
https://github.com/apache/httpcomponents-client/pull/128#issuecomment-449666545
@michael-o Ideally `RequestUserAgent` should be removed from the message
processing chain entirely but looks good
michael-o commented on issue #128: [HTTPCLIENT-1952] Allow default User Agent
to be disabled
URL:
https://github.com/apache/httpcomponents-client/pull/128#issuecomment-449667069
Will do in a Moment and prepare 4.5.x PR.
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728072#comment-16728072
]
ASF subversion and git services commented on HTTPCLIENT-1952:
-
Commit
33 matches
Mail list logo
