Re: HttpClient 5.0 migration guide

Great initiative ! Thanks a lot Oleg. Will certainly use it soon with JMeter and try to give feedback. On Sat, Feb 23, 2019 at 12:35 AM Gary Gregory wrote: > The docs look really nice. I just started looking and I hope to be able to > read through the whole site over the next week. > >

Re: HttpClient 5.0 migration guide

The docs look really nice. I just started looking and I hope to be able to read through the whole site over the next week. CloseableHttpClient instances should be closed when no longer needed or about to go out of score. We should also say that this can be used in a try-with-resources statement.

[GitHub] garydgregory edited a comment on issue #111: Add a thread-safe capacity channel to AbstractHttp1StreamDuplexer

garydgregory edited a comment on issue #111: Add a thread-safe capacity channel to AbstractHttp1StreamDuplexer URL: https://github.com/apache/httpcomponents-core/pull/111#issuecomment-466583525 I think what matters here is the overall behavior. A black-box kind of test that fails without

[GitHub] garydgregory commented on issue #111: Add a thread-safe capacity channel to AbstractHttp1StreamDuplexer

garydgregory commented on issue #111: Add a thread-safe capacity channel to AbstractHttp1StreamDuplexer URL: https://github.com/apache/httpcomponents-core/pull/111#issuecomment-466583525 I think what matters here is the overall behavior. A black-box kind of test that fails without the

[GitHub] rhernandez35 commented on issue #111: Add a thread-safe capacity channel to AbstractHttp1StreamDuplexer

rhernandez35 commented on issue #111: Add a thread-safe capacity channel to AbstractHttp1StreamDuplexer URL: https://github.com/apache/httpcomponents-core/pull/111#issuecomment-466559109 I can move CapacityWindow to its own class or make it package-private static and write some basic

[GitHub] garydgregory commented on issue #111: Add a thread-safe capacity channel to AbstractHttp1StreamDuplexer

garydgregory commented on issue #111: Add a thread-safe capacity channel to AbstractHttp1StreamDuplexer URL: https://github.com/apache/httpcomponents-core/pull/111#issuecomment-466553581 How would you unit test this? This

[GitHub] rschmitt commented on issue #111: Add a thread-safe capacity channel to AbstractHttp1StreamDuplexer

rschmitt commented on issue #111: Add a thread-safe capacity channel to AbstractHttp1StreamDuplexer URL: https://github.com/apache/httpcomponents-core/pull/111#issuecomment-466538045 @ok2c PTAL This is an automated message

Re: HttpCore 5.0 BETA7?

Almost! My colleague has one more subtle bugfix to merge first: https://github.com/apache/httpcomponents-core/pull/111 On Fri, Feb 22, 2019 at 11:31 AM Gary Gregory wrote: > Let's fire up the new beta! :-) > > Gary > > On Sat, Feb 16, 2019, 09:26 Oleg Kalnichevski > > On Sat, 2019-02-16 at

[jira] [Commented] (HTTPCLIENT-1969) Filter out weak TLS cipher suites in Apache HttpClient

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775534#comment-16775534 ] Michael Osipov commented on HTTPCLIENT-1969: I see what you are after. It would make the

Re: HttpCore 5.0 BETA7?

Let's fire up the new beta! :-) Gary On Sat, Feb 16, 2019, 09:26 Oleg Kalnichevski On Sat, 2019-02-16 at 09:18 -0500, Gary Gregory wrote: > > > > ... > > > I get a compiler error with the above patch: > > > > Description Resource Path Location Type > > The method > >

[jira] [Commented] (HTTPCLIENT-1969) Filter out weak TLS cipher suites in Apache HttpClient

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775528#comment-16775528 ] Artem Smotrakov commented on HTTPCLIENT-1969: - [~michael-o] I completely agree with the

[GitHub] rhernandez35 opened a new pull request #111: Add a thread-safe capacity channel to AbstractHttp1StreamDuplexer

rhernandez35 opened a new pull request #111: Add a thread-safe capacity channel to AbstractHttp1StreamDuplexer URL: https://github.com/apache/httpcomponents-core/pull/111 This solves two issues: 1. A data consumer that retains a reference to an old capacity channel will no longer

[jira] [Commented] (HTTPCLIENT-1969) Filter out weak TLS cipher suites in Apache HttpClient

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775518#comment-16775518 ] Michael Osipov commented on HTTPCLIENT-1969: I don't think that this is really necessary

[jira] [Created] (HTTPCLIENT-1969) Filter out weak TLS cipher suites in Apache HttpClient

Artem Smotrakov created HTTPCLIENT-1969: --- Summary: Filter out weak TLS cipher suites in Apache HttpClient Key: HTTPCLIENT-1969 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1969 Project: