ok2c commented on code in PR #502:
URL:
https://github.com/apache/httpcomponents-client/pull/502#discussion_r1382557118
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java:
##
@@ -357,7 +357,19 @@ ManagedHttpClientConnection
kkewwei opened a new pull request, #442:
URL: https://github.com/apache/httpcomponents-core/pull/442
Support setting TCP_KEEPIDLE, TCP_KEEPINTERVAL, TCP_KEEPCOUNT in Socket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ok2c commented on code in PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#discussion_r1382621660
##
httpcore5/src/main/java/org/apache/hc/core5/reactor/SingleCoreIOReactor.java:
##
@@ -27,10 +27,22 @@
package org.apache.hc.core5.reactor;
+import
ok2c commented on PR #501:
URL:
https://github.com/apache/httpcomponents-client/pull/501#issuecomment-1793709117
@arturobernalg Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
arturobernalg commented on code in PR #502:
URL:
https://github.com/apache/httpcomponents-client/pull/502#discussion_r1382565133
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java:
##
@@ -357,7 +357,19 @@
ok2c commented on code in PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#discussion_r1382594611
##
httpcore5/src/main/java/org/apache/hc/core5/net/ExtendedSocketOptions.java:
##
@@ -0,0 +1,49 @@
+/*
+ *
arturobernalg commented on code in PR #502:
URL:
https://github.com/apache/httpcomponents-client/pull/502#discussion_r1385636960
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java:
##
@@ -357,7 +357,19 @@
arturobernalg opened a new pull request, #498:
URL: https://github.com/apache/httpcomponents-client/pull/498
This update allows automatic selection of Zstd as a compression algorithm
when available.
--
This is an automated message from the Apache Git Service.
To respond to the message,
garydgregory commented on PR #498:
URL:
https://github.com/apache/httpcomponents-client/pull/498#issuecomment-1786950363
Why not do this through Commons Compress?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
arturobernalg commented on PR #498:
URL:
https://github.com/apache/httpcomponents-client/pull/498#issuecomment-1787585157
> Why not do this through Commons Compress?
In general keep it simple. Adding a direct dependency on the Zstd library
is a straightforward way to enable
arturobernalg commented on PR #495:
URL:
https://github.com/apache/httpcomponents-client/pull/495#issuecomment-1775899664
> TestLinearBackoffManager
@ok2c
Was modify a couple day before
arturobernalg merged PR #495:
URL: https://github.com/apache/httpcomponents-client/pull/495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
arturobernalg commented on code in PR #497:
URL:
https://github.com/apache/httpcomponents-client/pull/497#discussion_r1370687082
##
httpclient5/src/main/java/org/apache/hc/client5/http/protocol/RequestIfRange.java:
##
@@ -121,36 +113,21 @@ public void process(final HttpRequest
arturobernalg merged PR #497:
URL: https://github.com/apache/httpcomponents-client/pull/497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kkewwei commented on code in PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#discussion_r1382699123
##
httpcore5/src/main/java/org/apache/hc/core5/reactor/SingleCoreIOReactor.java:
##
@@ -27,10 +27,22 @@
package org.apache.hc.core5.reactor;
+import
ok2c merged PR #442:
URL: https://github.com/apache/httpcomponents-core/pull/442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c opened a new pull request, #501:
URL: https://github.com/apache/httpcomponents-client/pull/501
* Aligns the behavior of the caching protocol handlers with the
specification requirements (sections 3 and 4 RFC 9111)
* Bug fixes
--
This is an automated message from the Apache Git
ok2c commented on PR #501:
URL:
https://github.com/apache/httpcomponents-client/pull/501#issuecomment-1793404009
@arturobernalg This PR is still work in progress. Do take a look at the
changes in `ResponseCachingPolicy` and `CachedResponseSuitabilityChecker` and
let me know if find
arturobernalg commented on PR #430:
URL:
https://github.com/apache/httpcomponents-core/pull/430#issuecomment-1726330738
> * This change-set is definitely useful, but it kind of goes counter to the
overall philosophy of the library. Generally we provide higher level APIs for
consumers to
arturobernalg closed pull request #430: HTTPCORE-756 - Implement 'If-Range'
request validation as per RFC 9110
URL: https://github.com/apache/httpcomponents-core/pull/430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
arturobernalg commented on code in PR #428:
URL:
https://github.com/apache/httpcomponents-core/pull/428#discussion_r1330579222
##
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/DefaultH2RequestConverter.java:
##
@@ -208,4 +210,39 @@ public List convert(final
arturobernalg commented on code in PR #484:
URL:
https://github.com/apache/httpcomponents-client/pull/484#discussion_r1330608339
##
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheConfig.java:
##
@@ -257,11 +232,11 @@ public int
ok2c commented on code in PR #484:
URL:
https://github.com/apache/httpcomponents-client/pull/484#discussion_r1330654678
##
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheConfig.java:
##
@@ -257,11 +232,11 @@ public int getMaxUpdateRetries(){
}
arturobernalg commented on code in PR #431:
URL:
https://github.com/apache/httpcomponents-core/pull/431#discussion_r1334759075
##
httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnection.java:
##
@@ -271,7 +271,7 @@ public void
arturobernalg merged PR #486:
URL: https://github.com/apache/httpcomponents-client/pull/486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
arturobernalg merged PR #485:
URL: https://github.com/apache/httpcomponents-client/pull/485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c merged PR #431:
URL: https://github.com/apache/httpcomponents-core/pull/431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c commented on code in PR #431:
URL:
https://github.com/apache/httpcomponents-core/pull/431#discussion_r1334945292
##
httpcore5/src/main/java/org/apache/hc/core5/http/impl/DefaultConnectionReuseStrategy.java:
##
@@ -81,7 +81,7 @@ public boolean keepAlive(
arturobernalg commented on code in PR #486:
URL:
https://github.com/apache/httpcomponents-client/pull/486#discussion_r1334628672
##
httpclient5/src/main/java/org/apache/hc/client5/http/protocol/RequestTraceInterceptor.java:
##
@@ -0,0 +1,143 @@
+/*
+ *
arturobernalg merged PR #484:
URL: https://github.com/apache/httpcomponents-client/pull/484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c commented on code in PR #428:
URL:
https://github.com/apache/httpcomponents-core/pull/428#discussion_r1329232659
##
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/DefaultH2RequestConverter.java:
##
@@ -208,4 +210,39 @@ public List convert(final HttpRequest
arturobernalg commented on PR #428:
URL:
https://github.com/apache/httpcomponents-core/pull/428#issuecomment-1724146949
> @arturobernalg What RFC have you been using as a reference for change?
@ok2c
this one
ok2c commented on PR #431:
URL:
https://github.com/apache/httpcomponents-core/pull/431#issuecomment-1730944357
@arturobernalg Please kindly let me know if you see anything wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ok2c opened a new pull request, #431:
URL: https://github.com/apache/httpcomponents-core/pull/431
This patch corrects the name/value parsing code in `BasicHeaderValueParser`
and adds a number of message element formatting and parsing methods to
`MessageSupport`
--
This is an automated
arturobernalg commented on code in PR #484:
URL:
https://github.com/apache/httpcomponents-client/pull/484#discussion_r1331915022
##
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheConfig.java:
##
@@ -257,11 +232,11 @@ public int
arturobernalg merged PR #428:
URL: https://github.com/apache/httpcomponents-core/pull/428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c opened a new pull request, #434:
URL: https://github.com/apache/httpcomponents-core/pull/434
* Moved outgoing response conformance checks to the correct place in the
protocol pipeline
* Added incoming request conformance checks based on RFC 9110.
--
This is an automated message
ok2c commented on PR #434:
URL:
https://github.com/apache/httpcomponents-core/pull/434#issuecomment-1739333827
@arturobernalg Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
arturobernalg closed pull request #489: HTTPCLIENT-2293: Disallow Automatic
Retries on 403 Forbidden Status
URL: https://github.com/apache/httpcomponents-client/pull/489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
arturobernalg commented on PR #489:
URL:
https://github.com/apache/httpcomponents-client/pull/489#issuecomment-1739847709
> @arturobernalg The decision whether or not a request should be retried
based on the response status is delegated to the `HttpRequestRetryStrategy`.
The default
snehanie opened a new pull request, #488:
URL: https://github.com/apache/httpcomponents-client/pull/488
UpdateCAS does not catch timeout exceptions.
getUpdateCAS catches and throws ResourceIOException, but updateCas does not.
Try and catch is important since BasicHttpCache would
chrysophylax opened a new pull request, #435:
URL: https://github.com/apache/httpcomponents-core/pull/435
Quick fix for maximum compatibility per JIRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
reschke commented on code in PR #435:
URL:
https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341262963
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -110,6 +110,10 @@ public void process(final HttpRequest request,
ok2c commented on code in PR #435:
URL:
https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341269898
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -110,6 +110,10 @@ public void process(final HttpRequest request, final
reschke commented on code in PR #435:
URL:
https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341287246
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -110,6 +110,10 @@ public void process(final HttpRequest request,
dependabot[bot] closed pull request #420: Bump io.reactivex.rxjava3:rxjava from
3.1.6 to 3.1.7
URL: https://github.com/apache/httpcomponents-core/pull/420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dependabot[bot] opened a new pull request, #436:
URL: https://github.com/apache/httpcomponents-core/pull/436
Bumps [io.reactivex.rxjava3:rxjava](https://github.com/ReactiveX/RxJava)
from 3.1.6 to 3.1.8.
Release notes
Sourced from
ok2c commented on code in PR #435:
URL:
https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341257383
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -110,6 +110,10 @@ public void process(final HttpRequest request, final
ok2c commented on PR #435:
URL:
https://github.com/apache/httpcomponents-core/pull/435#issuecomment-1740750258
@chrysophylax Please also make sure the build still passes all style checks.
I would also kindly ask you to add a test case to `TestStandardInterceptors`
for the new behavior.
chrysophylax commented on PR #435:
URL:
https://github.com/apache/httpcomponents-core/pull/435#issuecomment-1740848880
I updated the existing `testRequestContentNullEntity` test to the new
expected behaviour and added a test to make sure non-PUT/POST/PATCH don't get
the `Content-Length`
ok2c merged PR #435:
URL: https://github.com/apache/httpcomponents-core/pull/435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c closed pull request #488: Update MemcachedHttpCacheStorage.java
URL: https://github.com/apache/httpcomponents-client/pull/488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ok2c commented on PR #488:
URL:
https://github.com/apache/httpcomponents-client/pull/488#issuecomment-1740897624
Superseded by 19abc7e947a25afcfa84f1efd4a915e7a7e8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
reschke commented on code in PR #435:
URL:
https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341273913
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -110,6 +110,10 @@ public void process(final HttpRequest request,
chrysophylax commented on code in PR #435:
URL:
https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341277979
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -110,6 +110,10 @@ public void process(final HttpRequest
ok2c commented on code in PR #435:
URL:
https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341330485
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -110,6 +110,10 @@ public void process(final HttpRequest request, final
chrysophylax commented on code in PR #435:
URL:
https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341265651
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -110,6 +110,10 @@ public void process(final HttpRequest
ok2c commented on code in PR #435:
URL:
https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341285734
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -110,6 +110,10 @@ public void process(final HttpRequest request, final
dependabot[bot] commented on PR #420:
URL:
https://github.com/apache/httpcomponents-core/pull/420#issuecomment-1740998514
Superseded by #436.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
snehanie commented on PR #488:
URL:
https://github.com/apache/httpcomponents-client/pull/488#issuecomment-1741122926
Thank you for the fix. I was going to raise another pull request and you
beat me to it.
--
This is an automated message from the Apache Git Service.
To respond to the
ok2c commented on PR #489:
URL:
https://github.com/apache/httpcomponents-client/pull/489#issuecomment-1738654815
@arturobernalg The decision whether or not a request should be retried based
on the response status is delegated to the `HttpRequestRetryStrategy`. The
default implementation
arturobernalg merged PR #434:
URL: https://github.com/apache/httpcomponents-core/pull/434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c opened a new pull request, #437:
URL: https://github.com/apache/httpcomponents-core/pull/437
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ok2c commented on PR #437:
URL:
https://github.com/apache/httpcomponents-core/pull/437#issuecomment-1742080946
@arturobernalg Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Marcono1234 commented on code in PR #490:
URL:
https://github.com/apache/httpcomponents-client/pull/490#discussion_r1343057798
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/TrustAllStrategy.java:
##
@@ -34,9 +34,15 @@
import
Marcono1234 commented on code in PR #438:
URL:
https://github.com/apache/httpcomponents-core/pull/438#discussion_r1343067206
##
httpcore5/src/main/java/org/apache/hc/core5/ssl/TrustStrategy.java:
##
@@ -34,6 +34,19 @@
* configured in the actual SSL context. This interface
ok2c commented on code in PR #438:
URL:
https://github.com/apache/httpcomponents-core/pull/438#discussion_r1343130372
##
httpcore5/src/main/java/org/apache/hc/core5/ssl/TrustStrategy.java:
##
@@ -34,6 +34,19 @@
* configured in the actual SSL context. This interface can be
ok2c commented on code in PR #438:
URL:
https://github.com/apache/httpcomponents-core/pull/438#discussion_r1343130372
##
httpcore5/src/main/java/org/apache/hc/core5/ssl/TrustStrategy.java:
##
@@ -34,6 +34,19 @@
* configured in the actual SSL context. This interface can be
ok2c commented on code in PR #438:
URL:
https://github.com/apache/httpcomponents-core/pull/438#discussion_r1343130372
##
httpcore5/src/main/java/org/apache/hc/core5/ssl/TrustStrategy.java:
##
@@ -34,6 +34,19 @@
* configured in the actual SSL context. This interface can be
ok2c commented on PR #490:
URL:
https://github.com/apache/httpcomponents-client/pull/490#issuecomment-1743706149
@Marcono1234 Just deprecate `TrustSelfSignedStrategy`in the same PR.
I would not bother with a backport of the changes to 4.x but I will merge
them if you raise a PR for the
Marcono1234 commented on PR #490:
URL:
https://github.com/apache/httpcomponents-client/pull/490#issuecomment-1743608258
> I also propose TrustSelfSignedStrategy be deprecated in favor of
SSLContextBuilder. The class is basically useless.
Should I include this in this PR or create a
ok2c commented on code in PR #490:
URL:
https://github.com/apache/httpcomponents-client/pull/490#discussion_r1343119220
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/TrustAllStrategy.java:
##
@@ -34,9 +34,15 @@
import org.apache.hc.core5.ssl.TrustStrategy;
arturobernalg commented on code in PR #437:
URL:
https://github.com/apache/httpcomponents-core/pull/437#discussion_r1342183980
##
httpcore5/src/main/java/org/apache/hc/core5/http/message/BufferedHeader.java:
##
@@ -110,7 +113,27 @@ public String getName() {
@Override
Marcono1234 opened a new pull request, #490:
URL: https://github.com/apache/httpcomponents-client/pull/490
Tries to improve the documentation of `TrustAllStrategy` and
`TrustSelfSignedStrategy` by mentioning their security implications and
suggesting more secure alternatives.
For
Marcono1234 opened a new pull request, #438:
URL: https://github.com/apache/httpcomponents-core/pull/438
This tries to make the security aspects of `TrustStrategy` clearer and
suggest that it might not be needed when self-signed certificates are used.
Relates to #490
Any
arturobernalg commented on code in PR #437:
URL:
https://github.com/apache/httpcomponents-core/pull/437#discussion_r1342183980
##
httpcore5/src/main/java/org/apache/hc/core5/http/message/BufferedHeader.java:
##
@@ -110,7 +113,27 @@ public String getName() {
@Override
arturobernalg commented on code in PR #437:
URL:
https://github.com/apache/httpcomponents-core/pull/437#discussion_r1342183980
##
httpcore5/src/main/java/org/apache/hc/core5/http/message/BufferedHeader.java:
##
@@ -110,7 +113,27 @@ public String getName() {
@Override
arturobernalg commented on code in PR #437:
URL:
https://github.com/apache/httpcomponents-core/pull/437#discussion_r1342183980
##
httpcore5/src/main/java/org/apache/hc/core5/http/message/BufferedHeader.java:
##
@@ -110,7 +113,27 @@ public String getName() {
@Override
ok2c commented on PR #490:
URL:
https://github.com/apache/httpcomponents-client/pull/490#issuecomment-1742799336
@Marcono1234 I also propose `TrustSelfSignedStrategy` be deprecated in favor
of `SSLContextBuilder`. The class is basically useless.
--
This is an automated message from the
ok2c commented on code in PR #438:
URL:
https://github.com/apache/httpcomponents-core/pull/438#discussion_r1342546547
##
httpcore5/src/main/java/org/apache/hc/core5/ssl/TrustStrategy.java:
##
@@ -34,6 +34,19 @@
* configured in the actual SSL context. This interface can be
ok2c commented on code in PR #438:
URL:
https://github.com/apache/httpcomponents-core/pull/438#discussion_r1342546547
##
httpcore5/src/main/java/org/apache/hc/core5/ssl/TrustStrategy.java:
##
@@ -34,6 +34,19 @@
* configured in the actual SSL context. This interface can be
ok2c commented on code in PR #437:
URL:
https://github.com/apache/httpcomponents-core/pull/437#discussion_r1342526323
##
httpcore5/src/main/java/org/apache/hc/core5/http/message/BufferedHeader.java:
##
@@ -110,7 +113,27 @@ public String getName() {
@Override
public
ok2c merged PR #437:
URL: https://github.com/apache/httpcomponents-core/pull/437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c commented on code in PR #437:
URL:
https://github.com/apache/httpcomponents-core/pull/437#discussion_r1342526096
##
httpcore5/src/main/java/org/apache/hc/core5/http/message/BufferedHeader.java:
##
@@ -110,7 +113,27 @@ public String getName() {
@Override
public
ok2c commented on code in PR #490:
URL:
https://github.com/apache/httpcomponents-client/pull/490#discussion_r1342539092
##
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/TrustAllStrategy.java:
##
@@ -34,9 +34,15 @@
import org.apache.hc.core5.ssl.TrustStrategy;
karthik-119 opened a new pull request, #433:
URL: https://github.com/apache/httpcomponents-core/pull/433
- Fix checkstyle errors to prevent build failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dependabot[bot] commented on PR #487:
URL:
https://github.com/apache/httpcomponents-client/pull/487#issuecomment-1737445998
Looks like these dependencies are up-to-date now, so this is no longer
needed.
--
This is an automated message from the Apache Git Service.
To respond to the
dependabot[bot] closed pull request #487: Bump httpcore.version from 5.2.2 to
5.2.3
URL: https://github.com/apache/httpcomponents-client/pull/487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ok2c commented on PR #487:
URL:
https://github.com/apache/httpcomponents-client/pull/487#issuecomment-1737443152
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
arturobernalg opened a new pull request, #489:
URL: https://github.com/apache/httpcomponents-client/pull/489
This PR updates the HttpRequestRetryExec class to disallow automatic retries
when a 403 Forbidden status is received, in compliance with RFC 9110 guidelines.
According to [RFC
arturobernalg commented on PR #489:
URL:
https://github.com/apache/httpcomponents-client/pull/489#issuecomment-1738120965
Please @reschke take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ok2c closed pull request #433: HTTPCORE-758-Fix exception handling when
creating IO Dispatchers
URL: https://github.com/apache/httpcomponents-core/pull/433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ok2c commented on PR #433:
URL:
https://github.com/apache/httpcomponents-core/pull/433#issuecomment-1735615374
@karthik-119 Corrected by a5c117028b7c620974304636d52f06f172f1d08b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ok2c merged PR #438:
URL: https://github.com/apache/httpcomponents-core/pull/438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c commented on PR #491:
URL:
https://github.com/apache/httpcomponents-client/pull/491#issuecomment-1745073739
@arturobernalg Please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ok2c opened a new pull request, #491:
URL: https://github.com/apache/httpcomponents-client/pull/491
* `ResponseCachingPolicy` optimized to generate less intermediate garbage
while paring `Via` headers
* `Via` request and response header generation moved from the caching exec
ok2c merged PR #490:
URL: https://github.com/apache/httpcomponents-client/pull/490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Marcono1234 commented on PR #490:
URL:
https://github.com/apache/httpcomponents-client/pull/490#issuecomment-1745324354
Have pushed the changes, I hope that is what you had in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ok2c commented on code in PR #438:
URL:
https://github.com/apache/httpcomponents-core/pull/438#discussion_r1344326091
##
httpcore5/src/main/java/org/apache/hc/core5/ssl/TrustStrategy.java:
##
@@ -34,6 +34,19 @@
* configured in the actual SSL context. This interface can be
Marcono1234 commented on code in PR #438:
URL:
https://github.com/apache/httpcomponents-core/pull/438#discussion_r1344299429
##
httpcore5/src/main/java/org/apache/hc/core5/ssl/TrustStrategy.java:
##
@@ -34,6 +34,19 @@
* configured in the actual SSL context. This interface
101 - 200 of 1238 matches
Mail list logo
