[jira] [Commented] (HTTPCORE-536) duplicate connect method could be extract

[ https://issues.apache.org/jira/browse/HTTPCORE-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570120#comment-16570120 ] silver9886 commented on HTTPCORE-536: - understand > duplicate connect method could be extract >

[jira] [Commented] (HTTPCORE-536) duplicate connect method could be extract

[ https://issues.apache.org/jira/browse/HTTPCORE-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570097#comment-16570097 ] silver9886 commented on HTTPCORE-536: - why not say write the pr ... I thought you dont want to

[jira] [Updated] (HTTPCORE-536) duplicate connect method could be extract

[ https://issues.apache.org/jira/browse/HTTPCORE-536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] silver9886 updated HTTPCORE-536: Priority: Major (was: Minor) > duplicate connect method could be extract >

[jira] [Commented] (HTTPCLIENT-1928) HttpAsyncClient callback should ignore exception throwed by compelete method

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541323#comment-16541323 ] silver9886 commented on HTTPCLIENT-1928: why delete AbstractMinimalHttpAsyncClientBase.java

[jira] [Commented] (HTTPCORE-535) mod workerCount is power of two can be improved as &(workerCount-1)

[ https://issues.apache.org/jira/browse/HTTPCORE-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541317#comment-16541317 ] silver9886 commented on HTTPCORE-535: - of course & is faster than %. > mod workerCount is power of

[jira] [Created] (HTTPCORE-536) duplicate connect method could be extract

silver9886 created HTTPCORE-536: --- Summary: duplicate connect method could be extract Key: HTTPCORE-536 URL: https://issues.apache.org/jira/browse/HTTPCORE-536 Project: HttpComponents HttpCore

[jira] [Created] (HTTPCORE-535) mod workerCount is power of two can be improved as &(workerCount-1)

silver9886 created HTTPCORE-535: --- Summary: mod workerCount is power of two can be improved as &(workerCount-1) Key: HTTPCORE-535 URL: https://issues.apache.org/jira/browse/HTTPCORE-535 Project:

[jira] [Commented] (HTTPCLIENT-1928) HttpAsyncClient callback should ignore exception throwed by compelete method

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538663#comment-16538663 ] silver9886 commented on HTTPCLIENT-1928: you can log the exception in the framework ,the

[jira] [Created] (HTTPCORE-532) IOReactor thread should be lazy started

silver9886 created HTTPCORE-532: --- Summary: IOReactor thread should be lazy started Key: HTTPCORE-532 URL: https://issues.apache.org/jira/browse/HTTPCORE-532 Project: HttpComponents HttpCore

[jira] [Created] (HTTPCLIENT-1928) HttpAsyncClient callback should ignore exception throwed by compelete method

silver9886 created HTTPCLIENT-1928: -- Summary: HttpAsyncClient callback should ignore exception throwed by compelete method Key: HTTPCLIENT-1928 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1928

[jira] [Commented] (HTTPCORE-518) Improve buffer allocation

[ https://issues.apache.org/jira/browse/HTTPCORE-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533473#comment-16533473 ] silver9886 commented on HTTPCORE-518: - perhaps newcapacity = ((this.buffer.capacity() + 1) * 5) >>

[jira] [Commented] (HTTPCORE-489) sometimes unit test will failed

[ https://issues.apache.org/jira/browse/HTTPCORE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156669#comment-16156669 ] silver9886 commented on HTTPCORE-489: - I find these bug when write the code to fix the HTTPCORE-484.

[jira] [Commented] (HTTPCORE-489) sometimes unit test will failed

[ https://issues.apache.org/jira/browse/HTTPCORE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156281#comment-16156281 ] silver9886 commented on HTTPCORE-489: - why don't give me a chance to raise a pr :( > sometimes unit

[jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

[ https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155424#comment-16155424 ] silver9886 commented on HTTPCORE-488: - you are right ! your change is execlent，I ignore the super

[jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

[ https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155385#comment-16155385 ] silver9886 commented on HTTPCORE-488: - I think we have to discuss about it. In the pr,

[jira] [Commented] (HTTPCORE-489) sometimes unit test will failed

[ https://issues.apache.org/jira/browse/HTTPCORE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155125#comment-16155125 ] silver9886 commented on HTTPCORE-489: - Is it a bug? > sometimes unit test will failed >

[jira] [Created] (HTTPCORE-489) sometimes unit test will failed

silver9886 created HTTPCORE-489: --- Summary: sometimes unit test will failed Key: HTTPCORE-489 URL: https://issues.apache.org/jira/browse/HTTPCORE-489 Project: HttpComponents HttpCore Issue

[jira] [Created] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

silver9886 created HTTPCORE-488: --- Summary: SingleCoreIOReactor.connect methods timeout parameter do not have effect. Key: HTTPCORE-488 URL: https://issues.apache.org/jira/browse/HTTPCORE-488 Project:

[jira] [Commented] (HTTPCORE-486) SingleCoreIOReactor.processPendingChannels and processPendingConnectionRequests should setting time limit

[ https://issues.apache.org/jira/browse/HTTPCORE-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145427#comment-16145427 ] silver9886 commented on HTTPCORE-486: - please see

[jira] [Created] (HTTPCORE-486) SingleCoreIOReactor.processPendingChannels and processPendingConnectionRequests should setting time limit

silver9886 created HTTPCORE-486: --- Summary: SingleCoreIOReactor.processPendingChannels and processPendingConnectionRequests should setting time limit Key: HTTPCORE-486 URL:

[jira] [Comment Edited] (HTTPCORE-484) check timeout could use TimeWheel algorithm

[ https://issues.apache.org/jira/browse/HTTPCORE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143028#comment-16143028 ] silver9886 edited comment on HTTPCORE-484 at 8/27/17 8:34 AM: -- please give

[jira] [Comment Edited] (HTTPCORE-484) check timeout could use TimeWheel algorithm

[ https://issues.apache.org/jira/browse/HTTPCORE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143028#comment-16143028 ] silver9886 edited comment on HTTPCORE-484 at 8/27/17 8:27 AM: -- please give

[jira] [Comment Edited] (HTTPCORE-484) check timeout could use TimeWheel algorithm

[ https://issues.apache.org/jira/browse/HTTPCORE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143028#comment-16143028 ] silver9886 edited comment on HTTPCORE-484 at 8/27/17 7:56 AM: -- please give

[jira] [Commented] (HTTPCORE-484) check timeout could use TimeWheel algorithm

[ https://issues.apache.org/jira/browse/HTTPCORE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143028#comment-16143028 ] silver9886 commented on HTTPCORE-484: - please give the git url I should fork.fork from

[jira] [Commented] (HTTPCORE-484) check timeout could use TimeWheel algorithm

[ https://issues.apache.org/jira/browse/HTTPCORE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142507#comment-16142507 ] silver9886 commented on HTTPCORE-484: - thank you very much! I would like to do it very much !!! I

[jira] [Created] (HTTPCORE-484) check timeout could use TimeWheel algorithm

silver9886 created HTTPCORE-484: --- Summary: check timeout could use TimeWheel algorithm Key: HTTPCORE-484 URL: https://issues.apache.org/jira/browse/HTTPCORE-484 Project: HttpComponents HttpCore

[jira] [Commented] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1648#comment-1648 ] silver9886 commented on HTTPCORE-480: - thank you ,I understand how the nio select works. but the

[jira] [Commented] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1608#comment-1608 ] silver9886 commented on HTTPCORE-480: - you are right.so i change the source code as follows:

[jira] [Commented] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1602#comment-1602 ] silver9886 commented on HTTPCORE-480: - set selectTimeout = timeoutCheckInterval in the code is not a

[jira] [Comment Edited] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111089#comment-16111089 ] silver9886 edited comment on HTTPCORE-480 at 8/2/17 3:19 PM: - you don't konw

[jira] [Commented] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111089#comment-16111089 ] silver9886 commented on HTTPCORE-480: - you don't konw what i mean. I don't want to reduce

[jira] [Reopened] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] silver9886 reopened HTTPCORE-480: - so if currentTime - this.lastTimeoutCheck) < this.timeoutCheckInterval +

[jira] [Commented] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110943#comment-16110943 ] silver9886 commented on HTTPCORE-480: - because timeoutCheckInterval = timeoutCheckInterval in the

[jira] [Commented] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110906#comment-16110906 ] silver9886 commented on HTTPCORE-480: - so if currentTime - this.lastTimeoutCheck) <

[jira] [Commented] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110883#comment-16110883 ] silver9886 commented on HTTPCORE-480: - the new idea is this(i upload the diff png) : add a protected

[jira] [Updated] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] silver9886 updated HTTPCORE-480: Attachment: AbstractIOReactor-change.png BaseIOReactor-change.png

[jira] [Updated] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] silver9886 updated HTTPCORE-480: Attachment: (was: BaseIOReactor.java) > improve the code in check timeout >

[jira] [Updated] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] silver9886 updated HTTPCORE-480: Attachment: (was: AbstractIOReactor.java) > improve the code in check timeout >

[jira] [Comment Edited] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110833#comment-16110833 ] silver9886 edited comment on HTTPCORE-480 at 8/2/17 1:14 PM: - the new idea

[jira] [Updated] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] silver9886 updated HTTPCORE-480: Priority: Major (was: Trivial) > improve the code in check timeout >

[jira] [Commented] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110833#comment-16110833 ] silver9886 commented on HTTPCORE-480: - when return from readyCount =

[jira] [Updated] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] silver9886 updated HTTPCORE-480: Attachment: AbstractIOReactor.java BaseIOReactor.java > improve the code in check

[jira] [Updated] (HTTPCORE-480) improve the code in check timeout

[ https://issues.apache.org/jira/browse/HTTPCORE-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] silver9886 updated HTTPCORE-480: Attachment: (was: BaseIOReactor.java) > improve the code in check timeout >

[jira] [Created] (HTTPCORE-480) improve the code in check timeout

silver9886 created HTTPCORE-480: --- Summary: improve the code in check timeout Key: HTTPCORE-480 URL: https://issues.apache.org/jira/browse/HTTPCORE-480 Project: HttpComponents HttpCore Issue