[GitHub] httpcomponents-core pull request #69: HTTPCORE-535

2018-07-19 Thread xiaohu-zhang
Github user xiaohu-zhang closed the pull request at: https://github.com/apache/httpcomponents-core/pull/69 --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpcomponents-core pull request #68: HTTPCORE-532

2018-07-19 Thread xiaohu-zhang
Github user xiaohu-zhang closed the pull request at: https://github.com/apache/httpcomponents-core/pull/68 --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpcomponents-core issue #67: HTTPCORE-484 use TimeWheel algorithm to deal ...

2018-07-13 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/67 1. yes,all the time out task is executed by a separate thread. but I dont think IOEventHandler need to synchronization because every channel has difference IOEventHandler instance

[GitHub] httpcomponents-core pull request #69: HTTPCORE-535

2018-07-12 Thread xiaohu-zhang
GitHub user xiaohu-zhang opened a pull request: https://github.com/apache/httpcomponents-core/pull/69 HTTPCORE-535 if workerCount is power of two , use &(workerCount -1 ) achieve mod workerCount funciton You can merge this pull request into a Git repository by run

[GitHub] httpcomponents-client issue #106: HTTPCLIENT-1928

2018-07-12 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-client/pull/106 thank you --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h

[GitHub] httpcomponents-client pull request #106: HTTPCLIENT-1928

2018-07-12 Thread xiaohu-zhang
Github user xiaohu-zhang closed the pull request at: https://github.com/apache/httpcomponents-client/pull/106 --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h

[GitHub] httpcomponents-core issue #67: HTTPCORE-484 use TimeWheel algorithm to deal ...

2018-07-11 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/67 1. testTimeoutInSSecond method in class TestHashedWheelTimer should rename to testTimeoutInSecond ,I dont have permission to push to your branch. 2.why delete if (isWindows

[GitHub] httpcomponents-client pull request #106: HTTPCLIENT-1928

2018-07-11 Thread xiaohu-zhang
GitHub user xiaohu-zhang opened a pull request: https://github.com/apache/httpcomponents-client/pull/106 HTTPCLIENT-1928 warning:IgnoreCompelteExceptonFutureCallback should be in org.apache.hc.core5.concurrent package in httpcore5 project.put here just for pass the cli check

[GitHub] httpcomponents-core issue #68: HTTPCORE-532

2018-07-10 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/68 yes.it has a little useful only when connections less than worker thread,and is not anticipate by user before. just tiny improvement

[GitHub] httpcomponents-core issue #68: HTTPCORE-532

2018-07-10 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/68 what if can not anticipate ?lazy init is little useful in performance。Also the code can be modified do not use instanceof .after all , it depends on you

[GitHub] httpcomponents-core issue #68: HTTPCORE-532

2018-07-10 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/68 when use few connections,for example ,use always one connection in connection pool each time(), or no http connection used when project started.framework can use less thread

[GitHub] httpcomponents-core issue #68: HTTPCORE-532

2018-07-10 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/68 there is somthing wrong with the code ,let me correct it first --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] httpcomponents-core pull request #68: HTTPCORE-532

2018-07-09 Thread xiaohu-zhang
GitHub user xiaohu-zhang opened a pull request: https://github.com/apache/httpcomponents-core/pull/68 HTTPCORE-532 IOReactor thread can be lazy started You can merge this pull request into a Git repository by running: $ git pull https://github.com/xiaohu-zhang/httpcomponents

[GitHub] httpcomponents-core issue #67: HTTPCORE-484 use TimeWheel algorithm to deal ...

2018-07-05 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/67 that is ok.Look forward to your reply.If anything wrong,let me know.If license is not ok,I can write it by my self

[GitHub] httpcomponents-core pull request #67: HTTPCORE-484 use TimeWheel algorithm t...

2018-07-04 Thread xiaohu-zhang
GitHub user xiaohu-zhang opened a pull request: https://github.com/apache/httpcomponents-core/pull/67 HTTPCORE-484 use TimeWheel algorithm to deal with time out HashedWheelTimer and related util classes are copied from netty framework with tiny changes. You can merge this pull

[GitHub] httpcomponents-core issue #66: Use TimeWheel algorithm instead of loop when ...

2018-07-04 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/66 I wil try to solve it and pass ut then pr --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org

[GitHub] httpcomponents-core pull request #66: Use TimeWheel algorithm instead of loo...

2018-07-04 Thread xiaohu-zhang
Github user xiaohu-zhang closed the pull request at: https://github.com/apache/httpcomponents-core/pull/66 --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpcomponents-core issue #66: Use TimeWheel algorithm instead of loop when ...

2018-07-03 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/66 thank you,you are so kind. but there also lots of checksytle bugs in the pr. It is not ok to waste your time to cover for me。I will try to solve it tomorrow. thank you very

[GitHub] httpcomponents-core issue #66: Use TimeWheel algorithm instead of loop when ...

2018-07-03 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/66 I don't familiar with git and github.Please help me ,thank you very much,thank you !! when at TimeWheel branch ,I use git rebase master ,there will be a lot of conflict

[GitHub] httpcomponents-core issue #66: Use TimeWheel algorithm instead of loop when ...

2018-07-03 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/66 should I use command : git rebase -i HEAD~99 and deal with the conflict? --- - To unsubscribe, e-mail: dev

[GitHub] httpcomponents-core pull request #66: Use TimeWheel algorithm instead of loo...

2018-07-03 Thread xiaohu-zhang
GitHub user xiaohu-zhang opened a pull request: https://github.com/apache/httpcomponents-core/pull/66 Use TimeWheel algorithm instead of loop when check timeout HashedWheelTimer and related util classes are copied from netty framework with tiny changes. use TimeWheel algorithm

[GitHub] httpcomponents-core issue #51: Check connecttimeout when SelectionKey.OP_CON...

2017-09-06 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/51 thank you --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h

[GitHub] httpcomponents-core pull request #51: Check connecttimeout when SelectionKey...

2017-09-06 Thread xiaohu-zhang
Github user xiaohu-zhang closed the pull request at: https://github.com/apache/httpcomponents-core/pull/51 --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpcomponents-core pull request #51: Check connecttimeout when SelectionKey...

2017-09-06 Thread xiaohu-zhang
GitHub user xiaohu-zhang opened a pull request: https://github.com/apache/httpcomponents-core/pull/51 Check connecttimeout when SelectionKey.OP_CONNECT event happend related to HTTPCORE-488 InternalConnectChannel onTimeout should also invoke close method You can merge this pull

[GitHub] httpcomponents-core pull request #50: setting time limit on processPending m...

2017-09-02 Thread xiaohu-zhang
Github user xiaohu-zhang closed the pull request at: https://github.com/apache/httpcomponents-core/pull/50 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] httpcomponents-core issue #50: setting time limit on processPending methods

2017-09-02 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/50 thank you,the commit is ok to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] httpcomponents-core issue #50: setting time limit on processPending methods

2017-08-29 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/50 this change is not related to HTTPCORE-484 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] httpcomponents-core issue #50: setting time limit on processPending methods

2017-08-29 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/50 It is the change related to HTTPCORE-486.10 is an arbitrary value.In my test ,loop 10 times will take less than 3ms usually. 10 is also the value netty used

[GitHub] httpcomponents-core pull request #50: setting time limit on processPending m...

2017-08-29 Thread xiaohu-zhang
GitHub user xiaohu-zhang opened a pull request: https://github.com/apache/httpcomponents-core/pull/50 setting time limit on processPending methods setting time limit to avoid the SingleCoreIOReactor's time be exhausted and then block the remaining work to do. You can merge