Re: [HttpCore5] GracefullyCloseable: Not the best method or interface name

2018-07-12 Thread Gary Gregory
On Thu, Jul 12, 2018 at 3:09 AM Oleg Kalnichevski wrote: > Gary, > > How about that? > > > https://github.com/ok2c/httpcore/commit/b922161b9776672c89bd8df2ce0757de143a15e4 > > https://github.com/ok2c/httpcore/commit/fff078122075d5ab6249e247b5b71e23422be768 +1 :-) Much better IMO. Gary > > > O

Re: [HttpCore5] GracefullyCloseable: Not the best method or interface name

2018-07-12 Thread Oleg Kalnichevski
Gary, How about that? https://github.com/ok2c/httpcore/commit/b922161b9776672c89bd8df2ce0757de143a15e4 https://github.com/ok2c/httpcore/commit/fff078122075d5ab6249e247b5b71e23422be768 Oleg On Wed, 2018-07-11 at 23:16 +0200, Oleg Kalnichevski wrote: > On Wed, 2018-07-11 at 09:57 -0600, Gary Gre

Re: [HttpCore5] GracefullyCloseable: Not the best method or interface name

2018-07-11 Thread Oleg Kalnichevski
On Wed, 2018-07-11 at 09:57 -0600, Gary Gregory wrote: > Hi All: > > I think naming things as best we can is important, so I'd like to > talk > about the following. > > We have in HttpCore 5: > > package org.apache.hc.core5.io; > > import java.io.Closeable; > > /** >  * Process or endpoint tha

[HttpCore5] GracefullyCloseable: Not the best method or interface name

2018-07-11 Thread Gary Gregory
Hi All: I think naming things as best we can is important, so I'd like to talk about the following. We have in HttpCore 5: package org.apache.hc.core5.io; import java.io.Closeable; /** * Process or endpoint that can be gracefully closed. * * @since 5.0 */ public interface GracefullyCloseab