Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/266#discussion_r226866903
--- Diff: designs/aggregated-cluster-view/design.md ---
@@ -0,0 +1,353 @@
+Aggregated Cluster View Design
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/248
what is the purpose of this api and what will the caller do with the return
value?
---
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/169#discussion_r177523538
--- Diff:
helix-core/src/main/java/org/apache/helix/common/caches/BasicClusterDataCache.java
---
@@ -104,6 +108,52 @@ public void refresh(HelixDataAccessor
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/169#discussion_r177523236
--- Diff:
helix-core/src/main/java/org/apache/helix/common/caches/BasicClusterDataCache.java
---
@@ -104,6 +108,52 @@ public void refresh(HelixDataAccessor
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/169#discussion_r177522574
--- Diff:
helix-core/src/main/java/org/apache/helix/common/caches/BasicClusterDataCache.java
---
@@ -104,6 +108,52 @@ public void refresh(HelixDataAccessor
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/169#discussion_r177523148
--- Diff:
helix-core/src/main/java/org/apache/helix/common/caches/BasicClusterDataCache.java
---
@@ -104,6 +108,52 @@ public void refresh(HelixDataAccessor
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/169#discussion_r177522908
--- Diff:
helix-core/src/main/java/org/apache/helix/common/caches/BasicClusterDataCache.java
---
@@ -104,6 +108,52 @@ public void refresh(HelixDataAccessor
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/159#discussion_r177275969
--- Diff:
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java ---
@@ -257,18 +308,22 @@ public void run
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/159#discussion_r177260701
--- Diff:
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java ---
@@ -153,7 +195,12 @@ private void parseListenerProperties
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/159#discussion_r177274948
--- Diff:
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java ---
@@ -168,41 +215,41 @@ private void parseListenerProperties
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/159#discussion_r177257703
--- Diff:
helix-core/src/main/java/org/apache/helix/common/DedupEventBlockingQueue.java
---
@@ -0,0 +1,139 @@
+package org.apache.helix.common
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/159#discussion_r177260018
--- Diff:
helix-core/src/main/java/org/apache/helix/common/DedupEventBlockingQueue.java
---
@@ -0,0 +1,139 @@
+package org.apache.helix.common
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/155#discussion_r176172589
--- Diff:
helix-core/src/main/java/org/apache/helix/spectator/RoutingTableSnapshot.java
---
@@ -0,0 +1,151 @@
+package org.apache.helix.spectator
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/155#discussion_r176171189
--- Diff:
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java ---
@@ -576,8 +573,8 @@ public void handleDataChange(String dataPath
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/138#discussion_r171987248
--- Diff:
helix-core/src/test/java/org/apache/helix/TestListenerCallbackBatchMode.java ---
@@ -122,21 +131,45 @@ public void testNonBatchedListener() throws
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/138#discussion_r171987319
--- Diff:
helix-core/src/test/java/org/apache/helix/TestListenerCallbackBatchMode.java ---
@@ -122,21 +131,45 @@ public void testNonBatchedListener() throws
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/commit/bada911c7f246cf685c30323e118402cca89111d#commitcomment-26928342
In helix-core/src/main/java/org/apache/helix/GroupCommit.java:
In helix-core/src/main/java/org/apache/helix/GroupCommit.java
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/commit/bada911c7f246cf685c30323e118402cca89111d#commitcomment-26928170
In helix-core/src/main/java/org/apache/helix/GroupCommit.java:
In helix-core/src/main/java/org/apache/helix/GroupCommit.java
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/87#discussion_r116129454
--- Diff:
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
---
@@ -143,6 +145,7 @@ public HelixTaskExecutor
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/59
Any update on this PR. I think we are seeing similar issues in one of our
projects
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/82#discussion_r109814455
--- Diff:
helix-core/src/test/java/org/apache/helix/messaging/handling/TestResourceThreadpoolSize.java
---
@@ -113,6 +113,35 @@ public void
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/82#discussion_r109800436
--- Diff:
helix-core/src/test/java/org/apache/helix/messaging/handling/TestResourceThreadpoolSize.java
---
@@ -113,6 +113,35 @@ public void
GitHub user kishoreg opened a pull request:
https://github.com/apache/helix/pull/81
Creating a separate threadpool to handle batchMessages
batchMessages were using the same threadpool as sub tasks. This works as
long the thread pool size is greater than the number of messages
GitHub user kishoreg opened a pull request:
https://github.com/apache/helix/pull/78
Auto compress ZNode that are greater than 1MB
Previously, users had to explicitly set enableCompression=true in the
ZNRecord to enable compression. This meant that the users had to anticipate
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/77
I think it's a good idea to have one shared thread pool. Since we create
one callback per helix entity type (idealstate, external view), I thought this
is not a big overhead. One problem
GitHub user kishoreg opened a pull request:
https://github.com/apache/helix/pull/77
Adding support to batch ZK callback optionally by setting sys var asyâ¦
Supports batching of zk callbacks. Can be enabled optionally with a system
flag (asyncBatchModeEnabled=true).
In my
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/65#discussion_r95282034
--- Diff:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java ---
@@ -162,6 +162,20 @@ public InstanceConfig getInstanceConfig(String
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/65#discussion_r95281496
--- Diff:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java ---
@@ -162,6 +162,20 @@ public InstanceConfig getInstanceConfig(String
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/58
This should fix it. One scenario, where this will result in undesirable
output is when the entire cluster is restarted.
Let's day P was on NODE_0 and NODE_1, we paused the controller
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/49
this is great work Lei. Can you please paste the final mapping generated by
default strategy v/s crush method. Also when would one chose one over the other.
---
If your project is set up for it, you
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/49
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/49#discussion_r76988348
--- Diff:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/strategy/CrushRebalanceStrategy.java
---
@@ -0,0 +1,174 @@
+package
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/48
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/48
Got it. Will review this. Are you guys using 0.6.x or 0.7.x
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/48
@lei-xia can you also review this change. Subbu had a test case
https://issues.apache.org/jira/browse/HELIX-631. Will be good to see if this
change fixes that as well.
---
If your project is set up
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/48
this is awesome Greg, can you please create a separate PR for FULL_AUTO
bug. I will review the changes tonight.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/46
Lgtm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/44#issuecomment-221774907
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/41#issuecomment-209564520
Thanks, will apply the change today
On Wed, Apr 13, 2016 at 10:46 AM, Lei Xia <notificati...@github.com> wrote:
> Rebased to the head.
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/41#issuecomment-182482218
Will review this today
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/41#issuecomment-182487167
Looks good, please try to split the changes into smaller RB's. Its very
hard to review such a big RB. Can you address the RB comments. I will merge it
---
If your
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/41#discussion_r52488945
--- Diff:
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java.rej
---
@@ -0,0 +1,18 @@
+diff
a/helix-core/src
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/41#discussion_r52489589
--- Diff: helix-core/src/main/java/org/apache/helix/task/JobRebalancer.java
---
@@ -206,9 +205,23 @@ private ResourceAssignment
computeResourceMapping(String
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/43#issuecomment-172105093
Is this intended to be used via curl or via java api?.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/43#issuecomment-172126774
Then a better api, is to provide a Filter api right.
similar to File.list(dir, FileNameFilter) we can have a MessageSendFilter
which has accept method that returns
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/42#issuecomment-171563196
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/36#issuecomment-170707954
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/38#issuecomment-154778932
LGTM. Any test case to ensure that there is no leak?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/35#issuecomment-138792278
This is an interesting change, why cant we do this on the client side? If
you have the reference to StateModelFactory, you can call the shutdown method
on each and every
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/34#issuecomment-138783773
Thanks LGTM. Will apply the patch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/34#issuecomment-138435680
Looks good, can you add a simple test case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/32#discussion_r35688508
--- Diff:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java ---
@@ -645,7 +645,7 @@ public boolean isLeader
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/33#issuecomment-122676485
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/31#discussion_r33882177
--- Diff: helix-core/src/main/java/org/apache/helix/model/IdealState.java
---
@@ -536,4 +574,16 @@ public boolean isEnabled() {
public void enable
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/31#discussion_r33881174
--- Diff:
helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
---
@@ -73,6 +75,73 @@ public RoutingTableProvider
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/31#discussion_r33881022
--- Diff:
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
---
@@ -127,7 +127,9 @@ public void process(ClusterEvent
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/31#discussion_r33881054
--- Diff:
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
---
@@ -190,7 +192,8 @@ public void process(ClusterEvent
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/31#discussion_r33881099
--- Diff: helix-core/src/main/java/org/apache/helix/model/IdealState.java
---
@@ -55,7 +55,9 @@
MAX_PARTITIONS_PER_INSTANCE
58 matches
Mail list logo
