[GitHub] [helix] jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#issuecomment-517892944 This PR is ready to be merged, approved by @narendly. I will do the merge.

[GitHub] [helix] jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#issuecomment-517854427 Thanks for your hard work of reviewing. I know it is a huge PR. Mainly because it is new classes that are built from scratch, even

[GitHub] [helix] jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation

2019-08-01 Thread GitBox
jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#issuecomment-517151234 @i3wangyi Thanks for the comments. For the general comments, I'm trying to answer here. > You could just have a blank method

[GitHub] [helix] jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation

2019-07-29 Thread GitBox
jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#issuecomment-516210666 Thanks for the comments, I have addressed most of them today. I will work on the tests and re-construct the commits before converting