[GitHub] helix pull request #152: [HELIX-681] don't fail state transition task if we ...

2018-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/helix/pull/152 ---

[GitHub] helix pull request #152: [HELIX-681] don't fail state transition task if we ...

2018-03-21 Thread zhan849
Github user zhan849 commented on a diff in the pull request: https://github.com/apache/helix/pull/152#discussion_r176204863 --- Diff: helix-core/src/main/java/org/apache/helix/util/HelixUtil.java --- @@ -219,4 +220,22 @@ public static String serializeByComma(List objects) {

[GitHub] helix pull request #152: [HELIX-681] don't fail state transition task if we ...

2018-03-21 Thread zhan849
Github user zhan849 commented on a diff in the pull request: https://github.com/apache/helix/pull/152#discussion_r176182830 --- Diff: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTask.java --- @@ -168,7 +169,14 @@ public HelixTaskResult call() {

[GitHub] helix pull request #152: [HELIX-681] don't fail state transition task if we ...

2018-03-21 Thread lei-xia
Github user lei-xia commented on a diff in the pull request: https://github.com/apache/helix/pull/152#discussion_r176143399 --- Diff: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTask.java --- @@ -168,7 +169,14 @@ public HelixTaskResult call() {

[GitHub] helix pull request #152: [HELIX-681] don't fail state transition task if we ...

2018-03-21 Thread lei-xia
Github user lei-xia commented on a diff in the pull request: https://github.com/apache/helix/pull/152#discussion_r176144284 --- Diff: helix-core/src/main/java/org/apache/helix/util/HelixUtil.java --- @@ -219,4 +220,22 @@ public static String serializeByComma(List objects) {

[GitHub] helix pull request #152: [HELIX-681] don't fail state transition task if we ...

2018-03-19 Thread zhan849
GitHub user zhan849 opened a pull request: https://github.com/apache/helix/pull/152 [HELIX-681] don't fail state transition task if we fail to remove message or send out relay message This PR includes fix on participant side: 1. Consolidated message deletion logic to HelixUtil,