[jira] [Commented] (HELIX-342) Set info field in current-state only if it's not empty
[ https://issues.apache.org/jira/browse/HELIX-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086525#comment-14086525 ] Kanak Biscuitwala commented on HELIX-342: - This may not be a big deal because it's just an added simple field to a delta that is already updated with ZK on every state transition. So the added latency is just the CPU time of setting that simple field. We can leave this open, but if we actually want to do this, we would need to separate set to null from actually removing the info field. Set info field in current-state only if it's not empty -- Key: HELIX-342 URL: https://issues.apache.org/jira/browse/HELIX-342 Project: Apache Helix Issue Type: Sub-task Reporter: Zhen Zhang Assignee: Zhen Zhang task framework uses an additional info field in the current-state. the default value is an empty string. we may not set it if it is empty. In HelixStateTransitionHandler#postHandleMessage() _currentStateDelta.setInfo(partitionId, taskResult.getInfo()); this is a perf concern instead of correctness -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Review Request 24266: [HELIX-495] Make TestPreferenceListAsQueue non-flaky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24266/#review49627 --- Ship it! Ship It! - Zhen Zhang On Aug. 4, 2014, 9:44 p.m., Kanak Biscuitwala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24266/ --- (Updated Aug. 4, 2014, 9:44 p.m.) Review request for helix, Zhen Zhang and Kishore Gopalakrishna. Bugs: HELIX-495 Repository: helix-git Description --- commit 8ba16a8e26103ebddc04ab57cbac81b5226d6788 Author: Kanak Biscuitwala ka...@apache.org Date: Mon Aug 4 14:43:05 2014 -0700 [HELIX-495] Make TestPreferenceListAsQueue non-flaky :100644 100644 06a2b56... f9c2d47... M helix-core/src/test/java/org/apache/helix/integration/TestPreferenceListAsQueue.java Diffs - helix-core/src/test/java/org/apache/helix/integration/TestPreferenceListAsQueue.java 06a2b56 Diff: https://reviews.apache.org/r/24266/diff/ Testing --- Thanks, Kanak Biscuitwala
[jira] [Created] (HELIX-496) Remove Dummy/Mock/Example HelixParticipant/Controller/MultiClusterController code duplication in test
Zhen Zhang created HELIX-496: Summary: Remove Dummy/Mock/Example HelixParticipant/Controller/MultiClusterController code duplication in test Key: HELIX-496 URL: https://issues.apache.org/jira/browse/HELIX-496 Project: Apache Helix Issue Type: Sub-task Reporter: Zhen Zhang -- This message was sent by Atlassian JIRA (v6.2#6252)
Review Request 24332: [HELIX-484] Remove CallbackHandler/ZkCallbackHandler code duplication, [HELIX-486] Remove StateModelFactory/HelixStateModelFactory code duplication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24332/ --- Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. Bugs: HELIX-484 and HELIX-486 Repository: helix-git Description --- Remove CallbackHandler/ZkCallbackHandler code duplication Remove StateModelFactory/HelixStateModelFactory code duplication Diffs - helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetInstance.java a9ecaa0 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetResource.java a54b0a3 helix-core/src/main/java/org/apache/helix/api/id/StateModelDefId.java 7c84f0f helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java 6aa3ab9 helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java af50eb7 helix-core/src/main/java/org/apache/helix/messaging/handling/HelixStateTransitionHandler.java 1bb6506 helix-core/src/main/java/org/apache/helix/participant/CustomCodeInvoker.java 6c96629 helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerStateModelFactory.java a367c81 helix-core/src/main/java/org/apache/helix/participant/GenericLeaderStandbyModel.java 3866cf5 helix-core/src/main/java/org/apache/helix/participant/GenericLeaderStandbyStateModelFactory.java 51c91cc helix-core/src/main/java/org/apache/helix/participant/HelixCustomCodeRunner.java 2f169cc helix-core/src/main/java/org/apache/helix/participant/HelixStateMachineEngine.java 95afb70 helix-core/src/main/java/org/apache/helix/participant/StateMachineEngine.java abb7d81 helix-core/src/main/java/org/apache/helix/participant/statemachine/ScheduledTaskStateModel.java ca67d42 helix-core/src/main/java/org/apache/helix/participant/statemachine/ScheduledTaskStateModelFactory.java a205910 helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 6599b33 helix-core/src/test/java/org/apache/helix/DummyProcessThread.java f51aa1d helix-core/src/test/java/org/apache/helix/TestHelixTaskExecutor.java a3b16e5 helix-core/src/test/java/org/apache/helix/TestHelixTaskHandler.java 43b4407 helix-core/src/test/java/org/apache/helix/TestHelper.java 879e727 helix-core/src/test/java/org/apache/helix/integration/TestAddStateModelFactoryAfterConnect.java 5f37845 helix-core/src/test/java/org/apache/helix/integration/TestBatchMessageWrapper.java 6a6837a helix-core/src/test/java/org/apache/helix/integration/TestErrorPartition.java 19af9a7 helix-core/src/test/java/org/apache/helix/integration/TestMessageThrottle2.java 496a16f helix-core/src/test/java/org/apache/helix/integration/TestMessagingService.java 08954e5 helix-core/src/test/java/org/apache/helix/integration/TestMultiClusterController.java c2f9a5c helix-core/src/test/java/org/apache/helix/integration/TestNonOfflineInitState.java 105633a helix-core/src/test/java/org/apache/helix/integration/TestPartitionLevelTransitionConstraint.java 823a9ce helix-core/src/test/java/org/apache/helix/integration/TestPreferenceListAsQueue.java 06a2b56 helix-core/src/test/java/org/apache/helix/integration/TestResetInstance.java 5804744 helix-core/src/test/java/org/apache/helix/integration/TestResetPartitionState.java 4855b3d helix-core/src/test/java/org/apache/helix/integration/TestResetResource.java 7d28931 helix-core/src/test/java/org/apache/helix/integration/TestSchedulerMessage.java 89af602 helix-core/src/test/java/org/apache/helix/integration/TestStateTransitionTimeout.java c4304b0 helix-core/src/test/java/org/apache/helix/integration/TestZkReconnect.java 18f6fd7 helix-core/src/test/java/org/apache/helix/integration/manager/TestConsecutiveZkSessionExpiry.java 99986ef helix-core/src/test/java/org/apache/helix/integration/manager/TestHelixMultiClusterController.java 18234b5 helix-core/src/test/java/org/apache/helix/integration/manager/TestParticipantManager.java 309ab18 helix-core/src/test/java/org/apache/helix/integration/manager/TestStateModelLeak.java d6d7bab helix-core/src/test/java/org/apache/helix/manager/zk/MockMultiClusterController.java 7f8b1a3 helix-core/src/test/java/org/apache/helix/manager/zk/MockParticipant.java f107d3d helix-core/src/test/java/org/apache/helix/manager/zk/TestDefaultControllerMsgHandlerFactory.java 8b5b30c helix-core/src/test/java/org/apache/helix/messaging/TestAsyncCallbackSvc.java da686fe helix-core/src/test/java/org/apache/helix/mock/participant/DummyProcess.java 9880605 helix-core/src/test/java/org/apache/helix/mock/participant/MockBootstrapModelFactory.java 177e7c4 helix-core/src/test/java/org/apache/helix/mock/participant/MockMSModelFactory.java 9325934 helix-core/src/test/java/org/apache/helix/mock/participant/MockSchemataModelFactory.java 525e764
Re: Review Request 24332: [HELIX-484] Remove CallbackHandler/ZkCallbackHandler code duplication, [HELIX-486] Remove StateModelFactory/HelixStateModelFactory code duplication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24332/#review49630 --- Instead of adding HelixStateModelFactory can we rename this class to StateTransitionHandlerFactory and StateModel to TransitionHandler and move it to api? Adding Helix prefix will create more confusion. helix-core/src/main/java/org/apache/helix/participant/HelixStateMachineEngine.java https://reviews.apache.org/r/24332/#comment86879 what is the equivalent of removing statemodel helix-core/src/main/java/org/apache/helix/participant/StateMachineEngine.java https://reviews.apache.org/r/24332/#comment86880 so we are breaking backwards compatibility? - Kishore Gopalakrishna On Aug. 5, 2014, 6:52 p.m., Zhen Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24332/ --- (Updated Aug. 5, 2014, 6:52 p.m.) Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. Bugs: HELIX-484 and HELIX-486 Repository: helix-git Description --- Remove CallbackHandler/ZkCallbackHandler code duplication Remove StateModelFactory/HelixStateModelFactory code duplication Diffs - helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetInstance.java a9ecaa0 helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetResource.java a54b0a3 helix-core/src/main/java/org/apache/helix/api/id/StateModelDefId.java 7c84f0f helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java 6aa3ab9 helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java af50eb7 helix-core/src/main/java/org/apache/helix/messaging/handling/HelixStateTransitionHandler.java 1bb6506 helix-core/src/main/java/org/apache/helix/participant/CustomCodeInvoker.java 6c96629 helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerStateModelFactory.java a367c81 helix-core/src/main/java/org/apache/helix/participant/GenericLeaderStandbyModel.java 3866cf5 helix-core/src/main/java/org/apache/helix/participant/GenericLeaderStandbyStateModelFactory.java 51c91cc helix-core/src/main/java/org/apache/helix/participant/HelixCustomCodeRunner.java 2f169cc helix-core/src/main/java/org/apache/helix/participant/HelixStateMachineEngine.java 95afb70 helix-core/src/main/java/org/apache/helix/participant/StateMachineEngine.java abb7d81 helix-core/src/main/java/org/apache/helix/participant/statemachine/ScheduledTaskStateModel.java ca67d42 helix-core/src/main/java/org/apache/helix/participant/statemachine/ScheduledTaskStateModelFactory.java a205910 helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 6599b33 helix-core/src/test/java/org/apache/helix/DummyProcessThread.java f51aa1d helix-core/src/test/java/org/apache/helix/TestHelixTaskExecutor.java a3b16e5 helix-core/src/test/java/org/apache/helix/TestHelixTaskHandler.java 43b4407 helix-core/src/test/java/org/apache/helix/TestHelper.java 879e727 helix-core/src/test/java/org/apache/helix/integration/TestAddStateModelFactoryAfterConnect.java 5f37845 helix-core/src/test/java/org/apache/helix/integration/TestBatchMessageWrapper.java 6a6837a helix-core/src/test/java/org/apache/helix/integration/TestErrorPartition.java 19af9a7 helix-core/src/test/java/org/apache/helix/integration/TestMessageThrottle2.java 496a16f helix-core/src/test/java/org/apache/helix/integration/TestMessagingService.java 08954e5 helix-core/src/test/java/org/apache/helix/integration/TestMultiClusterController.java c2f9a5c helix-core/src/test/java/org/apache/helix/integration/TestNonOfflineInitState.java 105633a helix-core/src/test/java/org/apache/helix/integration/TestPartitionLevelTransitionConstraint.java 823a9ce helix-core/src/test/java/org/apache/helix/integration/TestPreferenceListAsQueue.java 06a2b56 helix-core/src/test/java/org/apache/helix/integration/TestResetInstance.java 5804744 helix-core/src/test/java/org/apache/helix/integration/TestResetPartitionState.java 4855b3d helix-core/src/test/java/org/apache/helix/integration/TestResetResource.java 7d28931 helix-core/src/test/java/org/apache/helix/integration/TestSchedulerMessage.java 89af602 helix-core/src/test/java/org/apache/helix/integration/TestStateTransitionTimeout.java c4304b0 helix-core/src/test/java/org/apache/helix/integration/TestZkReconnect.java 18f6fd7 helix-core/src/test/java/org/apache/helix/integration/manager/TestConsecutiveZkSessionExpiry.java 99986ef
Review Request 24335: [HELIX-422] Simplify single job creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24335/ --- Review request for helix, Zhen Zhang and Kishore Gopalakrishna. Bugs: HELIX-422 Repository: helix-git Description --- commit 5bc77ac195e91292ceb2fb3584dce7a98175a623 Author: Kanak Biscuitwala ka...@apache.org Date: Tue Aug 5 13:10:52 2014 -0700 [HELIX-422] Simplify single job creation This both augments the Java API to specify fully-built job configs, as well as reduce the confusion between the job configs and the command config maps they contain. :100644 100644 3f9ab41... 1dad5e4... M helix-core/src/main/java/org/apache/helix/task/JobConfig.java :100644 100644 1aa75d6... e1a96a8... M helix-core/src/main/java/org/apache/helix/task/TaskUtil.java :100644 100644 84680d3... 77a5ba7... M helix-core/src/main/java/org/apache/helix/task/Workflow.java :100644 100644 b5856b1... b7f20d1... M helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java :100644 100644 208480c... 2ce76c1... M helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancer.java :100644 100644 97b8c7e... 4e0d92a... M helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancerStopResume.java :100644 100644 921a5f9... 318673f... M helix-core/src/test/java/org/apache/helix/integration/task/WorkflowGenerator.java Diffs - helix-core/src/main/java/org/apache/helix/task/JobConfig.java 3f9ab41 helix-core/src/main/java/org/apache/helix/task/TaskUtil.java 1aa75d6 helix-core/src/main/java/org/apache/helix/task/Workflow.java 84680d3 helix-core/src/test/java/org/apache/helix/integration/task/TestIndependentTaskRebalancer.java b5856b1 helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancer.java 208480c helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancerStopResume.java 97b8c7e helix-core/src/test/java/org/apache/helix/integration/task/WorkflowGenerator.java 921a5f9 Diff: https://reviews.apache.org/r/24335/diff/ Testing --- Thanks, Kanak Biscuitwala
