[jira] [Commented] (HELIX-636) JobQueue capacity is full due to job not cleaned up

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HELIX-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603790#comment-15603790
 ] 

ASF GitHub Bot commented on HELIX-636:
--

Github user lei-xia commented on a diff in the pull request:

https://github.com/apache/helix/pull/55#discussion_r84815009
  
--- Diff: 
helix-core/src/test/java/org/apache/helix/integration/task/TestJobQueueCleanUp.java
 ---
@@ -0,0 +1,58 @@
+package org.apache.helix.integration.task;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.helix.TestHelper;
+import org.apache.helix.task.JobConfig;
+import org.apache.helix.task.JobQueue;
+import org.apache.helix.task.TaskState;
+import org.apache.helix.task.TaskUtil;
+import org.testng.Assert;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+
+import com.google.common.collect.ImmutableMap;
+
+public class TestJobQueueCleanUp extends TaskTestBase {
--- End diff --

let us use removeJobContext() in the taskUtil?


> JobQueue capacity is full due to job not cleaned up
> ---
>
> Key: HELIX-636
> URL: https://issues.apache.org/jira/browse/HELIX-636
> Project: Apache Helix
>  Issue Type: Bug
>  Components: helix-core
>Affects Versions: 0.6.4
>Reporter: Junkai Xue
>Assignee: Junkai Xue
> Fix For: 0.6.x
>
>
> Since JobQueue never cleans up the jobs in the final stage (FAILED, 
> COMPLETED, ABORTED), JobQueue will reach the capacity limit when jobs keep 
> adding in.
> Fix: Current fix will be adding an API in TaskDriver to clean up the final 
> statge.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HELIX-636) JobQueue capacity is full due to job not cleaned up

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HELIX-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603450#comment-15603450
 ] 

ASF GitHub Bot commented on HELIX-636:
--

GitHub user dasahcc opened a pull request:

https://github.com/apache/helix/pull/55

[HELIX-636] Add Java API and REST API for clean up JobQueue

Since JobQueue never cleans up the jobs in the final stage (FAILED, 
COMPLETED, ABORTED), JobQueue will reach the capacity limit when jobs keep 
adding in.

1. Current fix will be adding an API in TaskDriver to clean up the final 
statge. To clean up the jobs in the final states, call the API cleanUpJobQueue()
2. As JobQueue is dynamic queue running, JobQueue should not be failed due 
to job failed threshold. Fix it with check whether failing due to other jobs 
fail is for JobQueue or generic workflow.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dasahcc/helix helix-0.6.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/helix/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #55


commit 927ad62eb17edeff255866c38d3b2aa7a4eb5da7
Author: Junkai Xue 
Date:   2016-10-24T22:34:29Z

Add Java API and REST API for clean up JobQueue

To clean up the jobs in the final states, provide a Java API and REST API 
in helix.




> JobQueue capacity is full due to job not cleaned up
> ---
>
> Key: HELIX-636
> URL: https://issues.apache.org/jira/browse/HELIX-636
> Project: Apache Helix
>  Issue Type: Bug
>  Components: helix-core
>Affects Versions: 0.6.4
>Reporter: Junkai Xue
>Assignee: Junkai Xue
> Fix For: 0.6.x
>
>
> Since JobQueue never cleans up the jobs in the final stage (FAILED, 
> COMPLETED, ABORTED), JobQueue will reach the capacity limit when jobs keep 
> adding in.
> Fix: Current fix will be adding an API in TaskDriver to clean up the final 
> statge.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)