Re: Review Request 24190: [HELIX-376] Remove HelixConnection/HelixManager duplicate code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24190/ --- (Updated Aug. 4, 2014, 8:10 p.m.) Review request for helix, Kanak Biscuitwala

Re: Review Request 24190: [HELIX-376] Remove HelixConnection/HelixManager duplicate code

On Aug. 1, 2014, 8:38 p.m., Kanak Biscuitwala wrote: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java, line 195 https://reviews.apache.org/r/24190/diff/1/?file=648666#file648666line195 It's unsafe to call HelixConnection#connect in a constructor. have to

Re: Review Request 24193: [HELIX-492] Task should have its own rebalance mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24193/#review49513 --- Ship it! Ship It! - Zhen Zhang On Aug. 1, 2014, 8:01 p.m.,

Review Request 24266: [HELIX-495] Make TestPreferenceListAsQueue non-flaky

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24266/ --- Review request for helix, Zhen Zhang and Kishore Gopalakrishna. Bugs:

[jira] [Commented] (HELIX-376) Remove HelixConnection/HelixManager duplicate code

[ https://issues.apache.org/jira/browse/HELIX-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085470#comment-14085470 ] Hudson commented on HELIX-376: -- SUCCESS: Integrated in helix #1277 (See

[jira] [Commented] (HELIX-492) Task should be its own rebalance mode

[ https://issues.apache.org/jira/browse/HELIX-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085469#comment-14085469 ] Hudson commented on HELIX-492: -- SUCCESS: Integrated in helix #1277 (See