[jira] [Commented] (HELIX-342) Set info field in current-state only if it's not empty

2014-08-05 Thread Kanak Biscuitwala (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086525#comment-14086525 ] Kanak Biscuitwala commented on HELIX-342: - This may not be a big deal because it's

Re: Review Request 24266: [HELIX-495] Make TestPreferenceListAsQueue non-flaky

2014-08-05 Thread Zhen Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24266/#review49627 --- Ship it! Ship It! - Zhen Zhang On Aug. 4, 2014, 9:44 p.m.,

[jira] [Created] (HELIX-496) Remove Dummy/Mock/Example HelixParticipant/Controller/MultiClusterController code duplication in test

2014-08-05 Thread Zhen Zhang (JIRA)
Zhen Zhang created HELIX-496: Summary: Remove Dummy/Mock/Example HelixParticipant/Controller/MultiClusterController code duplication in test Key: HELIX-496 URL: https://issues.apache.org/jira/browse/HELIX-496

Review Request 24332: [HELIX-484] Remove CallbackHandler/ZkCallbackHandler code duplication, [HELIX-486] Remove StateModelFactory/HelixStateModelFactory code duplication

2014-08-05 Thread Zhen Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24332/ --- Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. Bugs:

Re: Review Request 24332: [HELIX-484] Remove CallbackHandler/ZkCallbackHandler code duplication, [HELIX-486] Remove StateModelFactory/HelixStateModelFactory code duplication

2014-08-05 Thread Kishore Gopalakrishna
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24332/#review49630 --- Instead of adding HelixStateModelFactory can we rename this class

Review Request 24335: [HELIX-422] Simplify single job creation

2014-08-05 Thread Kanak Biscuitwala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24335/ --- Review request for helix, Zhen Zhang and Kishore Gopalakrishna. Bugs: