[GitHub] narendly opened a new pull request #301: Add markdown for quota-based scheduling

2019-02-10 Thread GitBox
narendly opened a new pull request #301: Add markdown for quota-based scheduling URL: https://github.com/apache/helix/pull/301 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] narendly opened a new pull request #302: HELIX: Fix null tgtSessionId message bug

2019-02-11 Thread GitBox
narendly opened a new pull request #302: HELIX: Fix null tgtSessionId message bug URL: https://github.com/apache/helix/pull/302 It has been reported that the Controller sometimes sends a message with a null tgtSessionId, which was causing an NPE on the Participant. Changelist: 1.

[GitHub] asfgit merged pull request #302: HELIX: Fix null tgtSessionId message bug

2019-02-12 Thread GitBox
asfgit merged pull request #302: HELIX: Fix null tgtSessionId message bug URL: https://github.com/apache/helix/pull/302 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] dasahcc commented on issue #301: Add markdown for quota-based scheduling

2019-02-12 Thread GitBox
dasahcc commented on issue #301: Add markdown for quota-based scheduling URL: https://github.com/apache/helix/pull/301#issuecomment-463028870 You may need to move this to 0.8.3 folder, since this feature is released out from 0.8.3. --

[GitHub] narendly commented on issue #301: Add markdown for quota-based scheduling

2019-02-12 Thread GitBox
narendly commented on issue #301: Add markdown for quota-based scheduling URL: https://github.com/apache/helix/pull/301#issuecomment-463036989 Thanks for noticing. I have moved it to 0.8.3 folder and removed from src. This is

[GitHub] dasahcc commented on a change in pull request #301: Add markdown for quota-based scheduling

2019-02-20 Thread GitBox
dasahcc commented on a change in pull request #301: Add markdown for quota-based scheduling URL: https://github.com/apache/helix/pull/301#discussion_r258744277 ## File path: website/0.8.3/src/site/markdown/quota_scheduling.md ## @@ -0,0 +1,181 @@ + + +# Quota-based Task Sc

[GitHub] dasahcc commented on a change in pull request #301: Add markdown for quota-based scheduling

2019-02-20 Thread GitBox
dasahcc commented on a change in pull request #301: Add markdown for quota-based scheduling URL: https://github.com/apache/helix/pull/301#discussion_r258743157 ## File path: website/0.8.3/src/site/markdown/quota_scheduling.md ## @@ -0,0 +1,181 @@ + + +# Quota-based Task Sc

[GitHub] narendly commented on a change in pull request #301: Add markdown for quota-based scheduling

2019-02-20 Thread GitBox
narendly commented on a change in pull request #301: Add markdown for quota-based scheduling URL: https://github.com/apache/helix/pull/301#discussion_r258758919 ## File path: website/0.8.3/src/site/markdown/quota_scheduling.md ## @@ -0,0 +1,181 @@ + + +# Quota-based Task S

[GitHub] narendly commented on a change in pull request #301: Add markdown for quota-based scheduling

2019-02-20 Thread GitBox
narendly commented on a change in pull request #301: Add markdown for quota-based scheduling URL: https://github.com/apache/helix/pull/301#discussion_r258758877 ## File path: website/0.8.3/src/site/markdown/quota_scheduling.md ## @@ -0,0 +1,181 @@ + + +# Quota-based Task S

[GitHub] asfgit merged pull request #301: Add markdown for quota-based scheduling

2019-02-21 Thread GitBox
asfgit merged pull request #301: Add markdown for quota-based scheduling URL: https://github.com/apache/helix/pull/301 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] narendly opened a new pull request #303: Add quota-based scheduling to tutorial

2019-02-21 Thread GitBox
narendly opened a new pull request #303: Add quota-based scheduling to tutorial URL: https://github.com/apache/helix/pull/303 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] asfgit merged pull request #303: Add quota-based scheduling to tutorial

2019-02-21 Thread GitBox
asfgit merged pull request #303: Add quota-based scheduling to tutorial URL: https://github.com/apache/helix/pull/303 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub a

[GitHub] narendly opened a new pull request #304: Add quota-based scheduling to tutorial

2019-02-21 Thread GitBox
narendly opened a new pull request #304: Add quota-based scheduling to tutorial URL: https://github.com/apache/helix/pull/304 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] asfgit merged pull request #304: Add quota-based scheduling to tutorial

2019-02-21 Thread GitBox
asfgit merged pull request #304: Add quota-based scheduling to tutorial URL: https://github.com/apache/helix/pull/304 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub a

[GitHub] narendly opened a new pull request #305: [HELIX-791] TASK2.0: Add RuntimeJobDag with job iterator functionality

2019-02-22 Thread GitBox
narendly opened a new pull request #305: [HELIX-791] TASK2.0: Add RuntimeJobDag with job iterator functionality URL: https://github.com/apache/helix/pull/305 Job list iterator methods and underlying data structure were added to JobDag to support retrieval of jobs by TaskDispatcher (to be i

[GitHub] narendly closed pull request #305: [HELIX-791] TASK2.0: Add RuntimeJobDag with job iterator functionality

2019-02-25 Thread GitBox
narendly closed pull request #305: [HELIX-791] TASK2.0: Add RuntimeJobDag with job iterator functionality URL: https://github.com/apache/helix/pull/305 This is an automated message from the Apache Git Service. To respond to

[GitHub] narendly opened a new pull request #306: [HELIX-791] TASK2.0: Add RuntimeJobDag with job iterator functionality

2019-02-25 Thread GitBox
narendly opened a new pull request #306: [HELIX-791] TASK2.0: Add RuntimeJobDag with job iterator functionality URL: https://github.com/apache/helix/pull/306 Job list iterator methods and underlying data structure were added to JobDag to support retrieval of jobs by TaskDispatcher (to be i

[GitHub] asfgit merged pull request #306: [HELIX-791] TASK2.0: Add RuntimeJobDag with job iterator functionality

2019-02-25 Thread GitBox
asfgit merged pull request #306: [HELIX-791] TASK2.0: Add RuntimeJobDag with job iterator functionality URL: https://github.com/apache/helix/pull/306 This is an automated message from the Apache Git Service. To respond to th

[GitHub] narendly opened a new pull request #307: Push2

2019-02-25 Thread GitBox
narendly opened a new pull request #307: Push2 URL: https://github.com/apache/helix/pull/307 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to g

[GitHub] asfgit merged pull request #307: Minor improvements

2019-02-25 Thread GitBox
asfgit merged pull request #307: Minor improvements URL: https://github.com/apache/helix/pull/307 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above

[GitHub] narendly opened a new pull request #308: Auto recovery maintenance feature

2019-02-26 Thread GitBox
narendly opened a new pull request #308: Auto recovery maintenance feature URL: https://github.com/apache/helix/pull/308 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHu

[GitHub] narendly closed pull request #308: Auto recovery maintenance feature

2019-02-26 Thread GitBox
narendly closed pull request #308: Auto recovery maintenance feature URL: https://github.com/apache/helix/pull/308 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] narendly opened a new pull request #309: Auto-recovery maintenance mode feature addition

2019-02-26 Thread GitBox
narendly opened a new pull request #309: Auto-recovery maintenance mode feature addition URL: https://github.com/apache/helix/pull/309 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] asfgit merged pull request #309: Auto-recovery maintenance mode feature addition

2019-02-26 Thread GitBox
asfgit merged pull request #309: Auto-recovery maintenance mode feature addition URL: https://github.com/apache/helix/pull/309 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] i3wangyi opened a new pull request #310: [HELIX-805] Implementation on HelixAdmin to check if cluster in maint…

2019-02-26 Thread GitBox
i3wangyi opened a new pull request #310: [HELIX-805] Implementation on HelixAdmin to check if cluster in maint… URL: https://github.com/apache/helix/pull/310 …enance mode This is an automated message from the Apache Git Servi

[GitHub] asfgit merged pull request #310: [HELIX-805] Implementation on HelixAdmin to check if cluster in maint…

2019-02-26 Thread GitBox
asfgit merged pull request #310: [HELIX-805] Implementation on HelixAdmin to check if cluster in maint… URL: https://github.com/apache/helix/pull/310 This is an automated message from the Apache Git Service. To respond to th

[GitHub] i3wangyi opened a new pull request #311: Check maitenanceMode rest api implementation

2019-02-26 Thread GitBox
i3wangyi opened a new pull request #311: Check maitenanceMode rest api implementation URL: https://github.com/apache/helix/pull/311 Refactor the getClusterInfo method in ClusterAccessor rest api - Changes in paused and maintenance mode

[GitHub] asfgit merged pull request #311: Check maitenanceMode rest api implementation

2019-02-26 Thread GitBox
asfgit merged pull request #311: Check maitenanceMode rest api implementation URL: https://github.com/apache/helix/pull/311 This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] narendly opened a new pull request #312: Minor bug fixes and improvements

2019-02-26 Thread GitBox
narendly opened a new pull request #312: Minor bug fixes and improvements URL: https://github.com/apache/helix/pull/312 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] i3wangyi opened a new pull request #313: [HELIX-813] HELIX instance level validation util for rest API

2019-02-26 Thread GitBox
i3wangyi opened a new pull request #313: [HELIX-813] HELIX instance level validation util for rest API URL: https://github.com/apache/helix/pull/313 This is an automated message from the Apache Git Service. To respond to the

[GitHub] asfgit merged pull request #313: [HELIX-813] HELIX instance level validation util for rest API

2019-02-26 Thread GitBox
asfgit merged pull request #313: [HELIX-813] HELIX instance level validation util for rest API URL: https://github.com/apache/helix/pull/313 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] dasahcc commented on issue #312: Minor bug fixes and improvements

2019-02-26 Thread GitBox
dasahcc commented on issue #312: Minor bug fixes and improvements URL: https://github.com/apache/helix/pull/312#issuecomment-467695630 LGTM. But since this is large change. I will leave here for other reviewers to review it. At same time. could you please rebase the head. -

[GitHub] asfgit merged pull request #312: Minor bug fixes and improvements

2019-02-26 Thread GitBox
asfgit merged pull request #312: Minor bug fixes and improvements URL: https://github.com/apache/helix/pull/312 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] narendly closed pull request #269: [HELIX-752] Add missing shutdown for RoutingTableProvider

2019-02-27 Thread GitBox
narendly closed pull request #269: [HELIX-752] Add missing shutdown for RoutingTableProvider URL: https://github.com/apache/helix/pull/269 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] narendly opened a new pull request #314: [HELIX-814] HELIX: Add back ClusterDataCache for backward-compatibility

2019-02-28 Thread GitBox
narendly opened a new pull request #314: [HELIX-814] HELIX: Add back ClusterDataCache for backward-compatibility URL: https://github.com/apache/helix/pull/314 It was discovered that removing ClusterDataCache and changing public interfaces (RebalanceStrategy, Rebalancer) caused backward-inc

[GitHub] asfgit merged pull request #314: [HELIX-814] HELIX: Add back ClusterDataCache for backward-compatibility

2019-02-28 Thread GitBox
asfgit merged pull request #314: [HELIX-814] HELIX: Add back ClusterDataCache for backward-compatibility URL: https://github.com/apache/helix/pull/314 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [helix] narendly opened a new pull request #315: Add markdown for auto-exit of maintenance mode

2019-03-04 Thread GitBox
narendly opened a new pull request #315: Add markdown for auto-exit of maintenance mode URL: https://github.com/apache/helix/pull/315 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [helix] dasahcc commented on issue #315: Add markdown for auto-exit of maintenance mode

2019-03-05 Thread GitBox
dasahcc commented on issue #315: Add markdown for auto-exit of maintenance mode URL: https://github.com/apache/helix/pull/315#issuecomment-469871837 Let's move user guide from FAQ to a separate section and describe it more on operations.

[GitHub] [helix] narendly commented on issue #315: Add markdown for auto-exit of maintenance mode

2019-03-05 Thread GitBox
narendly commented on issue #315: Add markdown for auto-exit of maintenance mode URL: https://github.com/apache/helix/pull/315#issuecomment-469903213 Updated per your suggestions. This is an automated message from the Apache G

[GitHub] [helix] dasahcc merged pull request #315: Add markdown for auto-exit of maintenance mode

2019-03-06 Thread GitBox
dasahcc merged pull request #315: Add markdown for auto-exit of maintenance mode URL: https://github.com/apache/helix/pull/315 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [helix] narendly opened a new pull request #316: Revise the markdown and add more context to how-to guide

2019-03-06 Thread GitBox
narendly opened a new pull request #316: Revise the markdown and add more context to how-to guide URL: https://github.com/apache/helix/pull/316 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [helix] dasahcc merged pull request #316: Revise the markdown and add more context to how-to guide

2019-03-06 Thread GitBox
dasahcc merged pull request #316: Revise the markdown and add more context to how-to guide URL: https://github.com/apache/helix/pull/316 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [helix] bd2019us opened a new pull request #317: [HELIX-815] fix bug to avoid potential crash

2019-03-31 Thread GitBox
bd2019us opened a new pull request #317: [HELIX-815] fix bug to avoid potential crash URL: https://github.com/apache/helix/pull/317 Fix: (HELIX-815-PATCH)[https://issues.apache.org/jira/browse/HELIX-815] This is an automated

[GitHub] [helix] jiajunwang commented on issue #317: [HELIX-815] fix bug to avoid potential crash

2019-04-01 Thread GitBox
jiajunwang commented on issue #317: [HELIX-815] fix bug to avoid potential crash URL: https://github.com/apache/helix/pull/317#issuecomment-478714480 Thanks for the fix. Merged to master branch. This is an automated message fr

[GitHub] [helix] jiajunwang merged pull request #317: [HELIX-815] fix bug to avoid potential crash

2019-04-01 Thread GitBox
jiajunwang merged pull request #317: [HELIX-815] fix bug to avoid potential crash URL: https://github.com/apache/helix/pull/317 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [helix] bd2019us opened a new pull request #318: HELIX-816 use System.currentTimeMillis()

2019-04-12 Thread GitBox
bd2019us opened a new pull request #318: HELIX-816 use System.currentTimeMillis() URL: https://github.com/apache/helix/pull/318 new Date() is just a thin wrapper around System.currentTimeMillis(). Using System.currentTimeMillis() can help speed up the system --

[GitHub] [helix] narendly merged pull request #318: HELIX-816 use System.currentTimeMillis()

2019-04-12 Thread GitBox
narendly merged pull request #318: HELIX-816 use System.currentTimeMillis() URL: https://github.com/apache/helix/pull/318 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [helix] narendly commented on issue #318: HELIX-816 use System.currentTimeMillis()

2019-04-12 Thread GitBox
narendly commented on issue #318: HELIX-816 use System.currentTimeMillis() URL: https://github.com/apache/helix/pull/318#issuecomment-482737721 Thanks for the PR :) This is an automated message from the Apache Git Service. To

[GitHub] [helix] alexgreenbar opened a new pull request #319: Fix long version of quickstart guide of helix 0.8.4 release.

2019-05-07 Thread GitBox
alexgreenbar opened a new pull request #319: Fix long version of quickstart guide of helix 0.8.4 release. URL: https://github.com/apache/helix/pull/319 1. fix the wrong command parameter 2. add the command output This is a

[GitHub] [helix] alexgreenbar opened a new pull request #320: Fix compile error on master branch.

2019-05-07 Thread GitBox
alexgreenbar opened a new pull request #320: Fix compile error on master branch. URL: https://github.com/apache/helix/pull/320 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [helix] narendly commented on issue #320: Fix compile error on master branch.

2019-05-07 Thread GitBox
narendly commented on issue #320: Fix compile error on master branch. URL: https://github.com/apache/helix/pull/320#issuecomment-490186774 Did it not compile on the old version? This is an automated message from the Apache Git

[GitHub] [helix] jiajunwang commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release.

2019-05-07 Thread GitBox
jiajunwang commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release. URL: https://github.com/apache/helix/pull/319#discussion_r281770856 ## File path: website/0.8.4/src/site/markdown/Quickstart.md ## @@ -406,7 +406,55 @@ Now,

[GitHub] [helix] alexgreenbar commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release.

2019-05-08 Thread GitBox
alexgreenbar commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release. URL: https://github.com/apache/helix/pull/319#discussion_r282336490 ## File path: website/0.8.4/src/site/markdown/Quickstart.md ## @@ -406,7 +406,55 @@ Now

[GitHub] [helix] alexgreenbar commented on issue #320: Fix compile error on master branch.

2019-05-08 Thread GitBox
alexgreenbar commented on issue #320: Fix compile error on master branch. URL: https://github.com/apache/helix/pull/320#issuecomment-490741308 > Did it not compile on the old version? Yes, I will paste more details. Thi

[GitHub] [helix] alexgreenbar commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release.

2019-05-08 Thread GitBox
alexgreenbar commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release. URL: https://github.com/apache/helix/pull/319#discussion_r282358381 ## File path: website/0.8.4/src/site/markdown/Quickstart.md ## @@ -406,7 +406,55 @@ Now

[GitHub] [helix] alexgreenbar commented on issue #320: Fix compile error on master branch.

2019-05-09 Thread GitBox
alexgreenbar commented on issue #320: Fix compile error on master branch. URL: https://github.com/apache/helix/pull/320#issuecomment-490770796 > Did it not compile on the old version? I've provided more details on PR description. --

[GitHub] [helix] alexgreenbar removed a comment on issue #320: Fix compile error on master branch.

2019-05-09 Thread GitBox
alexgreenbar removed a comment on issue #320: Fix compile error on master branch. URL: https://github.com/apache/helix/pull/320#issuecomment-490741308 > Did it not compile on the old version? Yes, I will paste more details. ---

[GitHub] [helix] alexgreenbar commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release.

2019-05-09 Thread GitBox
alexgreenbar commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release. URL: https://github.com/apache/helix/pull/319#discussion_r282336490 ## File path: website/0.8.4/src/site/markdown/Quickstart.md ## @@ -406,7 +406,55 @@ Now

[GitHub] [helix] narendly commented on issue #320: Fix compile error on master branch.

2019-05-09 Thread GitBox
narendly commented on issue #320: Fix compile error on master branch. URL: https://github.com/apache/helix/pull/320#issuecomment-491007976 I've tried on 2 different machines and it seems to work fine on both. I don't have a problem with bumping up the dependency version, but at this point,

[GitHub] [helix] alexgreenbar commented on issue #320: Fix compile error on master branch.

2019-05-10 Thread GitBox
alexgreenbar commented on issue #320: Fix compile error on master branch. URL: https://github.com/apache/helix/pull/320#issuecomment-491238706 I still got the same compile error after I did below actions 1. upgrade my maven from 3.3.1 to 3.6.1, which is the latest version 2. run comman

[GitHub] [helix] narendly opened a new issue #321: Issue testing

2019-05-29 Thread GitBox
narendly opened a new issue #321: Issue testing URL: https://github.com/apache/helix/issues/321 Test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [helix] narendly commented on issue #321: Issue testing

2019-05-29 Thread GitBox
narendly commented on issue #321: Issue testing URL: https://github.com/apache/helix/issues/321#issuecomment-497111470 #320 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [helix] narendly closed issue #321: Issue testing

2019-05-31 Thread GitBox
narendly closed issue #321: Issue testing URL: https://github.com/apache/helix/issues/321 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [helix] jackjlli opened a new issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled.

2019-06-24 Thread GitBox
jackjlli opened a new issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled. URL: https://github.com/apache/helix/issues/322 When CRUSH based rebalance strategy algorithm is used, if the related resource isn't enabled yet, Helix will throw `IllegalStateExcep

[GitHub] [helix] narendly opened a new issue #323: [HELIX-817] Support for multiple instance group tags for Job config

2019-06-24 Thread GitBox
narendly opened a new issue #323: [HELIX-817] Support for multiple instance group tags for Job config URL: https://github.com/apache/helix/issues/323 Currently we can set only one instance group tag for a job. jobCfg.setInstanceGroupTag("INSTANCEGROUPTAG"); It will be reall

[GitHub] [helix] jiajunwang commented on issue #323: [HELIX-817] Support for multiple instance group tags for Job config

2019-06-24 Thread GitBox
jiajunwang commented on issue #323: [HELIX-817] Support for multiple instance group tags for Job config URL: https://github.com/apache/helix/issues/323#issuecomment-505100927 What's the difference between using multiple instance group tags and defining a new tag that includes the desired

[GitHub] [helix] jiajunwang commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled.

2019-06-24 Thread GitBox
jiajunwang commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled. URL: https://github.com/apache/helix/issues/322#issuecomment-505104174 This is an error log. Could you please share the test case? What was complained is lacking an eligible insta

[GitHub] [helix] jackjlli commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled.

2019-06-24 Thread GitBox
jackjlli commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled. URL: https://github.com/apache/helix/issues/322#issuecomment-505109075 Hi @jiajunwang , basically we recently added a resource called `leadControllerResource` in Pinot and set the

[GitHub] [helix] DImuthuUpe commented on issue #323: [HELIX-817] Support for multiple instance group tags for Job config

2019-06-24 Thread GitBox
DImuthuUpe commented on issue #323: [HELIX-817] Support for multiple instance group tags for Job config URL: https://github.com/apache/helix/issues/323#issuecomment-505127003 @jiajunwang Good question. We can add tags to instances as much as we want. But the problem is, is it scalable? I'm

[GitHub] [helix] jiajunwang commented on issue #323: [HELIX-817] Support for multiple instance group tags for Job config

2019-06-24 Thread GitBox
jiajunwang commented on issue #323: [HELIX-817] Support for multiple instance group tags for Job config URL: https://github.com/apache/helix/issues/323#issuecomment-505162329 @DImuthuUpe, by supporting both sides configuration, we definitely cover more use cases. I think it's very nice to

[GitHub] [helix] jiajunwang commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled.

2019-06-24 Thread GitBox
jiajunwang commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled. URL: https://github.com/apache/helix/issues/322#issuecomment-505180440 Thanks for the information, @jackjlli. So you are more concerned about the verbose log, right? We can defini

[GitHub] [helix] jiajunwang edited a comment on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled.

2019-06-24 Thread GitBox
jiajunwang edited a comment on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled. URL: https://github.com/apache/helix/issues/322#issuecomment-505180440 Thanks for the information, @jackjlli. So you are more concerned about the verbose log, right? We can

[GitHub] [helix] jackjlli commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled.

2019-06-24 Thread GitBox
jackjlli commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled. URL: https://github.com/apache/helix/issues/322#issuecomment-505184521 Great! Thanks for confirming! This is an auto

[GitHub] [helix] narendly opened a new issue #324: Change logging level in CallbackHandler

2019-06-25 Thread GitBox
narendly opened a new issue #324: Change logging level in CallbackHandler URL: https://github.com/apache/helix/issues/324 Go through the logs and change some debug logs to info logs since they might help with debugging. This

[GitHub] [helix] jiajunwang opened a new issue #325: We should use system provided thread Id instead of using a self maintained integer

2019-06-25 Thread GitBox
jiajunwang opened a new issue #325: We should use system provided thread Id instead of using a self maintained integer URL: https://github.com/apache/helix/issues/325 https://github.com/apache/helix/blob/aa77f5c0bfc3cafb6482b1cef4a1689191cbd846/helix-core/src/main/java/org/apache/helix/tas

[GitHub] [helix] narendly opened a new issue #326: Add getWorkflow(long timeout) in TaskDriver

2019-06-27 Thread GitBox
narendly opened a new issue #326: Add getWorkflow(long timeout) in TaskDriver URL: https://github.com/apache/helix/issues/326 Sometimes ZK hangs in the getWorkflow() call, and we could provide an API with a timeout to handle this at the application level. AC: 1. Add getWorkflow(lo

[GitHub] [helix] narendly opened a new issue #327: Change the way we trigger rebalance in purgeExpiredJobs

2019-06-27 Thread GitBox
narendly opened a new issue #327: Change the way we trigger rebalance in purgeExpiredJobs URL: https://github.com/apache/helix/issues/327 Currently, we use ResourceConfigs to trigger a rebalance. But this is causing Helix to write a ResourceConfig back to ZK, which is not desirable when a

[GitHub] [helix] dasahcc opened a new issue #328: Exclude ANY_INSTANCE for customized sibling checks

2019-07-09 Thread GitBox
dasahcc opened a new issue #328: Exclude ANY_INSTANCE for customized sibling checks URL: https://github.com/apache/helix/issues/328 Current Helix HealthCheck API checks the ANY_INSTANCE resources, which is not necessary. Since ANY_INSTANCE resources only have single partition with 1 repli

[GitHub] [helix] dasahcc opened a new pull request #329: #328 Exclude ANY_INSTANCE for customized sibling checks

2019-07-09 Thread GitBox
dasahcc opened a new pull request #329: #328 Exclude ANY_INSTANCE for customized sibling checks URL: https://github.com/apache/helix/pull/329 Current Helix HealthCheck API checks the ANY_INSTANCE resources, which is not necessary. Since ANY_INSTANCE resources only have single partition wit

[GitHub] [helix] dasahcc merged pull request #329: #328 Exclude ANY_INSTANCE for customized sibling checks

2019-07-09 Thread GitBox
dasahcc merged pull request #329: #328 Exclude ANY_INSTANCE for customized sibling checks URL: https://github.com/apache/helix/pull/329 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [helix] dasahcc closed issue #328: Exclude ANY_INSTANCE for customized sibling checks

2019-07-09 Thread GitBox
dasahcc closed issue #328: Exclude ANY_INSTANCE for customized sibling checks URL: https://github.com/apache/helix/issues/328 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [helix] dasahcc commented on issue #328: Exclude ANY_INSTANCE for customized sibling checks

2019-07-09 Thread GitBox
dasahcc commented on issue #328: Exclude ANY_INSTANCE for customized sibling checks URL: https://github.com/apache/helix/issues/328#issuecomment-509931085 Fixed This is an automated message from the Apache Git Service. To res

[GitHub] [helix] lei-xia commented on issue #329: #328 Exclude ANY_INSTANCE for customized sibling checks

2019-07-10 Thread GitBox
lei-xia commented on issue #329: #328 Exclude ANY_INSTANCE for customized sibling checks URL: https://github.com/apache/helix/pull/329#issuecomment-510227742 5 tests fails, should we fix the tests? This is an automated messag

[GitHub] [helix] dasahcc commented on issue #329: #328 Exclude ANY_INSTANCE for customized sibling checks

2019-07-10 Thread GitBox
dasahcc commented on issue #329: #328 Exclude ANY_INSTANCE for customized sibling checks URL: https://github.com/apache/helix/pull/329#issuecomment-510239011 > 5 tests fails, should we fix the tests? There is only 1 test is unstable. We will try to fix it. I run it locally again, th

[GitHub] [helix] dasahcc opened a new issue #330: AutoFallbackPropertyStore make cache path to be null

2019-07-10 Thread GitBox
dasahcc opened a new issue #330: AutoFallbackPropertyStore make cache path to be null URL: https://github.com/apache/helix/issues/330 Current AutoFallbackPropertyStore instantiation mark the zkCachePath to be null. So the caching functionality is not work for this type of ProertyStore.

[GitHub] [helix] dasahcc commented on issue #327: Change the way Helix triggers rebalance in purgeExpiredJobs

2019-07-11 Thread GitBox
dasahcc commented on issue #327: Change the way Helix triggers rebalance in purgeExpiredJobs URL: https://github.com/apache/helix/issues/327#issuecomment-510685974 There is a race condition if user update the ResourceConfig at same time. Say original p1 has preference list: [1, 2, 3]. Heli

[GitHub] [helix] Jackie-Jiang opened a new issue #331: CallbackHandler async re-subscribe watcher can potentially miss events

2019-07-15 Thread GitBox
Jackie-Jiang opened a new issue #331: CallbackHandler async re-subscribe watcher can potentially miss events URL: https://github.com/apache/helix/issues/331 In CallbackHandler, the re-subscription of the watcher for CALLBACK happens asynchronously. If the re-subscription happens after the

[GitHub] [helix] i3wangyi opened a new issue #332: Issue when client ONLY sets cluster level ANY throttle config

2019-07-15 Thread GitBox
i3wangyi opened a new issue #332: Issue when client ONLY sets cluster level ANY throttle config URL: https://github.com/apache/helix/issues/332 The current implementation has a loophole when 1. When client **ONLY** sets cluster level ANY throttle config (no specific type throttle) 2

[GitHub] [helix] i3wangyi opened a new pull request #333: Fix issue when client only sets ANY at cluster level throttle config

2019-07-15 Thread GitBox
i3wangyi opened a new pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333 **Issues** (fixes #332 Issue when client ONLY sets cluster level ANY throttle config ) **Description** The fix will decrem

[GitHub] [helix] dasahcc opened a new issue #334: ZNRecord updater merge listfield with adding duplicate elements

2019-07-15 Thread GitBox
dasahcc opened a new issue #334: ZNRecord updater merge listfield with adding duplicate elements URL: https://github.com/apache/helix/issues/334 Current HelixDataAccesor updateProperty uses ZNRecordUpdater. It's merge logic just simply adding all elements when do a merge for ZNRecord. That

[GitHub] [helix] i3wangyi opened a new issue #335: Support Property Read API - helix-rest

2019-07-15 Thread GitBox
i3wangyi opened a new issue #335: Support Property Read API - helix-rest URL: https://github.com/apache/helix/issues/335 Currently, there's no endpoint available for users to read propertystore content directly via helix-rest endpoint. Users have to rely on tools to view the data on zookee

[GitHub] [helix] dasahcc opened a new pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

2019-07-15 Thread GitBox
dasahcc opened a new pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336 **Issues** (fixes #334 ) **Description** Current HelixDataAccesor updateProperty uses ZNRecordUpdater. It's merge logic jus

[GitHub] [helix] jiajunwang commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

2019-07-15 Thread GitBox
jiajunwang commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336#discussion_r303739444 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @@ -10

[GitHub] [helix] jiajunwang commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

2019-07-15 Thread GitBox
jiajunwang commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336#discussion_r303740523 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/RebalanceS

[GitHub] [helix] dasahcc commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

2019-07-15 Thread GitBox
dasahcc commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336#discussion_r303745274 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/RebalanceSche

[GitHub] [helix] alirezazamani opened a new pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm.

2019-07-16 Thread GitBox
alirezazamani opened a new pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm. URL: https://github.com/apache/helix/pull/337 In CRUSH based rebalance strategy, when there is no eligible instance for the controller to use, it shows an exception whic

[GitHub] [helix] lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

2019-07-16 Thread GitBox
lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336#discussion_r304025056 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/RebalanceSche

[GitHub] [helix] lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

2019-07-16 Thread GitBox
lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336#discussion_r304026414 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @@ -1021,

[GitHub] [helix] lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

2019-07-16 Thread GitBox
lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336#discussion_r304026926 ## File path: helix-core/src/test/java/org/apache/helix/util/TestRebalanceScheduler.java ##

[GitHub] [helix] dasahcc commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

2019-07-16 Thread GitBox
dasahcc commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336#discussion_r304050227 ## File path: helix-core/src/test/java/org/apache/helix/util/TestRebalanceScheduler.java ##

  1   2   3   4   5   6   7   8   >