[ https://issues.apache.org/jira/browse/HELIX-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090070#comment-14090070 ]
Hudson commented on HELIX-486: ------------------------------ SUCCESS: Integrated in helix #1279 (See [https://builds.apache.org/job/helix/1279/]) [HELIX-484] Remove CallbackHandler/ZkCallbackHandler code duplication, [HELIX-486] Remove StateModelFactory/HelixStateModelFactory code duplication, rb=24332 (zzhang: rev 4ae1ff796a524766b22f5fc184952187dc9cc24b) * helix-core/src/test/java/org/apache/helix/integration/TestZkReconnect.java * helix-core/src/test/java/org/apache/helix/Mocks.java * helix-examples/src/main/java/org/apache/helix/examples/OnlineOfflineStateModelFactory.java * helix-core/src/test/java/org/apache/helix/TestHelixTaskExecutor.java * helix-core/src/main/java/org/apache/helix/participant/HelixCustomCodeRunner.java * helix-core/src/test/java/org/apache/helix/integration/manager/ZkTestManager.java * recipes/user-defined-rebalancer/src/main/java/org/apache/helix/userdefinedrebalancer/Lock.java * helix-core/src/main/java/org/apache/helix/api/id/StateModelDefId.java * recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/FileStoreStateModelFactory.java * helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerStateModelFactory.java * helix-core/src/test/java/org/apache/helix/integration/TestNonOfflineInitState.java * helix-core/src/test/java/org/apache/helix/mock/participant/MockSchemataModelFactory.java * helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java * helix-core/src/main/java/org/apache/helix/api/StateTransitionHandlerFactory.java * recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/ConsumerStateModelFactory.java * helix-core/src/test/java/org/apache/helix/mock/participant/MockMSModelFactory.java * helix-core/src/test/java/org/apache/helix/manager/zk/MockParticipant.java * recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/Consumer.java * helix-examples/src/main/java/org/apache/helix/examples/BootstrapHandler.java * helix-core/src/main/java/org/apache/helix/task/TaskRunner.java * helix-core/src/main/java/org/apache/helix/participant/statemachine/HelixStateModelFactoryAdaptor.java * helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java * helix-core/src/test/java/org/apache/helix/integration/TestPartitionLevelTransitionConstraint.java * helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java * helix-core/src/main/java/org/apache/helix/participant/GenericLeaderStandbyModel.java * helix-core/src/test/java/org/apache/helix/integration/TestResetResource.java * helix-core/src/test/java/org/apache/helix/mock/participant/MockBootstrapStateModel.java * helix-core/src/main/java/org/apache/helix/participant/statemachine/HelixStateModelFactory.java * helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java * helix-examples/src/main/java/org/apache/helix/examples/ExampleProcess.java * helix-core/src/test/java/org/apache/helix/mock/participant/DummyProcess.java * helix-core/src/test/java/org/apache/helix/TestHelixTaskHandler.java * helix-examples/src/main/java/org/apache/helix/examples/MasterSlaveStateModelFactory.java * helix-core/src/test/java/org/apache/helix/integration/TestResetInstance.java * helix-core/src/main/java/org/apache/helix/participant/statemachine/StateModelParser.java * helix-examples/src/main/java/org/apache/helix/examples/LogicalModelExample.java * helix-core/src/main/java/org/apache/helix/participant/statemachine/StateModel.java * helix-core/src/test/java/org/apache/helix/mock/participant/MockSchemataStateModel.java * helix-core/src/main/java/org/apache/helix/participant/GenericLeaderStandbyStateModelFactory.java * recipes/task-execution/src/main/java/org/apache/helix/taskexecution/TaskStateModel.java * helix-core/src/test/java/org/apache/helix/participant/TestDistControllerStateModelFactory.java * helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java * helix-core/src/test/java/org/apache/helix/participant/MockZKHelixManager.java * helix-core/src/test/java/org/apache/helix/integration/TestHelixConnection.java * helix-core/src/main/java/org/apache/helix/participant/CustomCodeInvoker.java * helix-core/src/test/java/org/apache/helix/integration/TestStateTransitionTimeout.java * helix-core/src/test/java/org/apache/helix/manager/zk/MockMultiClusterController.java * helix-provisioning/src/main/java/org/apache/helix/provisioning/participant/StatelessServiceStateModelFactory.java * helix-core/src/test/java/org/apache/helix/integration/TestPreferenceListAsQueue.java * helix-core/src/main/java/org/apache/helix/participant/HelixStateMachineEngine.java * helix-core/src/test/java/org/apache/helix/integration/manager/TestHelixMultiClusterController.java * helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetInstance.java * recipes/distributed-lock-manager/src/main/java/org/apache/helix/lockmanager/LockFactory.java * helix-examples/src/main/java/org/apache/helix/examples/BootstrapProcess.java * helix-core/src/test/java/org/apache/helix/integration/manager/TestParticipantManager.java * helix-core/src/test/java/org/apache/helix/integration/TestDistributedClusterController.java * helix-core/src/main/java/org/apache/helix/api/TransitionHandler.java * helix-core/src/test/java/org/apache/helix/DummyProcessThread.java * recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/ConsumerStateTransitionHandlerFactory.java * helix-admin-webapp/src/test/java/org/apache/helix/webapp/TestResetResource.java * helix-core/src/test/java/org/apache/helix/integration/TestCorrectnessOnConnectivityLoss.java * recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/FileStoreStateModel.java * helix-agent/src/main/java/org/apache/helix/agent/AgentStateModel.java * helix-examples/src/main/java/org/apache/helix/examples/Quickstart.java * helix-core/src/test/java/org/apache/helix/integration/TestMessageThrottle2.java * helix-examples/src/main/java/org/apache/helix/examples/DummyParticipant.java * helix-core/src/test/java/org/apache/helix/integration/TestMessagingService.java * helix-core/src/test/java/org/apache/helix/integration/manager/TestConsecutiveZkSessionExpiry.java * recipes/user-defined-rebalancer/src/main/java/org/apache/helix/userdefinedrebalancer/LockFactory.java * helix-core/src/test/java/org/apache/helix/integration/TestAddStateModelFactoryAfterConnect.java * helix-core/src/test/java/org/apache/helix/participant/statemachine/TestStateModelParser.java * helix-core/src/test/java/org/apache/helix/integration/manager/TestStateModelLeak.java * recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/ConsumerStateModel.java * helix-core/src/main/java/org/apache/helix/task/TaskStateModelFactory.java * helix-core/src/test/java/org/apache/helix/integration/TestMultiClusterController.java * helix-core/src/main/java/org/apache/helix/participant/statemachine/ScheduledTaskStateModel.java * helix-core/src/test/java/org/apache/helix/integration/TestBatchMessageWrapper.java * helix-core/src/test/java/org/apache/helix/TestHelper.java * helix-core/src/main/java/org/apache/helix/participant/StateMachineEngine.java * recipes/distributed-lock-manager/src/main/java/org/apache/helix/lockmanager/Lock.java * helix-core/src/main/java/org/apache/helix/participant/statemachine/StateModelFactory.java * helix-core/src/test/java/org/apache/helix/mock/participant/MockBootstrapModelFactory.java * helix-core/src/test/java/org/apache/helix/mock/participant/MockMSStateModel.java * helix-core/src/test/java/org/apache/helix/messaging/TestAsyncCallbackSvc.java * helix-core/src/test/java/org/apache/helix/manager/zk/TestDefaultControllerMsgHandlerFactory.java * helix-agent/src/main/java/org/apache/helix/agent/AgentStateModelFactory.java * helix-core/src/test/java/org/apache/helix/integration/TestSchedulerMessage.java * helix-core/src/test/java/org/apache/helix/integration/manager/TestDistributedControllerManager.java * helix-provisioning/src/main/java/org/apache/helix/provisioning/participant/StatelessServiceStateModel.java * helix-examples/src/main/java/org/apache/helix/examples/LeaderStandbyStateModelFactory.java * helix-core/src/main/java/org/apache/helix/participant/statemachine/ScheduledTaskStateModelFactory.java * helix-core/src/test/java/org/apache/helix/integration/TestErrorPartition.java * helix-core/src/main/java/org/apache/helix/messaging/handling/HelixStateTransitionHandler.java * recipes/task-execution/src/main/java/org/apache/helix/taskexecution/TaskStateModelFactory.java * helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java * helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerStateModel.java * helix-core/src/test/java/org/apache/helix/integration/TestResetPartitionState.java * helix-core/src/test/java/org/apache/helix/model/TestConstraint.java > Remove StateModelFactory/HelixStateModelFactory code duplication > ---------------------------------------------------------------- > > Key: HELIX-486 > URL: https://issues.apache.org/jira/browse/HELIX-486 > Project: Apache Helix > Issue Type: Sub-task > Reporter: Kanak Biscuitwala > -- This message was sent by Atlassian JIRA (v6.2#6252)