Re: Heron github emails [VOTE RESULTS]

2018-05-19 Thread Josh Fischer
The gitbox change has been completed. - Josh On Sat, May 19, 2018 at 4:47 PM, Josh Fischer wrote: > An apache Infra ticket has been created. You can find the link below. > If anyone has any feedback/suggestions on how to improve the ticket please > let me know. > > https://issues.apache.org/j

Re: Heron github emails [VOTE RESULTS]

2018-05-19 Thread Josh Fischer
An apache Infra ticket has been created. You can find the link below. If anyone has any feedback/suggestions on how to improve the ticket please let me know. https://issues.apache.org/jira/browse/INFRA-16549 - Josh On Sat, May 19, 2018 at 1:21 PM, Jerry Peng wrote: > +1 > On Fri, May 18, 20

[GitHub] bornej commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-19 Thread GitBox
bornej commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390423959 @jerrypeng Thank you so much! I will do experiments with heron multithreading in the next weeks. I hope to have some results to shar

[GitHub] bornej commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-19 Thread GitBox
bornej commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390423959 @jerrypeng Thank you so much! I will do experiments with heron multithreading in the next weeks. I hope to have some performance com

Re: Heron github emails [VOTE RESULTS]

2018-05-19 Thread Jerry Peng
+1 On Fri, May 18, 2018 at 8:59 PM Ning Wang wrote: > +1! > On Fri, May 18, 2018 at 7:28 PM, Karthik Ramasamy > wrote: > > +1 as well. > > > > On Fri, May 18, 2018 at 7:18 PM Josh Fischer wrote: > > > > > We have 7 positive votes and NO vetos. I will take the necessary steps > > to > > > get

[GitHub] jerrypeng commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-19 Thread GitBox
jerrypeng commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390422873 @nlu90 just to be clear, with out this patch its not even possible to guarantee at-most once. An NPE will very likely to be thrown if y

[GitHub] jerrypeng commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-19 Thread GitBox
jerrypeng commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390423252 @bornej here is an example of a bolt that acks and emits from a different thread ``` public static class ExclamationBolt exten

[GitHub] jerrypeng commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-19 Thread GitBox
jerrypeng commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390422873 @nlu90 just to be clear, with out this patch its not even possible to guarantee at-most once. An NPE will very likely to be thrown if y

[GitHub] bornej commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-19 Thread GitBox
bornej commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390401048 Thank you very much, Is there any example of multi-threaded heron bolt/spout/topology out there? ---

[GitHub] bornej commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-19 Thread GitBox
bornej commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390401048 Thanks you very much, Is there any example of multi-threaded heron bolt/spout/topology out there? --