Re: Proposing Changes To Heron ECO
Good proposal - uses existing code and adds more capabilities for custom grouping. +1 On Thu, Mar 29, 2018 at 8:16 PM Josh Fischerwrote: > I've recently discovered a bug while trying to create a custom grouping > example with ECO. > > Historically with Flux (which ECO is based off of) you would define a > custom grouping like below. > > - name: "bolt-1 --> bolt2" > from: "bolt-1" > to: "bolt-2" > grouping: > type: CUSTOM > customClass: > className: "org.apache.storm.testing.NGrouping" > > I propose we move the nested "customClass" properties up a level. This > will simplify the structure of the definition and will still allow us to > call config methods, set properties, and call constructors like any other > component defined in the topology file. This above definition is causing > snake yaml to throw an exception during instantiation of the customClass > objects. > > A verbose example of the proposed custom grouping definition change is > below. The major change is that "customClass" nesting has been removed. > > - from: "wordSpout" > to: "printBolt" > grouping: > type: CUSTOM > className: "org.apache.heron.eco.starters.CustomGrouping" > constructorArgs: > - ref: "property-holder" > configMethods: >- name: "sampleConfigurationMethod" > args: >- "${ecoPropertyOne}" >- MB > properties: > - name: "numberProperty" > value: 11 > - name: "publicProperty" > value: "This is public property" > > Any comments and/or questions are appreciated! >
Proposing Changes To Heron ECO
I've recently discovered a bug while trying to create a custom grouping example with ECO. Historically with Flux (which ECO is based off of) you would define a custom grouping like below. - name: "bolt-1 --> bolt2" from: "bolt-1" to: "bolt-2" grouping: type: CUSTOM customClass: className: "org.apache.storm.testing.NGrouping" I propose we move the nested "customClass" properties up a level. This will simplify the structure of the definition and will still allow us to call config methods, set properties, and call constructors like any other component defined in the topology file. This above definition is causing snake yaml to throw an exception during instantiation of the customClass objects. A verbose example of the proposed custom grouping definition change is below. The major change is that "customClass" nesting has been removed. - from: "wordSpout" to: "printBolt" grouping: type: CUSTOM className: "org.apache.heron.eco.starters.CustomGrouping" constructorArgs: - ref: "property-holder" configMethods: - name: "sampleConfigurationMethod" args: - "${ecoPropertyOne}" - MB properties: - name: "numberProperty" value: 11 - name: "publicProperty" value: "This is public property" Any comments and/or questions are appreciated!
Re: Heron is in Apacheinfra home now
Thanks Bill - will address it as well. Sent from my iPhone > On Mar 29, 2018, at 4:17 PM, Bill Grahamwrote: > > We won't be able to do an apache release until all binaries are removed > from source. This ticket should be prioritized: > > https://github.com/apache/incubator-heron/issues/2092 > > Also we should lock down the heron user group on google with a message that > we've moved to apache mailing lists. > > On Thu, Mar 29, 2018 at 4:03 PM, Karthik Ramasamy > wrote: > >> Thanks Taylor - we were thinking about an Apache release in 0.17.9 since >> 0.17.8 is already due. Wondering if mentors are ok with it? >> >> Also in order to make what are the steps that we need to follow - is there >> a check list? >> >> Cheers >> /Karthik >> >>> On Thu, Mar 29, 2018 at 3:56 PM P. Taylor Goetz wrote: >>> >>> Now would be a great time to start thinking about an Apache release. >>> >>> Be prepared for a sometimes frustrating process. And as always, feel free >>> to lean on your mentors for help in the process. Prepending “[MENTORS]” >> in >>> subject lines can help get our attention. We are here to help. Don’t be >>> afraid to ask. >>> >>> -Taylor >>> On Mar 29, 2018, at 5:27 PM, Ning Wang wrote: Hi, Heron git repo has moved to the new home! https://github.com/apache/incubator-heron Apache committers should link their ASF IDs and Github IDs as well as enable 2FA on Github: https://gitbox.apache.org/setup/ so they can >>> commit to Github. Otherwise Apache credentials to https://gitbox.apache.org/repos/asf/incubator-heron.git will work. >>> >>
[GitHub] erenavsarogullari opened a new pull request #2826: [WIP] [Streamlet Scala API] Add Scala Streamlet Integration Tests Part I
erenavsarogullari opened a new pull request #2826: [WIP] [Streamlet Scala API] Add Scala Streamlet Integration Tests Part I URL: https://github.com/apache/incubator-heron/pull/2826 **Note:** This PR is currently work-in-progress to verify new Scala Streamlet Integration Tests on Travis CI. This PR aims the following changes: - Adding new Scala Streamlet Integration Test as `ScalaStreamletWithFilterAndTransform` - Addresses Scala integration tests under `scalaTopologies` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] billonahill closed issue #2133: Migrate code to Apache github
billonahill closed issue #2133: Migrate code to Apache github URL: https://github.com/apache/incubator-heron/issues/2133 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] billonahill commented on issue #2133: Migrate code to Apache github
billonahill commented on issue #2133: Migrate code to Apache github URL: https://github.com/apache/incubator-heron/issues/2133#issuecomment-377400380 Done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Heron is in Apacheinfra home now
Thanks Taylor - we were thinking about an Apache release in 0.17.9 since 0.17.8 is already due. Wondering if mentors are ok with it? Also in order to make what are the steps that we need to follow - is there a check list? Cheers /Karthik On Thu, Mar 29, 2018 at 3:56 PM P. Taylor Goetzwrote: > Now would be a great time to start thinking about an Apache release. > > Be prepared for a sometimes frustrating process. And as always, feel free > to lean on your mentors for help in the process. Prepending “[MENTORS]” in > subject lines can help get our attention. We are here to help. Don’t be > afraid to ask. > > -Taylor > > > On Mar 29, 2018, at 5:27 PM, Ning Wang wrote: > > > > Hi, > > > > Heron git repo has moved to the new home! > > > > https://github.com/apache/incubator-heron > > > > > > Apache committers should link their ASF IDs and Github IDs as well as > > enable 2FA on Github: https://gitbox.apache.org/setup/ so they can > commit > > to Github. Otherwise Apache credentials to > > https://gitbox.apache.org/repos/asf/incubator-heron.git will work. >
Re: Heron is in Apacheinfra home now
Now would be a great time to start thinking about an Apache release. Be prepared for a sometimes frustrating process. And as always, feel free to lean on your mentors for help in the process. Prepending “[MENTORS]” in subject lines can help get our attention. We are here to help. Don’t be afraid to ask. -Taylor > On Mar 29, 2018, at 5:27 PM, Ning Wangwrote: > > Hi, > > Heron git repo has moved to the new home! > > https://github.com/apache/incubator-heron > > > Apache committers should link their ASF IDs and Github IDs as well as > enable 2FA on Github: https://gitbox.apache.org/setup/ so they can commit > to Github. Otherwise Apache credentials to > https://gitbox.apache.org/repos/asf/incubator-heron.git will work.
Re: Heron is in Apacheinfra home now
Woot! Exciting milestone. On Thu, Mar 29, 2018 at 2:27 PM, Ning Wangwrote: > Hi, > > Heron git repo has moved to the new home! > > https://github.com/apache/incubator-heron > > > Apache committers should link their ASF IDs and Github IDs as well as > enable 2FA on Github: https://gitbox.apache.org/setup/ so they can commit > to Github. Otherwise Apache credentials to > https://gitbox.apache.org/repos/asf/incubator-heron.git will work. >
[GitHub] nwangtw opened a new pull request #2822: Add rate limit change log in stream manager
nwangtw opened a new pull request #2822: Add rate limit change log in stream manager URL: https://github.com/apache/incubator-heron/pull/2822 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Heron is in Apacheinfra home now
Hi, Heron git repo has moved to the new home! https://github.com/apache/incubator-heron Apache committers should link their ASF IDs and Github IDs as well as enable 2FA on Github: https://gitbox.apache.org/setup/ so they can commit to Github. Otherwise Apache credentials to https://gitbox.apache.org/repos/asf/incubator-heron.git will work.
[GitHub] lucperkins commented on issue #2820: Fix website for GitHub Pages
lucperkins commented on issue #2820: Fix website for GitHub Pages URL: https://github.com/apache/incubator-heron/pull/2820#issuecomment-377377280 @joshfischer1108 Yes, this is a known issue. I'm updating the site as fast as I can. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joshfischer1108 commented on issue #2820: Fix website for GitHub Pages
joshfischer1108 commented on issue #2820: Fix website for GitHub Pages URL: https://github.com/apache/incubator-heron/pull/2820#issuecomment-377376187 https://user-images.githubusercontent.com/5785700/38114218-2c3e2d60-336d-11e8-9598-1f93e381578f.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lucperkins commented on issue #2820: Fix website for GitHub Pages
lucperkins commented on issue #2820: Fix website for GitHub Pages URL: https://github.com/apache/incubator-heron/pull/2820#issuecomment-377375846 @srkukarni At the moment, *none* of the links work because the site was generated with a different base URL. Those links will all be broken until I'm able to publish the site anew. Will do ASAP. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jerrypeng closed pull request #2820: Fix website for GitHub Pages
jerrypeng closed pull request #2820: Fix website for GitHub Pages URL: https://github.com/apache/incubator-heron/pull/2820 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/website/config.yaml b/website/config.yaml index c6074631e0..553a94cff4 100755 --- a/website/config.yaml +++ b/website/config.yaml @@ -2,7 +2,7 @@ languageCode: en-us title: Heron author: Luc Perkins canonifyurls: true -baseurl: https://twitter.github.io/heron +baseurl: https://apache.github.io/incubator-heron # Site-level config metadataformat: yaml This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lucperkins opened a new pull request #2820: Fix website for GitHub Pages
lucperkins opened a new pull request #2820: Fix website for GitHub Pages URL: https://github.com/apache/incubator-heron/pull/2820 At the moment, the GitHub Pages site for the post-Apache-transition version of Heron is largely broken because the root URL used to generate the assets is for the old GitHub Pages URL. This PR fixes that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services