Re: A new resource config proposal

2018-04-18 Thread Karthik Ramasamy
Thanks Ning. This is an excellent idea - simplifying from resource point of view. On Wed, Apr 18, 2018 at 10:56 AM, Ning Wang wrote: > In the discussions with a few developers, we have some new thoughts about > the resource config and packing algorithms in heron. Basically

Re: Adding source task id to default metrics

2018-04-18 Thread Karthik Ramasamy
I like the idea of both the metrics and it might be great to include them. Prometheus can aggregate metrics downstream by component-id/source-task etc It is a nice tool. cheers /karthik On Wed, Apr 18, 2018 at 8:32 PM, Fu Maosong wrote: > One concern is that it will

Re: Adding source task id to default metrics

2018-04-18 Thread Fu Maosong
One concern is that it will significantly increase the number of metrics, potentially leading performance concerns. 2018-04-18 18:58 GMT-07:00 Thomas Cooper : > Hi All, > > This started out a quick slack post, then a reasonably sized email and now > it has headings! > >

[GitHub] srkukarni commented on issue #2692: Making emit, ack, and fail thread safe

2018-04-18 Thread GitBox
srkukarni commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-382591000 @nlu90 can you please take a look as well This is an automated message

[GitHub] sreev closed pull request #2866: create 'asf-site' and redirect files

2018-04-18 Thread GitBox
sreev closed pull request #2866: create 'asf-site' and redirect files URL: https://github.com/apache/incubator-heron/pull/2866 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

A new resource config proposal

2018-04-18 Thread Ning Wang
In the discussions with a few developers, we have some new thoughts about the resource config and packing algorithms in heron. Basically we want to step back from the current configs and try to come up with a new solution from user's point of view. Here is a brief proposal document for reference

[GitHub] nwangtw commented on a change in pull request #2866: create 'asf-site' and redirect files

2018-04-18 Thread GitBox
nwangtw commented on a change in pull request #2866: create 'asf-site' and redirect files URL: https://github.com/apache/incubator-heron/pull/2866#discussion_r182325643 ## File path: index.html ## @@ -0,0 +1,8 @@ + + +http://www.example.org;> Review comment:

[GitHub] sreev commented on a change in pull request #2866: create 'asf-site' and redirect files

2018-04-18 Thread GitBox
sreev commented on a change in pull request #2866: create 'asf-site' and redirect files URL: https://github.com/apache/incubator-heron/pull/2866#discussion_r18236 ## File path: index.html ## @@ -0,0 +1,8 @@ + + +http://www.example.org;> Review comment:

[GitHub] sreev commented on a change in pull request #2866: create 'asf-site' and redirect files

2018-04-18 Thread GitBox
sreev commented on a change in pull request #2866: create 'asf-site' and redirect files URL: https://github.com/apache/incubator-heron/pull/2866#discussion_r182322042 ## File path: heron/healthmgr/src/java/org/apache/heron/healthmgr/HealthManagerMetrics.java ## @@ -1,264

[GitHub] nwangtw commented on issue #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

2018-04-18 Thread GitBox
nwangtw commented on issue #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#issuecomment-382277581 Thanks for reviewing. This was a super quick PR and incremental improvement. It seems to be more

[GitHub] nwangtw commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

2018-04-18 Thread GitBox
nwangtw commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r182320947 ## File path: heron/common/src/cpp/network/baseconnection.cpp ## @@

[GitHub] nwangtw commented on a change in pull request #2866: create 'asf-site' and redirect files

2018-04-18 Thread GitBox
nwangtw commented on a change in pull request #2866: create 'asf-site' and redirect files URL: https://github.com/apache/incubator-heron/pull/2866#discussion_r182319801 ## File path: index.html ## @@ -0,0 +1,8 @@ + + +http://www.example.org;> Review comment:

[GitHub] nwangtw commented on a change in pull request #2866: create 'asf-site' and redirect files

2018-04-18 Thread GitBox
nwangtw commented on a change in pull request #2866: create 'asf-site' and redirect files URL: https://github.com/apache/incubator-heron/pull/2866#discussion_r182320076 ## File path: index.html ## @@ -0,0 +1,8 @@ + + +http://www.example.org;> + + +The url of

[GitHub] nwangtw commented on a change in pull request #2866: create 'asf-site' and redirect files

2018-04-18 Thread GitBox
nwangtw commented on a change in pull request #2866: create 'asf-site' and redirect files URL: https://github.com/apache/incubator-heron/pull/2866#discussion_r182319743 ## File path: heron/healthmgr/src/java/org/apache/heron/healthmgr/HealthManagerMetrics.java ## @@

[GitHub] sreev commented on issue #2866: create 'asf-site' and redirect files

2018-04-18 Thread GitBox
sreev commented on issue #2866: create 'asf-site' and redirect files URL: https://github.com/apache/incubator-heron/pull/2866#issuecomment-382275780 @kramasamy, removed the merge conflict file. This is an automated message

[GitHub] kramasamy commented on issue #2864: S3Uploader improvements

2018-04-18 Thread GitBox
kramasamy commented on issue #2864: S3Uploader improvements URL: https://github.com/apache/incubator-heron/pull/2864#issuecomment-382275638 @ajorgensen - once the ci passes, we can merge it. This is an automated message from