[GitHub] kramasamy commented on issue #2879: remove thrift and scribe to prepare for apache release

kramasamy commented on issue #2879: remove thrift and scribe to prepare for apache release URL: https://github.com/apache/incubator-heron/pull/2879#issuecomment-386197899 @nlu90 - done. updating the master. This is an

Re: Copyright Violations

Agreed and thanks for the suggestions! On Wed, May 2, 2018 at 7:52 PM, P. Taylor Goetz wrote: > Thank you all for stepping up to correct this. > > With my mentor hat on... > > Trademark, licensing, and copyright hygiene are very important for ASF > projects. > > I’d encourage

Re: Copyright Violations

Thank you all for stepping up to correct this. With my mentor hat on... Trademark, licensing, and copyright hygiene are very important for ASF projects. I’d encourage everyone to proactively research branding, release, and other policies. ASF documentation can seem pretty scattered, but it

[GitHub] nlu90 commented on issue #2884: move downloader registry map to yaml

nlu90 commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-386154314 LGTM. Let's see if @kramasamy has any comments. This is an automated message

[GitHub] nlu90 commented on issue #2884: move downloader registry map to yaml

nlu90 commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-386154314 LGTM This is an automated message from the Apache Git Service. To respond to

[GitHub] huijunwu commented on a change in pull request #2884: move downloader registry map to yaml

huijunwu commented on a change in pull request #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#discussion_r185668816 ## File path: heron/downloaders/src/java/org/apache/heron/downloader/DownloadRunner.java ## @@ -38,7

[GitHub] huijunwu commented on a change in pull request #2884: move downloader registry map to yaml

huijunwu commented on a change in pull request #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#discussion_r185668803 ## File path: heron/downloaders/src/java/org/apache/heron/downloader/DownloadRunner.java ## @@ -38,7

[GitHub] nlu90 commented on a change in pull request #2884: move downloader registry map to yaml

nlu90 commented on a change in pull request #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#discussion_r185652663 ## File path: heron/downloaders/src/java/org/apache/heron/downloader/DownloadRunner.java ## @@ -38,7

[GitHub] nwangtw opened a new pull request #2885: Update license text in H files

nwangtw opened a new pull request #2885: Update license text in H files URL: https://github.com/apache/incubator-heron/pull/2885 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] tomncooper commented on issue #2877: Compilation error in a container

tomncooper commented on issue #2877: Compilation error in a container URL: https://github.com/apache/incubator-heron/issues/2877#issuecomment-386131052 Have you checked out one of the release tags or are you building from the head of the master branch? Try checking out the latest tag,

[GitHub] comes5 commented on issue #2877: Compilation error in a container

comes5 commented on issue #2877: Compilation error in a container URL: https://github.com/apache/incubator-heron/issues/2877#issuecomment-386130089 So, I am trying with virtualbox now, following the heron documentation with ubuntu 16.04. So far no errors from thrift and scribe, but the

[GitHub] nlu90 opened a new pull request #2883: check checkpoint file exists before deleting it

nlu90 opened a new pull request #2883: check checkpoint file exists before deleting it URL: https://github.com/apache/incubator-heron/pull/2883 Currently, if there's no checkpoint file under the root dir, the LocalFileSystemStorage will raise an NPE directly and cause the process to stop

[GitHub] nlu90 closed pull request #2878: Update NOTICE file

nlu90 closed pull request #2878: Update NOTICE file URL: https://github.com/apache/incubator-heron/pull/2878 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[GitHub] nlu90 commented on issue #2879: remove thrift and scribe to prepare for apache release

nlu90 commented on issue #2879: remove thrift and scribe to prepare for apache release URL: https://github.com/apache/incubator-heron/pull/2879#issuecomment-386028654 Please also clean up the scribe and thrift test directory.

[GitHub] kramasamy commented on issue #2877: Compilation error in a container

kramasamy commented on issue #2877: Compilation error in a container URL: https://github.com/apache/incubator-heron/issues/2877#issuecomment-385885625 @comes5 - in the new PR #2879 - we are removing the scribe and the thrift executable. Once this is merged, this error will go away.

[GitHub] comes5 commented on issue #2877: Compilation error in a container

comes5 commented on issue #2877: Compilation error in a container URL: https://github.com/apache/incubator-heron/issues/2877#issuecomment-385878877 Ok tried to compile using the instructions in /docker/Readme.md but there seem to be another error: `INFO: Starting clean (this may take a

[GitHub] kramasamy opened a new pull request #2879: remove thrift and scribe to prepare for apache release

kramasamy opened a new pull request #2879: remove thrift and scribe to prepare for apache release URL: https://github.com/apache/incubator-heron/pull/2879 This is an automated message from the Apache Git Service. To respond