[GitHub] huijunwu commented on issue #2884: move downloader registry map to yaml

2018-05-08 Thread GitBox
huijunwu commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-387594464 @jerrypeng updated to be compatible with `downloader `. could you review it again

Re: Heron OSS Sync

2018-05-08 Thread Karthik Ramasamy
+1 On Tue, May 8, 2018 at 4:50 PM, Ning Wang wrote: > Agreed. :) > > On Tue, May 8, 2018 at 4:49 PM, P. Taylor Goetz wrote: > > > +1 to everything Dave said. > > > > Your first Apache release will likely be the hardest. At times it may > even > > seem

Re: Heron OSS Sync

2018-05-08 Thread Ning Wang
Agreed. :) On Tue, May 8, 2018 at 4:49 PM, P. Taylor Goetz wrote: > +1 to everything Dave said. > > Your first Apache release will likely be the hardest. At times it may even > seem like hazing. You may get a lot of feedback that seems like nitpicking. > > That is not the

Re: Heron OSS Sync

2018-05-08 Thread P. Taylor Goetz
+1 to everything Dave said. Your first Apache release will likely be the hardest. At times it may even seem like hazing. You may get a lot of feedback that seems like nitpicking. That is not the case. The goal is to make sure to make sure Apache Heron knows how to make compliant releases and

Re: Heron OSS Sync

2018-05-08 Thread Ning Wang
Got it. Thanks! Yeah. Cadidate is our goal. On Tue, May 8, 2018 at 4:21 PM, Dave Fisher wrote: > Thanks for the quick update! > > > On May 8, 2018, at 4:08 PM, Ning Wang wrote: > > > > And here is a brief notes: > > > > > > > > * - Our current

Re: Heron OSS Sync

2018-05-08 Thread Karthik Ramasamy
Thanks Dave for the feedback. If we can get the release candidate out for review - it will be a good first step. It will give mentors and others to review the source, NOTICE, LICENSE and any other items. Based on the feedback, we can iterate on a few release candidates. cheers /karthik On Tue,

Re: Heron OSS Sync

2018-05-08 Thread Dave Fisher
Thanks for the quick update! > On May 8, 2018, at 4:08 PM, Ning Wang wrote: > > And here is a brief notes: > > > > * - Our current focus is to have our first apache release by the end of > this week (we should be pretty much ready for it) If you mean have the first

[GitHub] tomncooper commented on issue #2875: Duration reporting inconsistency

2018-05-08 Thread GitBox
tomncooper commented on issue #2875: Duration reporting inconsistency URL: https://github.com/apache/incubator-heron/issues/2875#issuecomment-387559852 Duplicate of #2874 This is an automated message from the Apache Git

[GitHub] nlu90 commented on a change in pull request #2852: first of the connectors - twitter spout

2018-05-08 Thread GitBox
nlu90 commented on a change in pull request #2852: first of the connectors - twitter spout URL: https://github.com/apache/incubator-heron/pull/2852#discussion_r186883119 ## File path: third_party/cereal/BUILD ## @@ -0,0 +1,126 @@ +licenses(["notice"]) Review comment:

[GitHub] nlu90 commented on a change in pull request #2852: first of the connectors - twitter spout

2018-05-08 Thread GitBox
nlu90 commented on a change in pull request #2852: first of the connectors - twitter spout URL: https://github.com/apache/incubator-heron/pull/2852#discussion_r186883787 ## File path: connectors/heron-twitter/src/java/com/twitter/heron/twitter/spout/Twitter.java ## @@

[GitHub] nlu90 closed issue #2877: Compilation error in a container

2018-05-08 Thread GitBox
nlu90 closed issue #2877: Compilation error in a container URL: https://github.com/apache/incubator-heron/issues/2877 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] nlu90 commented on issue #2877: Compilation error in a container

2018-05-08 Thread GitBox
nlu90 commented on issue #2877: Compilation error in a container URL: https://github.com/apache/incubator-heron/issues/2877#issuecomment-387558212 @comes5 In short, Yes. You'll need to build the whole project to get the core jars for testing. But since bazel is smart enough to do the

Heron OSS Sync

2018-05-08 Thread Ning Wang
Hi, The heron OSS sync meeting will be happening today at 2.00 pm PST. Please use the following hangout link: https://hangouts.google.com/hangouts/_/streaml.io/oss-heron-sync?authuser=0 See you all then.

[GitHub] ajorgensen opened a new issue #2897: Potential double free crash in BaseConnection destructor

2018-05-08 Thread GitBox
ajorgensen opened a new issue #2897: Potential double free crash in BaseConnection destructor URL: https://github.com/apache/incubator-heron/issues/2897 On version `0.17.8` it appears that there may be a double free error that causes a stream manager to crash sometimes in the destructor

[GitHub] skanjila opened a new issue #2896: Design of streaming machine learning algorithms in heron

2018-05-08 Thread GitBox
skanjila opened a new issue #2896: Design of streaming machine learning algorithms in heron URL: https://github.com/apache/incubator-heron/issues/2896 The goal of this effort is to design and document streaming real time machine learning algorithms that can fit into a storm topology and

[GitHub] kramasamy closed pull request #2895: Nwang/update license in other files

2018-05-08 Thread GitBox
kramasamy closed pull request #2895: Nwang/update license in other files URL: https://github.com/apache/incubator-heron/pull/2895 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] nwangtw commented on a change in pull request #2884: move downloader registry map to yaml

2018-05-08 Thread GitBox
nwangtw commented on a change in pull request #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#discussion_r186623390 ## File path: heron/downloaders/src/java/org/apache/heron/downloader/DownloadRunner.java ## @@ -18,17