Re: Heron github emails [VOTE RESULTS]

2018-05-18 Thread Ning Wang
+1! On Fri, May 18, 2018 at 7:28 PM, Karthik Ramasamy wrote: > +1 as well. > > On Fri, May 18, 2018 at 7:18 PM Josh Fischer wrote: > > > We have 7 positive votes and NO vetos. I will take the necessary steps > to > > get this change completed. > > > >

Re: Heron github emails [VOTE RESULTS]

2018-05-18 Thread Karthik Ramasamy
+1 as well. On Fri, May 18, 2018 at 7:18 PM Josh Fischer wrote: > We have 7 positive votes and NO vetos. I will take the necessary steps to > get this change completed. > > Thank you for the guidance Dave. > > - Josh > > On Fri, May 18, 2018 at 4:18 PM, Dave Fisher

Re: Heron github emails [VOTE RESULTS]

2018-05-18 Thread Josh Fischer
We have 7 positive votes and NO vetos. I will take the necessary steps to get this change completed. Thank you for the guidance Dave. - Josh On Fri, May 18, 2018 at 4:18 PM, Dave Fisher wrote: > Hi Josh, > > Reply to this thread with [VOTE RESULTS] in the message

Re: Heron github emails

2018-05-18 Thread Dave Fisher
Hi Josh, Reply to this thread with [VOTE RESULTS] in the message subject. You would then fill out an INFRA JIRA requesting the change. Use lists.apache.org to get permalinks to the first email and the results email. Include those in the JIRA. Regards, Dave Sent from my iPhone > On May 18,

[GitHub] nwangtw commented on issue #2794: update container count to 2 in the example ExclamationTopology

2018-05-18 Thread GitBox
nwangtw commented on issue #2794: update container count to 2 in the example ExclamationTopology URL: https://github.com/apache/incubator-heron/pull/2794#issuecomment-390318771 lgtm. but I am curious about the reason to have this PR.

[GitHub] nwangtw commented on issue #2807: remove three other roundings in cpu calculation

2018-05-18 Thread GitBox
nwangtw commented on issue #2807: remove three other roundings in cpu calculation URL: https://github.com/apache/incubator-heron/pull/2807#issuecomment-390299897 It is more about "why there was a Math.rounding()". The rounding logic doesn't seem necessary if we assume cpu # can be

Re: Heron github emails

2018-05-18 Thread Josh Fischer
To All, What needs to be done to prevent the duplicate gitbox emails sent every time there is activity on github? I would be happy to complete this task. -Josh On Wed, May 2, 2018 at 12:53 PM, Eren Avsarogullari < erenavsarogull...@gmail.com> wrote: > +1 > > On Wed, May 2, 2018, 18:50 Neng Lu

[GitHub] nlu90 commented on issue #1093: heron package manager tool

2018-05-18 Thread GitBox
nlu90 commented on issue #1093: heron package manager tool URL: https://github.com/apache/incubator-heron/pull/1093#issuecomment-390290315 Will close this PR for it's opened too long ago and now we have the downloaders spi.

[GitHub] nlu90 closed pull request #1093: heron package manager tool

2018-05-18 Thread GitBox
nlu90 closed pull request #1093: heron package manager tool URL: https://github.com/apache/incubator-heron/pull/1093 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] nlu90 commented on issue #2794: update container count to 2 in the example ExclamationTopology

2018-05-18 Thread GitBox
nlu90 commented on issue #2794: update container count to 2 in the example ExclamationTopology URL: https://github.com/apache/incubator-heron/pull/2794#issuecomment-390289767 @kramasamy @nwangtw @huijunw Any ideas on this PR?

[GitHub] nlu90 commented on issue #2807: remove three other roundings in cpu calculation

2018-05-18 Thread GitBox
nlu90 commented on issue #2807: remove three other roundings in cpu calculation URL: https://github.com/apache/incubator-heron/pull/2807#issuecomment-390288719 What's the background of removing this `Math.rounding()`? This

[GitHub] nlu90 commented on issue #2850: Add SSL support for stream manager connections

2018-05-18 Thread GitBox
nlu90 commented on issue #2850: Add SSL support for stream manager connections URL: https://github.com/apache/incubator-heron/pull/2850#issuecomment-390287634 @ajorgensen seems several unit tests failed. Could you update it and for a further review?

[GitHub] nlu90 commented on issue #2691: Fix for localhost metrics manager

2018-05-18 Thread GitBox
nlu90 commented on issue #2691: Fix for localhost metrics manager URL: https://github.com/apache/incubator-heron/pull/2691#issuecomment-390286652 @jrcrawfo Ping for this PR, any updates? This is an automated message from the

[GitHub] nlu90 closed pull request #2872: read merge instructions;

2018-05-18 Thread GitBox
nlu90 closed pull request #2872: read merge instructions; URL: https://github.com/apache/incubator-heron/pull/2872 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] nlu90 closed pull request #2902: Make MetricsManager.java a target so that it can be customized

2018-05-18 Thread GitBox
nlu90 closed pull request #2902: Make MetricsManager.java a target so that it can be customized URL: https://github.com/apache/incubator-heron/pull/2902 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] nlu90 commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-18 Thread GitBox
nlu90 commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390284998 @bornej It is possible to utilizing multithreads in Heron even without this patch. The only requirement is that you need to ack/fail the

[GitHub] bornej commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-18 Thread GitBox
bornej commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390241133 Hi, while investigating the possibility of using multi-threaded bolt/spouts, I stumbled upon this PR. I don't know if this is the