Thanks! I am going to examine the files and add a rat-exception list.
On Wed, Aug 29, 2018 at 10:49 AM Dave Fisher <dave2w...@comcast.net> wrote: > Hi - > > -1 (binding) > > Checked signature - passes. > Checksums pass - SHA1 should no longer be provided. > > README.md is pointing to legacy documentation and does not include a > reference to: > > https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/ > > RAT Check. > I ran Apache Rat which reveals files w/o Headers. > https://creadur.apache.org/rat/apache-rat/index.html > Some files do not require headers, but many are still missing these. > Please see http://www.apache.org/legal/src-headers.html#faq-exceptions > Files that are exceptions should be placed into a “rat-excludes” file > > Here is the command and the list. > $ java -jar apache-rat-0.12.jar . | grep '== File' > == File: ./.gitignore > == File: ./.gitmodules > == File: ./.htaccess > == File: ./.travis.yml > == File: ./ADOPTERS.md > == File: ./WORKSPACE > == File: ./config/autogen.sh > == File: ./config/configure.ac > == File: ./config/heron.def > == File: ./config/m4/acx_pthread.m4 > == File: ./config/m4/gxx_stdio_filebuf.m4 > == File: ./deploy/docker/README.md > == File: ./deploy/kubernetes/general/README.md > == File: ./deploy/kubernetes/helm/.helmignore > == File: ./deploy/kubernetes/helm/Chart.yaml.template > == File: ./deploy/kubernetes/helm/values.yaml.template > == File: ./deploy/kubernetes/helm/templates/NOTES.txt > == File: ./deploy/kubernetes/helm/templates/_helpers.tpl > == File: ./deploy/kubernetes/minikube/README.md > == File: ./docker/.tarignore > == File: ./docker/Readme.md > == File: ./docker/base/Dockerfile.base.debian9 > == File: ./docker/base/conf/sandbox.conf > == File: ./docker/base/conf/zookeeper.conf > == File: ./docker/compile/Dockerfile.centos7 > == File: ./docker/compile/Dockerfile.debian9 > == File: ./docker/compile/Dockerfile.ubuntu14.04 > == File: ./docker/compile/Dockerfile.ubuntu16.04 > == File: ./docker/dist/Dockerfile.dist.centos7 > == File: ./docker/dist/Dockerfile.dist.debian9 > == File: ./docker/dist/Dockerfile.dist.ubuntu14.04 > == File: ./docker/dist/Dockerfile.dist.ubuntu16.04 > == File: ./docker/dist/conf/sandbox.conf > == File: ./docker/dist/conf/zookeeper.conf > == File: > ./heron/api/src/META-INF/services/javax.annotation.processing.Processor > == File: ./heron/api/src/java/shade.conf > == File: ./heron/ckptmgr/src/java/shade.conf > == File: ./heron/common/src/cpp/network/misc/tests.proto > == File: ./heron/common/src/python/__init__.py > == File: ./heron/common/tests/cpp/network/unittests.proto > == File: ./heron/config/src/yaml/conf/aurora/downloader.yaml > == File: ./heron/config/src/yaml/conf/aurora/heron.aurora > == File: ./heron/config/src/yaml/conf/examples/README.md > == File: ./heron/config/src/yaml/conf/examples/downloader.yaml > == File: ./heron/config/src/yaml/conf/kubernetes/downloader.yaml > == File: ./heron/config/src/yaml/conf/local/downloader.yaml > == File: ./heron/config/src/yaml/conf/localzk/downloader.yaml > == File: ./heron/config/src/yaml/conf/nomad/downloader.yaml > == File: ./heron/config/src/yaml/conf/sandbox/downloader.yaml > == File: ./heron/config/src/yaml/conf/standalone/downloader.yaml > == File: ./heron/config/src/yaml/conf/standalone/resources/master.hcl > == File: > ./heron/config/src/yaml/conf/standalone/templates/apiserver.template.hcl > == File: > ./heron/config/src/yaml/conf/standalone/templates/heron_tools.template.hcl > == File: > ./heron/config/src/yaml/conf/standalone/templates/slave.template.hcl > == File: ./heron/config/src/yaml/conf/test/README.md > == File: ./heron/config/src/yaml/conf/yarn/downloader.yaml > == File: ./heron/instance/src/java/shade.conf > == File: ./heron/instance/src/python/__init__.py > == File: ./heron/io/dlog/README.md > == File: ./heron/proto/ckptmgr.proto > == File: ./heron/proto/common.proto > == File: ./heron/proto/execution_state.proto > == File: ./heron/proto/metrics.proto > == File: ./heron/proto/networktests.proto > == File: ./heron/proto/packing_plan.proto > == File: ./heron/proto/physical_plan.proto > == File: ./heron/proto/scheduler.proto > == File: ./heron/proto/stats.proto > == File: ./heron/proto/stmgr.proto > == File: ./heron/proto/tmaster.proto > == File: ./heron/proto/topology.proto > == File: ./heron/proto/tuple.proto > == File: > ./heron/scheduler-core/tests/resources/JsonFormatterUtilsExpectedJson.txt > == File: > ./heron/scheduler-core/tests/resources/SubmitDryRunOutputATable.txt > == File: > ./heron/scheduler-core/tests/resources/SubmitDryRunOutputATableNonRich.txt > == File: > ./heron/scheduler-core/tests/resources/UpdateDryRunOutputATable.txt > == File: > ./heron/scheduler-core/tests/resources/UpdateDryRunOutputATableNonRich.txt > == File: > ./heron/scheduler-core/tests/resources/UpdateDryRunOutputBTable.txt > == File: > ./heron/scheduler-core/tests/resources/UpdateDryRunOutputBTableNonRich.txt > == File: ./heron/shell/assets/jquery.js > == File: ./heron/tools/explorer/tests/python/info.json > == File: ./heron/tools/explorer/tests/python/logicalplan.json > == File: ./heron/tools/explorer/tests/python/metrics.json > == File: ./heron/tools/explorer/tests/python/physicalplan.json > == File: ./heron/tools/explorer/tests/python/topologies.json > == File: ./heron/tools/ui/resources/static/css/bootstrap.min.css > == File: > ./heron/tools/ui/resources/static/fonts/glyphicons-halflings-regular.svg > == File: ./heron/tools/ui/resources/static/js/bootstrap.min.js > == File: ./heron/tools/ui/resources/static/js/d3-tip.min.0.6.3.js > == File: ./heron/tools/ui/resources/static/js/d3.min.3.4.11.js > == File: ./heron/tools/ui/resources/static/js/html5-trunk.js > == File: > ./heron/tools/ui/resources/static/js/jquery-ui-1.8.23.custom.min.js > == File: ./heron/tools/ui/resources/static/js/jquery.min.js > == File: ./heron/tools/ui/resources/static/js/list.min.1.1.1.js > == File: ./heron/tools/ui/resources/static/js/moment.min.2.8.3.js > == File: ./heron/tools/ui/resources/static/js/underscore-min.1.6.0.js > == File: ./heron/tools/ui/resources/static/js/underscore-min.map > == File: ./integration_test/README.md > == File: ./integration_test/src/__init__.py > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/all_grouping/AllGroupingResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/basic_topology_one_task/BasicTopologyOneTaskResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/bolt_double_emit_tuples/BoltDoubleEmitTuplesResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/fields_grouping/FieldsGroupingResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/global_grouping/GlobalGroupingResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/multi_spouts_multi_tasks/MultiSpoutsMultiTasksResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/non_grouping/NonGroupingResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/one_bolt_multi_tasks/OneBoltMultiTasksResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/one_spout_bolt_multi_tasks/OneSpoutBoltMultiTasksResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/one_spout_multi_tasks/OneSpoutMultiTasksResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/one_spout_two_bolts/OneSpoutTwoBoltsResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/serialization/SerializationTopologyResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/shuffle_grouping/ShuffleGroupingResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/windowing/count/SlidingCountWindowTest1Results.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/windowing/count/SlidingCountWindowTest2Results.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/windowing/count/SlidingCountWindowTest3Results.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/windowing/count/TumblingCountWindowTest1Results.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/windowing/count/TumblingCountWindowTest2Results.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/windowing/count/TumblingCountWindowTest3Results.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/windowing/stateful/StatefulWindowingTestResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/windowing/time/SlidingTimeWindowTest1Results.json > == File: > ./integration_test/src/java/org/apache/heron/integration_test/topology/windowing/watermark/SlidingWatermarkEventTimeWindowTest1Results.json > == File: > ./integration_test/src/java/org/apache/heron/integration_topology_test/topology/basic_topology_one_task_scale_down/BasicTopologyOneTaskResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_topology_test/topology/basic_topology_one_task_scale_up/BasicTopologyOneTaskResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_topology_test/topology/basic_topology_one_task_scale_up_down/BasicTopologyOneTaskResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_topology_test/topology/fields_grouping/FieldsGroupingResults.json > == File: > ./integration_test/src/java/org/apache/heron/integration_topology_test/topology/stateful_basic_topology_one_task/StatefulBasicTopologyOneTaskState.json > == File: > ./integration_test/src/java/org/apache/heron/integration_topology_test/topology/stateful_basic_topology_one_task/StatefulBasicTopologyOneTaskTopo.json > == File: ./integration_test/src/python/__init__.py > == File: ./integration_test/src/python/integration_test/common/__init__.py > == File: > ./integration_test/src/python/integration_test/topology/all_grouping/__init__.py > == File: > ./integration_test/src/python/integration_test/topology/all_grouping/all_grouping_result.json > == File: > ./integration_test/src/python/integration_test/topology/basic_one_task/__init__.py > == File: > ./integration_test/src/python/integration_test/topology/basic_one_task/basic_one_task_result.json > == File: > ./integration_test/src/python/integration_test/topology/bolt_double_emit_tuples/__init__.py > == File: > ./integration_test/src/python/integration_test/topology/bolt_double_emit_tuples/bolt_double_emit_tuples_result.json > == File: > ./integration_test/src/python/integration_test/topology/fields_grouping/__init__.py > == File: > ./integration_test/src/python/integration_test/topology/fields_grouping/fields_grouping_result.json > == File: > ./integration_test/src/python/integration_test/topology/global_grouping/__init__.py > == File: > ./integration_test/src/python/integration_test/topology/global_grouping/global_grouping_result.json > == File: > ./integration_test/src/python/integration_test/topology/multi_spouts_multi_tasks/__init__.py > == File: > ./integration_test/src/python/integration_test/topology/multi_spouts_multi_tasks/multi_spouts_multi_tasks_result.json > == File: > ./integration_test/src/python/integration_test/topology/none_grouping/__init__.py > == File: > ./integration_test/src/python/integration_test/topology/none_grouping/none_grouping_result.json > == File: > ./integration_test/src/python/integration_test/topology/one_bolt_multi_tasks/__init__.py > == File: > ./integration_test/src/python/integration_test/topology/one_bolt_multi_tasks/one_bolt_multi_tasks_result.json > == File: > ./integration_test/src/python/integration_test/topology/one_spout_bolt_multi_tasks/__init__.py > == File: > ./integration_test/src/python/integration_test/topology/one_spout_bolt_multi_tasks/one_spout_bolt_multi_tasks_result.json > == File: > ./integration_test/src/python/integration_test/topology/one_spout_multi_tasks/__init__.py > == File: > ./integration_test/src/python/integration_test/topology/one_spout_multi_tasks/one_spout_multi_tasks_result.json > == File: > ./integration_test/src/python/integration_test/topology/one_spout_two_bolts/__init__.py > == File: > ./integration_test/src/python/integration_test/topology/one_spout_two_bolts/one_spout_two_bolts_result.json > == File: > ./integration_test/src/python/integration_test/topology/shuffle_grouping/__init__.py > == File: > ./integration_test/src/python/integration_test/topology/shuffle_grouping/shuffle_grouping_result.json > == File: > ./integration_test/src/python/integration_test/topology/streamlet/__init__.py > == File: > ./integration_test/src/python/integration_test/topology/streamlet/word_count_streamlet_results.json > == File: > ./integration_test/src/python/local_test_runner/resources/test.conf > == File: ./integration_test/src/python/test_runner/resources/test.json > == File: > ./integration_test/src/python/topology_test_runner/resources/test.json > == File: > ./integration_test/src/scala/org/apache/heron/integration_test/topology/scala_streamlet_with_filter_and_transform/ScalaStreamletWithFilterAndTransformResults.json > == File: > ./integration_test/src/scala/org/apache/heron/integration_test/topology/scala_streamlet_with_map_and_flatmap_and_filter_and_clone/ScalaStreamletWithMapAndFlatMapAndFilterAndCloneResults.json > == File: ./release/release-process.md > == File: ./release/release.spec > == File: ./scripts/compile/README.md > == File: ./scripts/packages/debian/description > == File: ./scripts/packages/heronpy/__apiinit__.py.template > == File: ./scripts/packages/heronpy/__connectorsinit__.py.template > == File: ./scripts/packages/heronpy/__streamletinit__.py.template > == File: ./scripts/packages/heronpy/requirements.txt > == File: ./scripts/packages/heronpy/setup.py.template > == File: ./scripts/release/README.md > == File: ./scripts/resources/idea/.name > == File: ./storm-compatibility/src/java/shade.conf > == File: ./third_party/cereal/cereal.BUILD > == File: ./third_party/glog/glog.BUILD > == File: ./third_party/gperftools/gperftools.BUILD > == File: ./third_party/gtest/gtest.BUILD > == File: ./third_party/helm/helm.BUILD > == File: ./third_party/java/Empty.java > == File: > ./third_party/java/jarjar/src/main/resources/com/tonicsystems/jarjar/help.txt > == File: ./third_party/kashmir/abstractrandomstream.h > == File: ./third_party/kashmir/devrandom.h > == File: ./third_party/kashmir/empty.cc > == File: ./third_party/kashmir/iofwd.h > == File: ./third_party/kashmir/iostate.h > == File: ./third_party/kashmir/polydevrandom.h > == File: ./third_party/kashmir/randomstream.h > == File: ./third_party/kashmir/uuid.h > == File: ./third_party/kashmir/tests/cli.cpp > == File: ./third_party/kashmir/tests/command.cpp > == File: ./third_party/libevent/libevent.BUILD > == File: ./third_party/libunwind/libunwind-1.1-cache.patch > == File: ./third_party/libunwind/libunwind-1.1-config.patch > == File: ./third_party/libunwind/libunwind-1.1-lzma-link.patch > == File: ./third_party/libunwind/libunwind.BUILD > == File: ./third_party/nomad/nomad.BUILD > == File: ./third_party/python/cpplint/cpplint.py > == File: ./third_party/python/pylint/main.py > == File: ./third_party/python/semver/PKG-INFO > == File: ./third_party/python/semver/README.md > == File: ./third_party/python/semver/semver.py > == File: ./third_party/python/semver/setup.py > == File: ./third_party/yaml-cpp/yaml.BUILD > == File: ./third_party/zookeeper/zookeeper.BUILD > == File: ./tools/bazel.rc > == File: ./tools/build_rules/prelude_bazel > == File: ./tools/docker/bazel.rc > == File: ./tools/java/src/org/apache/bazel/checkstyle/heron_header.txt > == File: ./tools/python/checkstyle.ini > == File: ./tools/rules/genproto.bzl > == File: ./tools/rules/heron_deps.bzl > == File: ./tools/rules/java_tests.bzl > == File: ./tools/rules/newgenproto.bzl > == File: ./tools/rules/proto.bzl > == File: ./tools/rules/pex/testlauncher.sh.template > == File: ./tools/travis/bazel.rc > == File: ./tools/travis/toolchain/CROSSTOOL > == File: ./vagrant/.gitignore > == File: ./vagrant/README.md > > Regards, > Dave > > On Aug 23, 2018, at 1:42 PM, Neng Lu <freen...@gmail.com> wrote: > > Hi All, > > This is the 3rd release candidate for Apache Heron, version > 0.20.0-incubating. Thank Dave Fisher for providing various feedback for the > first release candidate. Also, thank Ning Wang for finding the compilation > issue for the second release candidate. We've resolved all the feedbacks > and thus call for voting of the 3rd release candidate. > > It is the starting point of Heron and contains heron's main features, such > as streaming > processing, stateful processing, streamlet API, API server, eco support, > etc. > > The full list of changes and fixes are available: > > https://github.com/apache/incubator-heron/compare/0.17.8...release/v-0.20.0-incubating > > *** Please download, test and vote on this release. This vote will stay > open > for at least 72 hours *** > > Source files: > > https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.0-incubating-candidate-3/ > > SHA-1 checksums: > 18181be53b697f68e6a4fdf6622dd42aba9fd095 > ./incubator-heron-v-0.20.0-incubating-candidate-3.tar.gz > > The tag to be voted upon: > v0.20.0-incubating-candidate-3 (7fb0df3b6ec29d8c51f9d43ad7e8ecb3d45d643a) > > https://github.com/apache/incubator-heron/releases/tag/v-0.20.0-incubating-candidate-3 > > Please download the source package, and follow the compiling guide( > > https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/ > ) > to build and run the Heron locally. > > Best Regards, > Neng Lu > > >
