Re: Hermetic Build Proposal

2018-10-15 Thread Neng Lu
This is a great proposal!

On Sat, Oct 13, 2018 at 7:33 PM Sree V 
wrote:

> created an issue to implement and track this.
> https://github.com/apache/incubator-heron/issues/3045
>
>
> Thank you.Sree
>
> On Friday, October 12, 2018, 8:43:40 PM PDT, Karthik Ramasamy <
> kart...@streaml.io> wrote:
>
>  Awesome! That will be great addition.
>
> On Fri, Oct 12, 2018 at 1:07 PM Ning Wang  wrote:
>
> > Sounds reasonable to me.
> >
> > On Fri, Oct 12, 2018 at 11:26 AM Josh Fischer 
> wrote:
> >
> > > Hey All,
> > >
> > > I've done some research and I do not think Heron's Bazel configuration
> is
> > > hermetic.  What I mean by this is that to build Heron we are relying on
> > the
> > > JDK on the host platform.  If JDK versions change across host platforms
> > it
> > > will create build issues for the developers.  I think we could reduce
> the
> > > amount of issues that occur by relying on a tool chain to provide the
> > > needed versions of our build tools through Bazel.  I imagine this could
> > be
> > > a bit of a task, so I think tackling Java first would be a good start
> to
> > > resolving this issue and allowing for cleaner builds.
> > >
> > > Any thoughts? Comments? Concerns?
> > >
> > > See below for a toolchains explanation:
> > >
> > >
> >
> https://docs.bazel.build/versions/master/remote-execution-rules.html#invoking-build-tools-through-toolchain-rules
> > >
> > > -Josh
> > >
> >
>



-- 
Best Regards,
Neng


Re: Hermetic Build Proposal

2018-10-12 Thread Ning Wang
Sounds reasonable to me.

On Fri, Oct 12, 2018 at 11:26 AM Josh Fischer  wrote:

> Hey All,
>
> I've done some research and I do not think Heron's Bazel configuration is
> hermetic.  What I mean by this is that to build Heron we are relying on the
> JDK on the host platform.  If JDK versions change across host platforms it
> will create build issues for the developers.  I think we could reduce the
> amount of issues that occur by relying on a tool chain to provide the
> needed versions of our build tools through Bazel.  I imagine this could be
> a bit of a task, so I think tackling Java first would be a good start to
> resolving this issue and allowing for cleaner builds.
>
> Any thoughts? Comments? Concerns?
>
> See below for a toolchains explanation:
>
> https://docs.bazel.build/versions/master/remote-execution-rules.html#invoking-build-tools-through-toolchain-rules
>
> -Josh
>