[GitHub] huijunwu commented on a change in pull request #2839: fix healthmgr metrics

2018-04-12 Thread GitBox
huijunwu commented on a change in pull request #2839: fix healthmgr metrics URL: https://github.com/apache/incubator-heron/pull/2839#discussion_r181042810 ## File path: heron/healthmgr/src/java/com/twitter/heron/healthmgr/HealthManager.java ## @@ -195,6 +195,14 @@ public

[GitHub] huijunwu commented on a change in pull request #2839: fix healthmgr metrics

2018-04-10 Thread GitBox
huijunwu commented on a change in pull request #2839: fix healthmgr metrics URL: https://github.com/apache/incubator-heron/pull/2839#discussion_r180531105 ## File path: heron/healthmgr/src/java/com/twitter/heron/healthmgr/HealthManager.java ## @@ -276,10 +283,8 @@ public

[GitHub] huijunwu commented on a change in pull request #2839: fix healthmgr metrics

2018-04-10 Thread GitBox
huijunwu commented on a change in pull request #2839: fix healthmgr metrics URL: https://github.com/apache/incubator-heron/pull/2839#discussion_r180531015 ## File path: heron/healthmgr/src/java/com/twitter/heron/healthmgr/HealthManager.java ## @@ -211,11 +219,13 @@ public

[GitHub] huijunwu commented on a change in pull request #2839: fix healthmgr metrics

2018-04-10 Thread GitBox
huijunwu commented on a change in pull request #2839: fix healthmgr metrics URL: https://github.com/apache/incubator-heron/pull/2839#discussion_r180530960 ## File path: heron/executor/src/python/heron_executor.py ## @@ -498,7 +498,11 @@ def _get_healthmgr_cmd(self):

[GitHub] huijunwu commented on a change in pull request #2839: fix healthmgr metrics

2018-04-06 Thread GitBox
huijunwu commented on a change in pull request #2839: fix healthmgr metrics URL: https://github.com/apache/incubator-heron/pull/2839#discussion_r179892658 ## File path: heron/healthmgr/src/java/com/twitter/heron/healthmgr/HealthManagerMetrics.java ## @@ -136,44 +168,92 @@

[GitHub] huijunwu commented on a change in pull request #2839: fix healthmgr metrics

2018-04-06 Thread GitBox
huijunwu commented on a change in pull request #2839: fix healthmgr metrics URL: https://github.com/apache/incubator-heron/pull/2839#discussion_r179892658 ## File path: heron/healthmgr/src/java/com/twitter/heron/healthmgr/HealthManagerMetrics.java ## @@ -136,44 +168,92 @@